8000 fix: correct cli-config 'import' parameters by tawera-manaena · Pull Request #3445 · linz/basemaps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: correct cli-config 'import' parameters #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 15, 2025
Merged

fix: correct cli-config 'import' parameters #3445

merged 5 commits into from
May 15, 2025

Conversation

tawera-manaena
Copy link
Contributor
@tawera-manaena tawera-manaena commented May 13, 2025 •
edited
Loading

Motivation

In an earlier piece of work, we converted the import command from rushstack to cmd-ts. In doing so, we mistakenly converted the output parameter from an optional string, to a non-optional string.

This causes the basemaps-config's Deploy Nonprod job to fail. The failing command and error are as follows:

- name: Import config
  run: |
    ./scripts/bmc.sh ./index.cjs config import --config ${CONFIG_PATH} --commit
error: found 1 error

  1. No value provided for --output

Modifications

  1. Updated the cli-config package's importcommand's output parameter to an optional string.
  2. Added missing references to the cli package's tsconfig.json file to resolve type declaration errors.
  3. Re-ordered the root tsconfig.json file's references for easier maintenance.

Verification

I've captured a screenshot showing that the import command's output parameter is now optional:

I've also tested the import command locally with the --commit flag omitted. The command does require a valid config, so I used a random one from the S3 bucket:

node packages/cli/bin/bmc.js config import --config s3://linz-basemaps/config/config-28Fp43sn1XCmsh9QX6hwsyKESrm6e67PkG3agcVWmLEv.json.gz

We can see that the command executes successfully without requiring the output parameter:

...
[2025-05-14T02:08:06.137Z] INFO Change:Update type=ts record=ts_all description=all commit=false
[2025-05-14T02:08:06.137Z] INFO Import:Compare:Done objects=820 types={ ts=492 st=5 pv=1 im=322 }
[2025-05-14T02:08:06.138Z] INFO DryRun:Done

@tawera-manaena tawera-manaena marked this pull request as ready for review May 14, 2025 00:09
@tawera-manaena tawera-manaena requested a review from a team as a code owner May 14, 2025 00:09
blacha
blacha reviewed May 14, 2025
View reviewed changes
@tawera-manaena tawera-manaena added this pull request to the merge queue May 15, 2025
Merged via the queue into master with commit f349080 May 15, 2025
19 checks passed
@tawera-manaena tawera-manaena deleted the fix/cli-config-import-params branch May 15, 2025 03:26
@ccbblin ccbblin mentioned this pull request May 18, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 18, 2025
@ccbblin
release: v8.1.0 (#3449)
14a4364 
### [8.1.0](v8.0.0...v8.1.0)


### Bug Fixes

* correct cli-config 'import' parameters
([#3445](#3445))
([f349080](f349080)),
closes
[/github.com//pull/3427/commits/01a90a2b98bab02632a9637bfed2067c9c047c61#diff-48a5e932b724482f9a280931b7bb1188d26ef004b87c331aadfc7a7948ec7f70](https://github.com//github.com/linz/basemaps/pull/3427/commits/01a90a2b98bab02632a9637bfed2067c9c047c61/issues/diff-48a5e932b724482f9a280931b7bb1188d26ef004b87c331aadfc7a7948ec7f70)
[/github.com/linz/basemaps-config/blob/a5b8b9baaa9941314a13058e53945bc5db5f5357/.github/workflows/build.yml#L131](https://github.com//github.com/linz/basemaps-config/blob/a5b8b9baaa9941314a13058e53945bc5db5f5357/.github/workflows/build.yml/issues/L131)
* parsing of blocked api keys
([#3448](#3448))
([ab8bf72](ab8bf72))


### Features

* **lambda-tiler:** expose configuration id and hash if present
([#3446](#3446))
([43803b4](43803b4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacha blacha blacha approved these changes

@Wentao-Kuang Wentao-Kuang Awaiting requested review from Wentao-Kuang Wentao-Kuang is a code owner automatically assigned from linz/proj-basemaps-dev

@ccbblin ccbblin Awaiting requested review from ccbblin ccbblin is a code owner automatically assigned from linz/proj-basemaps-dev

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tawera-manaena @blacha
0