8000 feat(cli): rename cogify package to cli-raster BM-1262 by ccbblin · Pull Request #3433 · linz/basemaps · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(cli): rename cogify package to cli-raster BM-1262 #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 29, 2025
Merged

feat(cli): rename cogify package to cli-raster BM-1262 #3433

merged 5 commits into from
Apr 29, 2025

Conversation

ccbblin
Copy link
Contributor
@ccbblin ccbblin commented Apr 27, 2025 •
edited by jira bot
Loading

Motivation

We are in the process of migrating our Vector ETL system into Basemaps as a new package. To prepare for this migration, we are undertaking some housekeeping work (BM-1214). This pull request focuses on renaming cogify package to cli-raster.

Modifications

  • Rename packages/cogify to packages/cli-raster
  • Reference all the commands into cli package as sub-commands

Verification

check cli/bin/bmc.js cogify runs correctly

@ccbblin ccbblin marked this pull request as ready for review April 27, 2025 23:11
@ccbblin ccbblin requested a review from a team as a code owner April 27, 2025 23:11
@tawera-manaena
Copy link
Contributor

Looks good to me. Just one thought:

@Wentao-Kuang - Are we wanting to keep the sub-command as cogify or change it to raster?

image

@Wentao-Kuang
Copy link
Contributor

Looks good to me. Just one thought:

@Wentao-Kuang - Are we wanting to keep the sub-command as cogify or change it to raster?

image

I think cogify looks good to me.

@tawera-manaena
Copy link
Contributor

@Wentao-Kuang - I need to build this pull request as a container and make some adjustments in the topo-workflows repository. Once all is working on my end, I'll approve this work.

@tawera-manaena tawera-manaena added the container build pull request container for testing label Apr 28, 2025
tawera-manaena
tawera-manaena requested changes Apr 28, 2025
View reviewed changes
Copy link
Contributor
@tawera-manaena tawera-manaena left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccbblin - Noticed a few things from my container testing:

  1. Now that we've changed the package name, we should update the packageName parameter passed to the getLogger function:

    // before
const logger = getLogger(this, args, 'cogify');
// after
const logger = getLogger(this, args, 'cli-raster');

    Instances:

  2. Lerna highlights a circular dependency between the cli and cli-raster packages:

    image

    The cli-raster package doesn't actually depend on the cli package. Verified this with depcheck. We should remove the following devDependencies entry:

@ccbblin ccbblin added this pull request to the merge queue Apr 29, 2025
Merged via the queue into master with commit 36d4449 Apr 29, 2025
14 checks passed
@ccbblin ccbblin deleted the feat/rename-cogify-package-to-cli-raster branch April 29, 2025 01:00
@blacha blacha mentioned this pull request May 11, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 11, 2025
@blacha
release: v8.0.0 (#3443)
852c7c8 
# [v8.0.0](v7.17.0...v8.0.0)

**Please Note this is a work in progress release, please remain on v7
until the command line changes have been finalized**

### Bug Fixes

* **cli:** update landing deploy script with new cli-config package
BM-1260 ([#3431](#3431))
([4d7e86d](4d7e86d)),
closes
[/github.com/linz/basemaps/blob/e527a04fec65c82f8577642493e8fcb475762243/packages/landing/scripts/deploy.mjs#L1](https://github.com//github.com/linz/basemaps/blob/e527a04fec65c82f8577642493e8fcb475762243/packages/landing/scripts/deploy.mjs/issues/L1)
* ensure all linzjs packages are correctly labeled as deps
([#3439](#3439))
([de9df87](de9df87)),
closes [#3438](#3438)
* ensure api key blocks are set in ci/cd
([#3442](#3442))
([28f6403](28f6403))


### Features

* **cli-vector:** Extract cli to load schema json and prepare jobs to
process vector mbtiles. BM-1267
([#3429](#3429))
([db113e2](db113e2))
* **cli:** add cli-config package BM-1260
([#3428](#3428))
([4ca5a47](4ca5a47))
* **cli:** move cogify create-config into cli-config package BM-1261
([#3432](#3432))
([5f72430](5f72430))
* **cli:** rename cogify package to cli-raster BM-1262
([#3433](#3433))
([36d4449](36d4449))
* **cli:** update cli-package commands to cmd-ts BM-1259
([#3427](#3427))
([46cc342](46cc342))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tawera-manaena tawera-manaena tawera-manaena approved these changes

@Wentao-Kuang Wentao-Kuang Awaiting requested review from Wentao-Kuang Wentao-Kuang is a code owner automatically assigned from linz/proj-basemaps-dev

Assignees
No one assigned
Labels
container build pull request container for testing
413C Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccbblin @tawera-manaena @Wentao-Kuang
0