8000 fix: replaced created by with owner in base_document by pateljannat · Pull Request #25059 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: replaced created by with owner in base_document #25059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix: replaced created by with owner in base_document #25059

merged 1 commit into from
Feb 26, 2024

Conversation

pateljannat
Copy link
Contributor

Replaced created_by with owner in base_document.py and document.py

@pateljannat pateljannat requested review from a team and akhilnarang and removed request for a team February 26, 2024 12:00
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Feb 26, 2024
@ankush ankush added the defer backport Backports for some PR are deferred for a week or two to test them properly before releasing label Feb 26, 2024
@ankush ankush enabled auto-merge (squash) February 26, 2024 12:03
@ankush ankush added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 and removed add-test-cases Add test case to validate fix or enhancement defer backport Backports for some PR are deferred for a week or two to test them properly before releasing labels Feb 26, 2024
@ankush ankush merged commit 898f982 into frappe:develop Feb 26, 2024
mergify bot pushed a commit that referenced this pull request Feb 26, 2024
@pateljannat @mergify
fix: replaced created by with owner in base_document (#25059)
abdd44d 
(cherry picked from commit 898f982)
mergify bot pushed a commit that referenced this pull request Feb 26, 2024
@pateljannat @mergify
fix: replaced created by with owner in base_document (#25059)
8e00796 
(cherry picked from commit 898f982)

# Conflicts:
#	frappe/model/document.py
This was referenced Feb 26, 2024
Merged
Merged
ankush pushed a commit that referenced this pull request Feb 26, 2024
@mergify @pateljannat
fix: replaced created by with owner in base_document (#25059) (#25061)
bc5d09d 
(cherry picked from commit 898f982)

Co-authored-by: Jannat Patel <31363128+pateljannat@users.noreply.github.com>
ankush added a commit that referenced this pull request Feb 26, 2024
@mergify @pateljannat @ankush
fix: replaced created by with owner in base_document (backport #25059) (
ceb81a0 
#25060)

* fix: replaced created by with owner in base_document (#25059)

(cherry picked from commit 898f982)

# Conflicts:
#	frappe/model/document.py

* chore: conflict

---------

Co-authored-by: Jannat Patel <31363128+pateljannat@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Feb 28, 2024
@frappe-bot
chore(release): Bumped to Version 15.16.0
10fa309 
# [15.16.0](v15.15.0...v15.16.0) (2024-02-28)

### Bug Fixes

* **a11y:** Improve desk accessibility (backport [#23319](#23319)) ([#25023](#25023)) ([48665e6](48665e6))
* add context for row number label ([235f921](235f921))
* add show_dashboard field on custom fields ([#24984](#24984)) ([#24986](#24986)) ([34bca99](34bca99))
* added important to bold class. ([718973e](718973e))
* allow negative numbers in grid search ([#24989](#24989)) ([#24991](#24991)) ([e778fe9](e778fe9))
* Avoid add "null" to cc in communication in timeline (backport [#25092](#25092)) ([#25096](#25096)) ([06c7a87](06c7a87))
* Cast to string to handle int PK ([#24988](#24988)) ([#24993](#24993)) ([de3042b](de3042b))
* Check perm for library file before cloning ([#25117](#25117)) ([#25120](#25120)) ([173ff30](173ff30))
* **ControlTime:** Don't set datepicker's date if field is read only ([#25038](#25038)) ([#25076](#25076)) ([3e33ae3](3e33ae3))
* Correct type hint ([#24990](#24990)) ([#24995](#24995)) ([3f956c1](3f956c1))
* disable internal columns like _comments from report column selec… ([#24998](#24998)) ([#25000](#25000)) ([76a32f2](76a32f2))
* Don't init site if already init-ed during truncate ([#25033](#25033)) ([#25036](#25036)) ([5ddbfb2](5ddbfb2))
* **File Uploader:** call 'upload_files' without passing event object ([#25034](#25034)) ([#25087](#25087)) ([ce5abfc](ce5abfc))
* force `[]` as default for child tables ([#24000](#24000)) ([fea1623](fea1623))
* **formatters:** Translate Select value in format_value ([#24951](#24951)) ([#25077](#25077)) ([ff9e199](ff9e199))
* german translation of No. ([4e491b2](4e491b2))
* grid row default values not using model (backport [#23701](#23701)) ([#24896](#24896)) ([ad05acb](ad05acb))
* **grid:** Add type attribute to buttons ([#25021](#25021)) ([#25022](#25022)) ([d440fef](d440fef))
* Guess currency from report row if available ([#25009](#25009)) ([#25010](#25010)) ([dfcee61](dfcee61))
* handle total rows in number card ([#25011](#25011)) ([#25012](#25012)) ([4882bfc](4882bfc))
* invalid lru_cache usage ([#25046](#25046)) ([#25047](#25047)) ([e275851](e275851))
* **module_map:** only include apps installed on the site - not everything on the bench (backport [#24688](#246
8000
88)) ([#25122](#25122)) ([79e7c57](79e7c57))
* Private images in PDFs from background jobs ([#24980](#24980)) ([#25015](#25015)) ([3211ccf](3211ccf))
* replaced created by with owner in base_document ([#25059](#25059)) ([#25061](#25061)) ([bc5d09d](bc5d09d))
* restrict method for security critical endpoints ([#25105](#25105)) ([#25108](#25108)) ([44f4858](44f4858))
* ruff fixes ([c557ec6](c557ec6))
* show tooltip on edit table row (backport [#25040](#25040)) ([#25069](#25069)) ([2afbed7](2afbed7))
* spelling of "recording" in button (backport [#25025](#25025)) ([#25026](#25026)) ([6bf4f1c](6bf4f1c))
* support running QB union queries (backport [#24757](#24757)) ([#25016](#25016)) ([c092efa](c092efa))
* translate doctype in user-facing error message ([#25045](#25045)) ([3cd1eb2](3cd1eb2))
* validate fetch from ([#25116](#25116)) ([#25118](#25118)) ([624985d](624985d))
* wrap read_only functions correctly ([#25018](#25018)) ([#25020](#25020)) ([88a09be](88a09be))

### Features

* add push notification ([93ecd40](93ecd40))
* hook for print format template loader ([#25037](#25037)) ([#25074](#25074)) ([201e30f](201e30f))
* Impersonate a user (backport [#25050](#25050)) ([#25051](#25051)) ([813fb59](813fb59))
* socketio using authorization headers (backport [#24858](#24858)) ([#24966](#24966)) ([2045340](2045340))
* support array request type ([#25109](#25109)) ([#25112](#25112)) ([957d3eb](957d3eb))

### Performance Improvements

* avoid unnecessary json parsing ([#25065](#25065)) ([#25073](#25073)) ([1b814b3](1b814b3))
* don't process checks if there are none ([#25063](#25063)) ([#25071](#25071)) ([c3b0931](c3b0931))
* remove specific elements instead of re-rendering entire list ([#25078](#25078)) ([#25089](#25089)) ([37c9d3f](37c9d3f))
frappe-pr-bot pushed a commit that referenced this pull request Feb 28, 2024
@frappe-bot
chore(release): Bumped to Version 14.66.3
3b7c394 
## [14.66.3](v14.66.2...v14.66.3) (2024-02-28)

### Bug Fixes

* add context for row number label ([b9bb4e3](b9bb4e3))
* Avoid add "null" to cc in communication in timeline (backport [#25092](#25092)) ([#25095](#25095)) ([4bb84e7](4bb84e7))
* Cast to string to handle int PK ([#24988](#24988)) ([#24992](#24992)) ([4b7edff](4b7edff))
* Check perm for library file before cloning ([#25117](#25117)) ([#25119](#25119)) ([3b75844](3b75844))
* **ControlTime:** Don't set datepicker's date if field is read only ([#25038](#25038)) ([#25075](#25075)) ([b0d55a3](b0d55a3))
* disable internal columns like _comments from report column selec… ([#24998](#24998)) ([#24999](#24999)) ([78ff82b](78ff82b))
* Don't init site if already init-ed during truncate ([#25033](#25033)) ([#25035](#25035)) ([52bb028](52bb028))
* **File Uploader:** call 'upload_files' without passing event object ([#25034](#25034)) ([#25086](#25086)) ([40b725d](40b725d))
* german translation of No. ([ac841dc](ac841dc))
* grid row default values not using model (backport [#23701](#23701)) ([#24895](#24895)) ([119d7a6](119d7a6))
* invalid lru_cache usage ([#25046](#25046)) ([#25048](#25048)) ([f9d4874](f9d4874))
* replaced created by with owner in base_document (backport [#25059](#25059)) ([#25060](#25060)) ([ceb81a0](ceb81a0))
* set default user value only if enabled ([#25017](#25017)) ([deeb509](deeb509))
* show tooltip on edit table row (backport [#25040](#25040)) ([#25068](#25068)) ([4fb20ff](4fb20ff))
* translate doctype in user-facing error message (backport [#25043](#25043)) ([#25044](#25044)) ([d3054e4](d3054e4))
* wrap read_only functions correctly ([#25018](#25018)) ([#25019](#25019)) ([81af784](81af784))

### Performance Improvements

* avoid unnecessary json parsing ([#25065](#25065)) ([#25072](#25072)) ([ae469ef](ae469ef))
* remove specific elements instead of re-rendering entire list ([#25078](#25078)) ([#25088](#25088)) ([e6c1269](e6c1269))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush ankush approved these changes

@akhilnarang akhilnarang Awaiting requested review from akhilnarang

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @ankush
0