feat: socketio using authorization headers (backport #24858) #24966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier socketio only worked in browser where browser would send cookie (cause same domain) and hence socketio server used it to auth connection. This however is limited and doesn't allow simply creating socket connection from apps. Authorization headers on other hand are simple to implement. (cherry picked from commit 11ea7e4) # Conflicts: # realtime/utils.js
(cherry picked from commit a35e6b4)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
# [15.16.0](v15.15.0...v15.16.0) (2024-02-28) ### Bug Fixes * **a11y:** Improve desk accessibility (backport [#23319](#23319)) ([#25023](#25023)) ([48665e6](48665e6)) * add context for row number label ([235f921](235f921)) * add show_dashboard field on custom fields ([#24984](#24984)) ([#24986](#24986)) ([34bca99](34bca99)) * added important to bold class. ([718973e](718973e)) * allow negative numbers in grid search ([#24989](#24989)) ([#24991](#24991)) ([e778fe9](e778fe9)) * Avoid add "null" to cc in communication in timeline (backport [#25092](#25092)) ([#25096](#25096)) ([06c7a87](06c7a87)) * Cast to string to handle int PK ([#24988](#24988)) ([#24993](#24993)) ([de3042b](de3042b)) * Check perm for library file before cloning ([#25117](#25117)) ([#25120](#25120)) ([173ff30](173ff30)) * **ControlTime:** Don't set datepicker's date if field is read only ([#25038](#25038)) ([#25076](#25076)) ([3e33ae3](3e33ae3)) * Correct type hint ([#24990](#24990)) ([#24995](#24995)) ([3f956c1](3f956c1)) * disable internal columns like _comments from report column selec… ([#24998](#24998)) ([#25000](#25000)) ([76a32f2](76a32f2)) * Don't init site if already init-ed during truncate ([#25033](#25033)) ([#25036](#25036)) ([5ddbfb2](5ddbfb2)) * **File Uploader:** call 'upload_files' without passing event object ([#25034](#25034)) ([#25087](#25087)) ([ce5abfc](ce5abfc)) * force `[]` as default for child tables ([#24000](#24000)) ([fea1623](fea1623)) * **formatters:** Translate Select value in format_value ([#24951](#24951)) ([#25077](#25077)) ([ff9e199](ff9e199)) * german translation of No. ([4e491b2](4e491b2)) * grid row default values not using model (backport [#23701](#23701)) ([#24896](#24896)) ([ad05acb](ad05acb)) * **grid:** Add type attribute to buttons ([#25021](#25021)) ([#25022](#25022)) ([d440fef](d440fef)) * Guess currency from report row if available ([#25009](#25009)) ([#25010](#25010)) ([dfcee61](dfcee61)) * handle total rows in number card ([#25011](#25011)) ([#25012](#25012)) ([4882bfc](4882bfc)) * invalid lru_cache usage ([#25046](#25046)) ([#25047](#25047)) ([e275851](e275851)) * **module_map:** only include apps installed on the site - not everything on the bench (backport [#24688](#24688)) ([#25122](#25122)) ([79e7c57](79e7c57)) * Private images in PDFs from background jobs ([#24980](#24980)) ([#25015](#25015)) ([3211ccf](3211ccf)) * replaced created by with owner in base_document ([#25059](#25059)) ([#25061](#25061)) ([bc5d09d](bc5d09d)) * restrict method for security critical endpoints ([#25105](#25105)) ([#25108](#25108)) ([44f4858](44f4858)) * ruff fixes ([c557ec6](c557ec6)) * show tooltip on edit table row (backport [#25040](#25040)) ([#25069](#25069)) ([2afbed7](2afbed7)) * spelling of "recording" in button (backport [#25025](#25025)) ([#25026](#25026)) ([6bf4f1c](6bf4f1c)) * support running QB union queries (backport [#24757](#24757)) ([#25016](#25016)) ([c092efa](c092efa)) * translate doctype in user-facing error message ([#25045](#25045)) ([3cd1eb2](3cd1eb2)) * validate fetch from ([#25116](#25116)) ([#25118](#25118)) ([624985d](624985d)) * wrap read_only functions correctly ([#25018](#25018)) ([#25020](#25020)) ([88a09be](88a09be)) ### Features * add push notification ([93ecd40](93ecd40)) * hook for print format template loader ([#25037](#25037)) ([#25074](#25074)) ([201e30f](201e30f)) * Impersonate a user (backport [#25050](#25050)) ([#25051](#25051)) ([813fb59](813fb59)) * socketio using authorization headers (backport [#24858](#24858)) ([#24966](#24966)) ([2045340](2045340)) * support array request type ([#25109](#25109)) ([#25112](#25112)) ([957d3eb](957d3eb)) ### Performance Improvements * avoid unnecessary json parsing ([#25065](#25065)) ([#25073](#25073)) ([1b814b3](1b814b3)) * don't process checks if there are none ([#25063](#25063)) ([#25071](#25071)) ([c3b0931](c3b0931)) * remove specific elements instead of re-rendering entire list ([#25078](#25078)) ([#25089](#25089)) ([37c9d3f](37c9d3f))
|
🎉 This PR is included in version 15.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #24858 done by Mergify.
Cherry-pick of 11ea7e4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com