8000 fix: disable internal columns like _comments from report column selec… (backport #24998) by mergify[bot] · Pull Request #24999 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: disable internal columns like _comments from report column selec… (backport #24998) #24999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Feb 21, 2024

This is an automatic backport of pull request #24998 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

#24998)

* fix: disable internal columns like _comments from report column selection

* fix: only exclude comments from reportview

(cherry picked from commit ab485b2)
@mergify mergify bot requested a review from a team February 21, 2024 14:16
@mergify mergify bot requested review from ankush and removed request for a team February 21, 2024 14:16
@ankush ankush merged commit 78ff82b into version-14-hotfix Feb 21, 2024
@ankush ankush deleted the mergify/bp/version-14-hotfix/pr-24998 branch February 21, 2024 14:34
frappe-pr-bot pushed a commit that referenced this pull request Feb 28, 2024
## [14.66.3](v14.66.2...v14.66.3) (2024-02-28)

### Bug Fixes

* add context for row number label ([b9bb4e3](b9bb4e3))
* Avoid add "null" to cc in communication in timeline (backport [#25092](#25092)) ([#25095](#25095)) ([4bb84e7](4bb84e7))
* Cast to string to handle int PK ([#24988](#24988)) ([#24992](#24992)) ([4b7edff](4b7edff))
* Check perm for library file before cloning ([#25117](#25117)) ([#25119](#25119)) ([3b75844](3b75844))
* **ControlTime:** Don't set datepicker's date if field is read only ([#25038](#25038)) ([#25075](#25075)) ([b0d55a3](b0d55a3))
* disable internal columns like _comments from report column selec… ([#24998](#24998)) ([#24999](#24999)) ([78ff82b](78ff82b))
* Don't init site if already init-ed during truncate ([#25033](#25033)) ([#25035](#25035)) ([52bb028](52bb028))
* **File Uploader:** call 'upload_files' without passing event object ([#25034](#25034)) ([#25086](#25086)) ([40b725d](40b725d))
* german translation of No. ([ac841dc](ac841dc))
* grid row default values not using model (backport [#23701](#23701)) ([#24895](#24895)) ([119d7a6](119d7a6))
* invalid lru_cache usage ([#25046](#25046)) ([#25048](#25048)) ([f9d4874](f9d4874))
* replaced created by with owner in base_document (backport [#25059](#25059)) ([#25060](#25060)) ([ceb81a0](ceb81a0))
* set default user value only if enabled ([#25017](#25017)) ([deeb509](deeb509))
* show tooltip on edit table row (backport [#25040](#25040)) ([#25068](#25068)) ([4fb20ff](4fb20ff))
* translate doctype in user-facing error message (backport [#25043](#25043)) ([#25044](#25044)) ([d3054e4](d3054e4))
* wrap read_only functions correctly ([#25018](#25018)) ([#25019](#25019)) ([81af784](81af784))

### Performance Improvements

* avoid unnecessary json parsing ([#25065](#25065)) ([#25072](#25072)) ([ae469ef](ae469ef))
* remove specific elements instead of re-rendering entire list ([#25078](#25078)) ([#25088](#25088)) ([e6c1269](e6c1269))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.66.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0