8000 fix: restore missing `helpful` and `not_helpful` fields to help article doctype. by dj12djdjs · Pull Request #19309 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: restore missing helpful and not_helpful fields to help article doctype. #19309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2022
Merged

fix: restore missing helpful and not_helpful fields to help article doctype. #19309

merged 3 commits into from
Dec 16, 2022

Conversation

dj12djdjs
Copy link
Collaborator

closes #17192

@dj12djdjs dj12djdjs requested review from a team and shariquerik and removed request for a team December 16, 2022 01:54
@codecov
Copy link
codecov bot commented Dec 16, 2022 •
edited
Loading

Codecov Report

Merging #19309 (df85cea) into develop (8f8f506) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #19309      +/-   ##
===========================================
- Coverage    64.81%   64.78%   -0.03%     
===========================================
  Files          754      754              
  Lines        71006    70978      -28     
  Branches      6117     6117              
===========================================
- Hits         46019    45980      -39     
+ Misses       21554    21536      -18     
- Partials      3433     3462      +29
Flag Coverage Δ
server 68.53% <ø> (+0.06%) ⬆️
server-ui 31.63% <ø> (-0.07%) ⬇️
ui-tests 51.37% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush
Copy link
Member
ankush commented Dec 16, 2022

IDK why this doctype is still part of framework 🥴

Wiki app seems like better fit now.

@ankush ankush merged commit 64ec427 into frappe:develop Dec 16, 2022
@mergify mergify bot mentioned this pull request Dec 16, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 16, 2022
@dj12djdjs @mergify
fix: restore missing helpful and not_helpful fields to help artic…
56c83c2 
…le doctype. (#19309)

* fix: restore fields 'helpful' and 'not_helpfull' when removed via https://github.com/frappe/frappe/commit/02ddaa5ee7c101fb2ca40d6c0ac5982bcc88a982\#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46

* test: help article is helpful or not helpful

* chore: linter

(cherry picked from commit 64ec427)

# Conflicts:
#	frappe/website/doctype/help_article/help_article.json
#	frappe/website/doctype/help_article/test_help_article.py
@mergify mergify bot mentioned this pull request Dec 16, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 16, 2022
@dj12djdjs @mergify
fix: restore missing helpful and not_helpful fields to help artic…
8da6257 
…le doctype. (#19309)

* fix: restore fields 'helpful' and 'not_helpfull' when removed via https://github.com/frappe/frappe/commit/02ddaa5ee7c101fb2ca40d6c0ac5982bcc88a982\#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46

* test: help article is helpful or not helpful

* chore: linter

(cherry picked from commit 64ec427)
@dj12djdjs
Copy link
Collaborator Author

IDK why this doctype is still part of framework 🥴

Wiki app seems like better fit now.

To be honest I don't think Wiki app is stable. I started using it in my organization to document processes.
I've been finding a lot of issues. Most are very minor. (Haven't had the time to report them back to the wiki repo yet)

ankush pushed a commit that referenced this pull request Dec 19, 2022
@mergify @dj12djdjs
fix: restore missing helpful and not_helpful fields to help artic…
3950865 
…le doctype. (#19309) (#19316)

* fix: restore fields 'helpful' and 'not_helpfull' when removed via https://github.com/frappe/frappe/commit/02ddaa5ee7c101fb2ca40d6c0ac5982bcc88a982\#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46

* test: help article is helpful or not helpful

* chore: linter

(cherry picked from commit 64ec427)

Co-authored-by: Devin Slauenwhite <devin.slauenwhite@gmail.com>
ankush added a commit that referenced this pull request Dec 19, 2022
@mergify @dj12djdjs @ankush
fix: restore missing helpful and not_helpful fields to help artic…
90c4023 
…le doctype. (backport #19309) (#19315)

* fix: restore missing `helpful` and `not_helpful` fields to help article doctype. (#19309)

* fix: restore fields 'helpful' and 'not_helpfull' when removed via https://github.com/frappe/frappe/commit/02ddaa5ee7c101fb2ca40d6c0ac5982bcc88a982\#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46

* test: help article is helpful or not helpful

* chore: linter

(cherry picked from commit 64ec427)

# Conflicts:
#	frappe/website/doctype/help_article/help_article.json
#	frappe/website/doctype/help_article/test_help_article.py

* chore: conflicts

Co-authored-by: Devin Slauenwhite <devin.slauenwhite@gmail.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Dec 20, 2022
@frappe-bot
chore(release): Bumped to Version 13.46.1
9f46c26 
## [13.46.1](v13.46.0...v13.46.1) (2022-12-20)

### Bug Fixes

* allow zero page length in `get_list` to return complete list ([#19322](#19322)) ([#19340](#19340)) ([0dfa23d](0dfa23d))
* datepicker not working for arabic language ([7570256](7570256))
* dont share with self for standard users (backport [#19327](#19327)) ([#19337](#19337)) ([7d93bf0](7d93bf0))
* duplicate unique indexes (backport [#19291](#19291)) ([#19296](#19296)) ([b6e58a9](b6e58a9))
* move filelock import inside function ([e642684](e642684))
* restore missing `helpful` and `not_helpful` fields to help article doctype. (backport [#19309](#19309)) ([#19315](#19315)) ([90c4023](90c4023)), closes [#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46](https://github.com/frappe/frappe/issues/diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46)
* untranslated link fields in list view ([#19155](
8000
#19155)) ([57b109e](57b109e))
* use stricter regex for `sanitize_searchfield` ([#19302](#19302)) ([1fbca36](1fbca36))
* **UX:** Redirect after submitting webform ([#19318](#19318)) ([d25a26b](d25a26b))

### Performance Improvements

* reuse `_doc_before_save` in `doc.get_latest` (backport [#19326](#19326)) ([#19345](#19345)) ([757b042](757b042))
frappe-pr-bot pushed a commit that referenced this pull request Dec 20, 2022
@frappe-bot
chore(release): Bumped to Version 14.20.0
c7922a1 
# [14.20.0](v14.19.1...v14.20.0) (2022-12-20)

### Bug Fixes

* allow zero page length in `get_list` to return complete list ([#19322](#19322)) ([#19341](#19341)) ([715aaa6](715aaa6))
* better check of whether doctype is child table ([#19329](#19329)) ([#19343](#19343)) ([0c0d1ef](0c0d1ef))
* datepicker not working for arabic language (backport [#19358](#19358)) ([#19361](#19361)) ([8d791cc](8d791cc))
* db ssl connection ([#19308](#19308)) ([#19339](#19339)) ([3bf65be](3bf65be))
* dont share with self for standard users (backport [#19327](#19327)) ([#19338](#19338)) ([a3be135](a3be135))
* duplicate unique indexes (backport [#19291](#19291)) ([#19297](#19297)) ([bc92e1c](bc92e1c))
* handle `HTML` code field's `has_content` ([9bc679e](9bc679e))
* if grid custom button is not set grid has some extra space on top ([4f19f68](4f19f68))
* in web form if print format is empty getting error ([f8e227c](f8e227c))
* move filelock import to function ([ee9b1aa](ee9b1aa))
* postgres query ([#19357](#19357)) ([#19359](#19359)) ([12ecae2](12ecae2))
* **postgres:** psql with remote databases (backport [#19362](#19362)) ([#19366](#19366)) ([60c853d](60c
8000
853d))
* restore missing `helpful` and `not_helpful` fields to help article doctype. ([#19309](#19309)) ([#19316](#19316)) ([3950865](3950865)), closes [#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46](https://github.com/frappe/frappe/issues/diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46)
* sort prepared report filters ([#19267](#19267)) ([b3e16b8](b3e16b8))
* **trim-database:** Dont act on non-frappe tables (backport [#19292](#19292)) ([#19298](#19298)) ([34b2b24](34b2b24))
* use stricter regex for `sanitize_searchfield` (backport [#19277](#19277)) ([#19303](#19303)) ([4e870b3](4e870b3))
* **workflow:** Remove docstatus field from get_workflow_state_count ([#19332](#19332)) ([#19344](#19344)) ([34e8ecb](34e8ecb))

### Features

* add parameters language and letter_head to `download_pdf` ([99631d2](99631d2))
* fields for attaching (html) meta tags in web form (backport [#19306](#19306)) ([#19307](#19307)) ([6b0e585](6b0e585))

### Performance Improvements

* reuse `_doc_before_save` in `doc.get_latest` (backport [#19326](#19326)) ([#19346](#19346)) ([ff3de82](ff3de82))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shariquerik shariquerik Awaiting requested review from shariquerik

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback for KB articles is broken
2 participants
@dj12djdjs @ankush
0