-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: use stricter regex for sanitize_searchfield
#19277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ankush
merged 3 commits into
frappe:develop
from
resilient-tech:refactor-sanitize_searchfield
Dec 15, 2022
Merged
fix: use stricter regex for sanitize_searchfield
#19277
ankush
merged 3 commits into
frappe:develop
from
resilient-tech:refactor-sanitize_searchfield
Dec 15, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7052340
to
4d9be26
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #19277 +/- ##
===========================================
+ Coverage 64.50% 64.53% +0.03%
===========================================
Files 754 754
Lines 70352 70467 +115
Branches 6117 6117
===========================================
+ Hits 45378 45479 +101
- Misses 21437 21451 +14
Partials 3537 3537
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
approved these changes
Dec 15, 2022
This was referenced Dec 15, 2022
ankush
pushed a commit
that referenced
this pull request
Dec 15, 2022
…19303) * fix: use stricter regex for `sanitize_searchfield` (cherry picked from commit 4d9be26) * test: test case for `sanitize_searchfield` (cherry picked from commit 3e824a9) * fix: added a case with backticks (cherry picked from commit 9a8dbc4) Co-authored-by: Daizy Modi <modidaizy5217@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
# [14.20.0](v14.19.1...v14.20.0) (2022-12-20) ### Bug Fixes * allow zero page length in `get_list` to return complete list ([#19322](#19322)) ([#19341](#19341)) ([715aaa6](715aaa6)) * better check of whether doctype is child table ([#19329](#19329)) ([#19343](#19343)) ([0c0d1ef](0c0d1ef)) * datepicker not working for arabic language (backport [#19358](#19358)) ([#19361](#19361)) ([8d791cc](8d791cc)) * db ssl connection ([#19308](#19308)) ([#19339](#19339)) ([3bf65be](3bf65be)) * dont share with self for standard users (backport [#19327](#19327)) ([#19338](#19338)) ([a3be135](a3be135)) * duplicate unique indexes (backport [#19291](#19291)) ([#19297](#19297)) ([bc92e1c](bc92e1c)) * handle `HTML` code field's `has_content` ([9bc679e](9bc679e)) * if grid custom button is not set grid has some extra space on top ([4f19f68](4f19f68)) * in web form if print format is empty getting error ([f8e227c](f8e227c)) * move filelock import to function ([ee9b1aa](ee9b1aa)) * postgres query ([#19357](#19357)) ([#19359](#19359)) ([12ecae2](12ecae2)) * **postgres:** psql with remote databases (backport [#19362](#19362)) ([#19366](#19366)) ([60c853d](60c853d)) * restore missing `helpful` and `not_helpful` fields to help article doctype. ([#19309](#19309)) ([#19316](#19316)) ([3950865](3950865)), closes [#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46](https://github.com/frappe/frappe/issues/diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46) * sort prepared report filters ([#19267](#19267)) ([b3e16b8](b3e16b8)) * **trim-database:** Dont act on non-frappe tables (backport [#19292](#19292)) ([#19298](#19298)) ([34b2b24](34b2b24)) * use stricter regex for `sanitize_searchfield` (backport [#19277](#19277)) ([#19303](#19303)) ([4e870b3](4e870b3)) * **workflow:** Remove docstatus field from get_workflow_state_count ([#19332](#19332)) ([#19344](#19344)) ([34e8ecb](34e8ecb)) ### Features * add parameters language and letter_head to `download_pdf` ([99631d2](99631d2)) * fields for attaching (html) meta tags in web form (backport [#19306](#19306)) ([#19307](#19307)) ([6b0e585](6b0e585)) ### Performance Improvements * reuse `_doc_be 7E3A fore_save` in `doc.get_latest` (backport [#19326](#19326)) ([#19346](#19346)) ([ff3de82](ff3de82))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.