8000 feat: fields for attaching (html) meta tags in web form by NagariaHussain · Pull Request #19306 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: fields for attaching (html) meta tags in web form #19306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 15, 2022

Conversation

NagariaHussain
Copy link
Member

Added a meta section in Web Form doctype, identical to the one present in Web Page doctype:

Meta Section in Web from screen shot

  • add title, description and image fields
  • use form title as meta title if meta_title not provided
  • use form introduction (first 140 chars) as meta descriptions if meta_description is not set
  • add tests

no-docs

@codecov
Copy link
codecov bot commented Dec 15, 2022

Codecov Report

Merging #19306 (3f6ceb8) into develop (8107781) will decrease coverage by 0.02%.
The diff coverage is 81.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19306      +/-   ##
===========================================
- Coverage    64.71%   64.68%   -0.03%     
===========================================
  Files          754      754              
  Lines        70861    70978     +117     
  Branches      6117     6117              
===========================================
+ Hits         45855    45912      +57     
- Misses       21543    21591      +48     
- Partials      3463     3475      +12     
Flag Coverage Δ
server 68.44% <100.00%> (-0.02%) ⬇️
server-ui 31.66% <83.33%> (+<0.01%) ⬆️
ui-tests 51.27% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@shariquerik shariquerik merged commit 8f8f506 into develop Dec 15, 2022
@shariquerik shariquerik deleted the feat-meta-fields-web-form branch December 15, 2022 15:37
@shariquerik shariquerik added backport version-14-hotfix backport to version 14 and removed fix-frappe-linter labels Dec 15, 2022
mergify bot pushed a commit that referenced this pull request Dec 15, 2022
frappe-pr-bot pushed a commit that referenced this pull request Dec 20, 2022
# [14.20.0](v14.19.1...v14.20.0) (2022-12-20)

### Bug Fixes

* allow zero page length in `get_list` to return complete list ([#19322](#19322)) ([#19341](#19341)) ([715aaa6](715aaa6))
* better check of whether doctype is child table ([#19329](#19329)) ([#19343](#19343)) ([0c0d1ef](0c0d1ef))
* datepicker not working for arabic language (backport [#19358](#19358)) ([#19361](#19361)) ([8d791cc](8d791cc))
* db ssl connection ([#19308](#19308)) ([#19339](#19339)) ([3bf65be](3bf65be))
* dont share with self for standard users (backport [#19327](#19327)) ([#19338](#19338)) ([a3be135](a3be135))
* duplicate unique indexes (backport [#19291](#19291)) ([#19297](#19297)) ([bc92e1c](bc92e1c))
* handle `HTML` code field's `has_content` ([9bc679e](9bc679e))
* if grid custom button is not set grid has some extra space on top ([4f19f68](4f19f68))
* in web form if print format is empty getting error ([f8e227c](f8e227c))
* move filelock import to function ([ee9b1aa](ee9b1aa))
* postgres query ([#19357](#19357)) ([#19359](#19359)) ([12ecae2](12ecae2))
* **postgres:** psql with remote databases (backport [#19362](#19362)) ([#19366](#19366)) ([60c853d](60c853d))
* restore missing `helpful` and `not_helpful` fields to help article doctype. ([#19309](#19309)) ([#19316](#19316)) ([3950865](3950865)), closes [#diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46](https://github.com/frappe/frappe/issues/diff-3e0e1befb66af4c2ab84c6fe0e996dc602d906817f0b00b6239120af9da9be46)
* sort prepared report filters ([#19267](#19267)) ([b3e16b8](b3e16b8))
* **trim-database:** Dont act on non-frappe tables (backport [#19292](#19292)) ([#19298](#19298)) ([34b2b24](34b2b24))
* use stricter regex for `sanitize_searchfield` (backport [#19277](#19277)) ([#19303](#19303)) ([4e870b3](4e870b3))
* **workflow:** Remove docstatus field from get_workflow_state_count ([#19332](#19332)) ([#19344](#19344)) ([34e8ecb](34e8ecb))

### Features

* add parameters la
85D0
nguage and letter_head to `download_pdf` ([99631d2](99631d2))
* fields for attaching (html) meta tags in web form (backport [#19306](#19306)) ([#19307](#19307)) ([6b0e585](6b0e585))

### Performance Improvements

* reuse `_doc_before_save` in `doc.get_latest` (backport [#19326](#19326)) ([#19346](#19346)) ([ff3de82](ff3de82))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0