8000 fix(limit-orders): fix orders table filter by alfetopito · Pull Request #5923 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(limit-orders): fix orders table filter #5923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

fix(limit-orders): fix orders table filter #5923

wants to merge 4 commits into from

Conversation

alfetopito
Copy link
Collaborator
@alfetopito alfetopito commented Jul 3, 2025 •
edited by coderabbitai bot
Loading

Summary

Fix limit orders table filter

To Test

  1. Connect wallet with limit orders
  2. Search on the table for bla
  • There should be no results, unless you traded a token that contains bla in the symbol
  1. Search for a symbol for which you have orders, like weth
  • There should be orders that have WETH
  1. Add a space before/after weth
  • There should be orders that have WETH

Summary by CodeRabbit

  • Bug Fixes
    • Improved search functionality in the orders table by updating how search terms are processed for address matching. Search terms now retain all characters except leading and trailing whitespace, enhancing flexibility in search queries.

shoom3301 and others added 4 commits July 2, 2025 20:59
@shoom3301
fix(trade-quote): do not update quote when trade is not ready (#5914)
e948ae8 
* fix(quote): update quote when expired

* fix(quote): update quote when expired

* fix(quote): stop polling when trade is not ready

* fix: do not update quote when wallet is not connected
@cowdan
feat: use eip155 chain names adding chain parameter to walllet (#5916)
318c1bc 
* feat: use `eip155` chain names adding chain parameter to walllet

* fix: missing property
@shoom3301
fix(limit-orders): udpate quote when back from confirm (#5922)
f3d721e
@alfetopito
fix(limit-orders): fix orders table filter
db77e6f
@alfetopito alfetopito self-assigned this Jul 3, 2025
@vercel Vercel
Copy link
vercel bot commented Jul 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos 🛑 Canceled (Inspect) Jul 3, 2025 10:15am
cowfi ✅ Ready (Inspect) Visit Preview Jul 3, 2025 10:15am
explorer-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2025 10:15am
sdk-tools 🛑 Canceled (Inspect) Jul 3, 2025 10:15am
swap-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2025 10:15am
widget-configurator ✅ Ready (Inspect) Visit Preview Jul 3, 2025 10:15am

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 3, 2025 •
edited
Loading

Walkthrough

The search term cleaning logic in the order filtering process has been updated. Instead of removing all non-hexadecimal characters, the search term is now only trimmed of whitespace before being used for address matching.

Changes

File(s) Change Summary
apps/cowswap-frontend/src/modules/ordersTable/containers/OrdersTableWidget/index.tsx Updated search term cleaning from strict character removal to simple whitespace trimming in address matching logic.

Suggested labels

RELEASE

Suggested reviewers

  • cowdan
  • elena-zh

Poem

A search for an address, once tightly constrained,
Now welcomes all letters, not just hex remained.
With whitespace now trimmed, but the rest left to be,
The filter grows friendly, as open as me!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
(node:16385) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
(Use node --trace-deprecation ... to show where the warning was created)
[2/4] Fetching packages...
error nx@21.0.3: The engine "node" is incompatible with this module. Expected version "^20.19.0 || ^22.12.0". Got "24.3.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f3d721e and db77e6f.

📒 Files selected for processing (1)
  • apps/cowswap-frontend/src/modules/ordersTable/containers/OrdersTableWidget/index.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Setup
  • GitHub Check: Cypress
🔇 Additional comments (1)
apps/cowswap-frontend/src/modules/ordersTable/containers/OrdersTableWidget/index.tsx (1)

328-328: LGTM! This fix correctly addresses the filtering issues.

The change from using a regex to remove non-hexadecimal characters to simply trimming whitespace is the right approach. The previous regex replace(/[^0-9a-fx]/g, '') was too aggressive and would corrupt token symbol searches (e.g., "WETH" would become "ef", "USDC" would become "dc"). Using trim() preserves the actual search content while properly handling leading/trailing spaces, which aligns perfectly with the PR objectives.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alfetopito
Copy link
Collaborator Author

@coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 3, 2025
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@vercel vercel bot temporarily deployed to Preview – cosmos July 3, 2025 10:10 Inactive
@vercel vercel bot temporarily deployed to Preview – sdk-tools July 3, 2025 10:10 Inactive
@alfetopito alfetopito requested review from a team July 3, 2025 10:14
Base automatically changed from release/2025-07-02 to main July 3, 2025 10:43
@alfetopito
Copy link
Collaborator Author

Didn't make the cut for the release, will point to develop instead

@alfetopito alfetopito changed the base branch from main to develop July 3, 2025 12:34
@alfetopito alfetopito marked this pull request as draft July 3, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alfetopito @shoom3301 @elena-zh @cowdan
0