fix(trade-quote): do not update quote when trade is not 8000 ready #5914
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change introduces a new hook, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TradeWidgetForm
participant useIsQuoteUpdatePossible
participant TradeQuoteUpdater
participant useTradeQuotePolling
participant QuotePolingProgress
User->>TradeWidgetForm: Interacts with trade form
TradeWidgetForm->>useIsQuoteUpdatePossible: Check if quote update is possible
useIsQuoteUpdatePossible-->>TradeWidgetForm: Returns boolean
TradeWidgetForm->>TradeQuoteUpdater: Passes isQuoteUpdatePossible
TradeQuoteUpdater->>useTradeQuotePolling: Starts polling if allowed
useTradeQuotePolling-->>TradeQuoteUpdater: Polls or skips based on flag
TradeWidgetForm->>QuotePolingProgress: Renders only if update is possible
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
a73add8 to
3b4752b
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
apps/cowswap-frontend/src/modules/trade/hooks/useIsQuoteUpdatePossible.ts
Outdated
Show resolved
Hide resolved
|
Shame on me, I've tested only with the connected state! |
|
Thank you guys! Shame on me as well... |
Summary
Fixes #5894
To Test
See #5894
Summary by CodeRabbit
New Features
Bug Fixes
Tests