8000 fix(limit-orders): udpate quote when back from confirm by shoom3301 · Pull Request #5922 · cowprotocol/cowswap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(limit-orders): udpate quote when back from confirm #5922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

fix(limit-orders): udpate quote when back from confirm #5922

merged 1 commit into from
Jul 3, 2025

Conversation

shoom3301
Copy link
Collaborator
@shoom3301 shoom3301 commented Jul 3, 2025 •
edited by coderabbitai bot
Loading

Summary

Fixes https://www.notion.so/cownation/Limit-orders-form-hangs-in-the-calculating-price-state-after-order-placement-2248da5f04ca808fb7cee1f32f0ee2d3

Logic of quote refreshing when you came back from confirm screen was changed (useTradeQuotePolling):

image

But it was'nt consider limit orders widget correctly. In limit orders TradeQuoteUpdater was conditionally displaying, so prevIsConfirmOpen wasn't defined properly.

To Test

See https://www.notion.so/cownation/Limit-orders-form-hangs-in-the-calculating-price-state-after-order-placement-2248da5f04ca808fb7cee1f32f0ee2d3

Summary by CodeRabbit

  • Refactor
    • Improved the logic for updating trade quotes by always rendering the quote updater component and controlling its behavior through updated properties, resulting in more consistent component behavior.

@shoom3301 shoom3301 added the RELEASE Included in the release that is being closed label Jul 3, 2025
@vercel Vercel
Copy link
vercel bot commented Jul 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ❌ Failed (Inspect) Jul 3, 2025 9:25am
cowfi ✅ Ready (Inspect) Visit Preview Jul 3, 2025 9:25am
explorer-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2025 9:25am
sdk-tools ✅ Ready (Inspect) Visit Preview Jul 3, 2025 9:25am
swap-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2025 9:25am
widget-configurator ✅ Ready (Inspect) Visit Preview Jul 3, 2025 9:25am

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 3, 2025 •
edited
Loading

Walkthrough

The update changes the rendering logic for the TradeQuoteUpdater component in the trade widget. Instead of conditionally rendering the component, it is now always rendered, and the control over its behavior is managed through a prop (isQuoteUpdatePossible) that incorporates the previous condition.

Changes

File(s) Change Summary
apps/cowswap-frontend/src/modules/trade/containers/TradeWidget/TradeWidgetUpdaters.tsx Moved conditional logic from component rendering to a prop; TradeQuoteUpdater is always rendered, with its behavior controlled via isQuoteUpdatePossible.

Sequence Diagram(s)

sequenceDiagram
    participant TradeWidgetUpdaters
    participant TradeQuoteUpdater

    TradeWidgetUpdaters->>TradeQuoteUpdater: Render with isQuoteUpdatePossible = prevValue && !disableQuotePolling
    Note right of TradeQuoteUpdater: Controls update behavior internally based on prop
Loading

Possibly related PRs

  • cowprotocol/cowswap#5914: Introduces and propagates the isQuoteUpdatePossible flag to control quote updating, directly related to the logic refactor in this PR.

Suggested reviewers

  • shoom3301
  • elena-zh

Poem

A widget once checked before showing its face,
Now always appears, just in case.
Its powers controlled by a prop so precise,
Logic moved in a hop, oh how nice!
The rabbit approves with a happy cheer,
For cleaner code is always dear.
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
(node:24817) [DEP0169] DeprecationWarning: url.parse() behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for url.parse() vulnerabilities.
(Use node --trace-deprecation ... to show where the warning was created)
[2/4] Fetching packages...
error nx@21.0.3: The engine "node" is incompatible with this module. Expected version "^20.19.0 || ^22.12.0". Got "24.3.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 318c1bc and b4aedec.

📒 Files selected for processing (1)
  • apps/cowswap-frontend/src/modules/trade/containers/TradeWidget/TradeWidgetUpdaters.tsx (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: shoom3301
PR: cowprotocol/cowswap#5859
File: apps/cowswap-frontend/src/modules/tradeQuote/hooks/useTradeQuotePolling.ts:76-82
Timestamp: 2025-06-23T07:03:50.760Z
Learning: In the useTradeQuotePolling hook, there are two useLayoutEffect hooks that work
8000
 together: one resets the counter to 0 when the confirmation modal closes, and another automatically triggers pollQuote(false, true) whenever the counter reaches 0. This creates an intentional chain reaction for immediate quote updates.
apps/cowswap-frontend/src/modules/trade/containers/TradeWidget/TradeWidgetUpdaters.tsx (2) 
Learnt from: shoom3301
PR: cowprotocol/cowswap#5859
File: apps/cowswap-frontend/src/modules/tradeQuote/hooks/useTradeQuotePolling.ts:76-82
Timestamp: 2025-06-23T07:03:50.760Z
Learning: In the useTradeQuotePolling hook, there are two useLayoutEffect hooks that work together: one resets the counter to 0 when the confirmation modal closes, and another automatically triggers pollQuote(false, true) whenever the counter reaches 0. This creates an intentional chain reaction for immediate quote updates.

Learnt from: shoom3301
PR: cowprotocol/cowswap#5443
File: apps/cowswap-frontend/src/modules/swap/containers/ConfirmSwapModalSetup/index.tsx:71-71
Timestamp: 2025-02-20T15:59:33.749Z
Learning: The swap module in apps/cowswap-frontend/src/modules/swap/ is marked for deletion in PR #5444 as part of the swap widget unification effort.
🧬 Code Graph Analysis (1)
apps/cowswap-frontend/src/modules/trade/containers/TradeWidget/TradeWidgetUpdaters.tsx (1)
apps/cowswap-frontend/src/modules/tradeQuote/updaters/TradeQuoteUpdater/index.tsx (1)
  • TradeQuoteUpdater (12-20)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Cypress
🔇 Additional comments (1)
apps/cowswap-frontend/src/modules/trade/containers/TradeWidget/TradeWidgetUpdaters.tsx (1)

49-52: Excellent fix for the conditional rendering issue!

This change correctly addresses the root cause of the limit orders form hanging in "calculating price" state. By always rendering the TradeQuoteUpdater component instead of conditionally rendering it, you ensure that the hooks inside it (particularly useTradeQuotePolling) remain mounted and can maintain their internal state properly.

The approach of moving the conditional logic from component rendering to prop value (isQuoteUpdatePossible && !disableQuotePolling) maintains the same functional behavior while fixing the issue where prevIsConfirmOpen state was improperly defined due to component unmounting/remounting.

This follows React best practices by avoiding conditional rendering of components that contain hooks with important state.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shoom3301 shoom3301 self-assigned this Jul 3, 2025
@shoom3301 shoom3301 marked this pull request as ready for review July 3, 2025 09:18
@shoom3301 shoom3301 requested review from a team July 3, 2025 09:20
@alfetopito
Copy link
Collaborator

@coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 3, 2025
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

alfetopito
alfetopito approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator
@alfetopito a 8000 lfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described

elena-zh
elena-zh approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor
@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shoom3301 shoom3301 merged commit f3d721e into release/2025-07-02 Jul 3, 2025
13 of 15 checks passed
@shoom3301 shoom3301 deleted the fix/limit-quote-loading branch July 3, 2025 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@elena-zh elena-zh elena-zh approved these changes

@cowdan cowdan cowdan approved these changes

Assignees

@shoom3301 shoom3301

Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shoom3301 @alfetopito @elena-zh @cowdan
0