8000 fix: Added build flag for secp256k1eth curve by bermuell · Pull Request #4784 · cometbft/cometbft · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Added build flag for secp256k1eth curve #4784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 9, 2025
Merged

fix: Added build flag for secp256k1eth curve #4784

merged 11 commits into from
Jan 9, 2025

Conversation

bermuell
Copy link
Contributor
@bermuell bermuell commented Jan 7, 2025 •
edited
Loading

closes #4725

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@bermuell bermuell force-pushed the bernd/4725-secp256k1eth-buildflag branch from 19469c8 to c3933ad Compare January 7, 2025 16:44
@bermuell bermuell changed the title feat: Added build flag for secp256k1eth curve fix: Added build flag for secp256k1eth curve Jan 8, 2025
@bermuell bermuell force-pushed the bernd/4725-secp256k1eth-buildflag branch from c3933ad to 64dfb21 Compare January 8, 2025 07:46
@bermuell bermuell requested a review from sergio-mena January 8, 2025 07:47
@bermuell bermuell marked this pull request as ready for review January 8, 2025 09:20
@bermuell bermuell requested review from a team as code owners January 8, 2025 09:20
@bermuell bermuell requested a review from melekes January 8, 2025 09:42
bermuell
bermuell commented Jan 8, 2025
View reviewed changes
sergio-mena
sergio-mena reviewed Jan 8, 2025
View reviewed changes
sergio-mena
sergio-mena reviewed Jan 8, 2025
View reviewed changes
sergio-mena
sergio-mena reviewed Jan 8, 2025
View reviewed changes
sergio-mena
sergio-mena reviewed Jan 8, 2025
View reviewed changes
sergio-mena
sergio-mena reviewed Jan 8, 2025
View reviewed changes
sergio-mena
sergio-mena reviewed Jan 8, 2025
View reviewed changes
sergio-mena
sergio-mena reviewed Jan 8, 2025
View reviewed changes
sergio-mena
sergio-mena reviewed Jan 8, 2025
View reviewed changes
@bermuell bermuell requested a review from sergio-mena January 9, 2025 09:01
melekes
melekes reviewed Jan 9, 2025
View reviewed changes
sergio-mena
sergio-mena approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor
@sergio-mena sergio-mena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! 🚀

@sergio-mena sergio-mena added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 0d4d40f Jan 9, 2025
36 checks passed
@sergio-mena sergio-mena deleted the bernd/4725-secp256k1eth-buildflag branch January 9, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

@sergio-mena sergio-mena sergio-mena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cmd): Add build flag for secp256k1eth
3 participants
@bermuell @melekes @sergio-mena
0