8000 Allow png mask without double extension by MotivaCG · Pull Request #3284 · colmap/colmap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow png mask without double extension #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow png mask without double extension #3284

wants to merge 2 commits into from

Conversation

MotivaCG
Copy link

By default, COLMAP searches for mask files by appending ".png" to the image filename. However, this can lead to unexpected behavior when the original image already has a ".png" extension. For example, an image named "image0001.png" would require a mask named "image0001.png.png", which is unintuitive and may cause compatibility issues with other tools that rely on masks, potentially requiring duplicate files.

This patch retains the current behavior as the primary lookup method but introduces a fallback: if the image already has a .png extension and the initial mask file is not found, it also checks for a mask with the exact same name. Since COLMAP allows specifying separate directories for images and masks, having identical filenames is not problematic.

Thank you for considering this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MotivaCG
0