8000 [maint] fix circleCI branch naming in trigger action by psobolewskiPhD · Pull Request #739 · napari/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[maint] fix circleCI branch naming in trigger action #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

[maint] fix circleCI branch naming in trigger action #739

merged 1 commit into from
Jun 20, 2025

Conversation

psobolewskiPhD
Copy link
Member

References and relevant issues

CircleCI trigger is still failing: https://github.com/napari/docs/actions/runs/15769048532

Description

CircleCI docs for PRs from forks:
https://support.circleci.com/hc/en-us/articles/360049841151-Trigger-Pipelines-on-Forked-Pull-Requests-with-CircleCI-API-v2
the branch name should be of format:
"pull/${PR_BRANCH_NUM}/head"

@psobolewskiPhD psobolewskiPhD added the maintenance CI, dependencies, and other maintenance label Jun 20, 2025
This was referenced Jun 20, 2025
Merged
Merged
aganders3
aganders3 approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor
@aganders3 aganders3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough to try! Maybe we can remove the output I added for pr_number and use this method for the GitHub actions build as well?

@aganders3
Copy link
Contributor

Also I think I used the "merge" commit but this looks like it's using the "head" which may be a better idea.

TimMonko
TimMonko approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor
@TimMonko TimMonko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This at least looks consistent with the docs you linked. hope it works

@psobolewskiPhD psobolewskiPhD added this to the 0.6.2 milestone Jun 20, 2025
@psobolewskiPhD
Copy link
Member Author

gonna merge since it can't break things more!

@psobolewskiPhD psobolewskiPhD merged commit f618617 into napari:main Jun 20, 2025
10 checks passed
@psobolewskiPhD
Copy link
Member Author

It worked!
https://github.com/napari/docs/actions/runs/15769713981

@psobolewskiPhD psobolewskiPhD added the bug Something isn't working label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aganders3 aganders3 aganders3 approved these changes

@TimMonko TimMonko TimMonko approved these changes

Assignees

@psobolewskiPhD psobolewskiPhD

Labels
bug Something isn't working maintenance CI, dependencies, and other maintenance
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@psobolewskiPhD @aganders3 @TimMonko
0