8000 Use darker blue for community meetings in napari calendar by TimMonko · Pull Request #736 · napari/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use darker blue for community meetings in napari calendar #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2025
Merged

Use darker blue for community meetings in napari calendar #736

merged 4 commits into from
Jun 20, 2025

Conversation

TimMonko
Copy link
Contributor
@TimMonko TimMonko commented Jun 19, 2025 •
edited
Loading

References and relevant issues

Inspired by a comment from Draga in a core-dev thread on Zulip:

I think it's totally fine to have non-community-meeting events in the calendar, I'd love to see it. Would be nice to give the community meetings their own colour though, maybe? Not sure if that's possible on the website. Just wanna make sure they're easy to spot

Description

Based on Ashley's suggestion (napari/napari-sphinx-theme#189 (comment)) and coinciding with my own searches. This was the alternate strategy I found to what I proposed in #189, but I was going to overly complicate things in comparison...

Overrides calendar color with --napari-primary-blue if the events contain "community" or "working" in the title, since these are consistent names we use. Therefore, these events will be emphasized compared to the (current) lighter color that any other event will have.

image

@TimMonko @aganders3
use primary blue for community and working group meetings
525e7fd 
Co-authored-by: Ashley Anderson <aganders3@gmail.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 19, 2025
@TimMonko TimMonko requested review from jni, aganders3 and melissawm June 19, 2025 21:04
@TimMonko TimMonko added this to the 0.6.2 milestone Jun 19, 2025
@TimMonko
Copy link
Contributor Author

@napari-bot make html

@TimMonko
Copy link
Contributor Author

Ok, so even if I copy exactly what @aganders3 did, locally or on CI, I don't even see the calendar events anymore.
Not sure what's different, I literally copy and pasted? Locally I am getting some errors, so not sure what's wrong.

@aganders3
Copy link
Contributor

Locally you need a Google api key. I don't think it's technically private as it ends up in the client side JavaScript but I'll dm it to you on Zulip with build instructions.

CI should work though so that's odd...

@psobolewskiPhD
Copy link
Member

@napari-bot make html

@psobolewskiPhD
Copy link
Member
psobolewskiPhD commented Jun 19, 2025 •
edited
Loading

CircleCI definitely doesn't use the google key, but the artifact build should, it's in the action anyways 🤔

Edit: and the triggered builds are not working 😭

@aganders3 aganders3 mentioned this pull request Jun 20, 2025
Merged
psobolewskiPhD pushed a commit that referenced this pull request Jun 20, 2025
@aganders3
Test passing PR number instead of ref on triggered build (#738)
8bb1e3f 
# References and relevant issues
See #736 (comment)

# Description
Testing a hunch that @actions/checkout can't find the ref because it's
looking for it in _this_ repo, but it belongs to the fork the PR is
coming from.
@psobolewskiPhD
Copy link
Member

@napari-bot make html

@psobolewskiPhD
Copy link
Member
psobolewskiPhD commented Jun 20, 2025 •
edited
Loading

Thanks to Ashley the artifact build is fixed (https://github.com/napari/docs/actions/runs/15769048532/job/44450635835#step:8:110) but circle is still 400.
I think it's the same sort of issue, getting the pr number/branch passed correctly.
Edit: I think I have the fix: #739 (based on the circle docs anyways)

@psobolewskiPhD
Copy link
Member

@napari-bot make html

@psobolewskiPhD
Copy link
Member

woohoo! it looks like both jobs are triggering correctly!
https://github.com/napari/docs/actions/runs/15769713981

@TimMonko
Copy link
Contributor Author

from building locally:
image

psobolewskiPhD
psobolewskiPhD approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member
@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

aganders3
aganders3 approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor
@aganders3 aganders3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too - it looks nice!

@melissawm melissawm merged commit 775e262 into napari:main Jun 20, 2025
10 checks passed
@melissawm
Copy link
Member

I'll push the button!

@psobolewskiPhD psobolewskiPhD added the enhancement New feature or request label Jun 20, 2025
@TimMonko TimMonko added the highlight highlight this PR in release notes label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aganders3 aganders3 aganders3 approved these changes

@psobolewskiPhD psobolewskiPhD psobolewskiPhD approved these changes

@jni jni Awaiting requested review from jni

@melissawm melissawm Awaiting requested review from melissawm

Assignees

@TimMonko TimMonko

Labels
documentation Improvements or additions to documentation enhancement New feature or request highlight highlight this PR in release notes
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@TimMonko @aganders3 @psobolewskiPhD @melissawm
0