8000 Test passing PR number instead of ref on triggered build by aganders3 · Pull Request #738 · napari/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test passing PR number instead of ref on triggered build #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? 8000 Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Test passing PR number instead of ref on triggered build #738

merged 1 commit into from
Jun 20, 2025

Conversation

aganders3
Copy link
Contributor

References and relevant issues

See #736 (comment)

Description

Testing a hunch that @actions/checkout can't find the ref because it's looking for it in this repo, but it belongs to the fork the PR is coming from.

@github-actions github-actions bot added the maintenance CI, dependencies, and other maintenance label Jun 20, 2025
@aganders3
Copy link
Contributor Author

@napari-bot make slimfast

@psobolewskiPhD
Copy link
Member

Yes! I was looking at the same thing!
Forks man...can't live with em can't live without em.

@aganders3
Copy link
Contributor Author

Well, that didn't work, but also it looks like the bot uses the workflow file(s) from main so it wouldn't...

@psobolewskiPhD
Copy link
Member
psobolewskiPhD commented Jun 20, 2025 •
edited
Loading

let's see if dispatch works, cause I think it should also be affected.

Edit: just letting me choose main or tags :(

@psobolewskiPhD
Copy link
Member

I'm going to merge to see if we get this fixed. I think this is the correct solution.

@psobolewskiPhD
Copy link
Member

It won't get any more broken 😜

@psobolewskiPhD psobolewskiPhD merged commit 8bb1e3f into napari:main Jun 20, 2025
9 of 11 checks passed
@aganders3 aganders3 deleted the fix-bot-render branch June 20, 2025 01:10
@aganders3
Copy link
Contributor Author
aganders3 commented Jun 20, 2025 •
edited
Loading

I think it's working? https://github.com/napari/docs/actions/runs/15769048532

I guess now I'm a little confused how this is different from a normal "build PR docs" that runs on PR sync.

Edit: ahh, it lets you specify a more full docs build where the default is slimfast

@psobolewskiPhD psobolewskiPhD added this to the 0.6.2 milestone Jun 20, 2025
@psobolewskiPhD
Copy link
Member

Yeah, it's complicated 😦
I think i have a fix for the circle tho #739

@psobolewskiPhD psobolewskiPhD added the bug Something isn't working label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psobolewskiPhD psobolewskiPhD psobolewskiPhD approved these changes

Assignees

@aganders3 aganders3

Labels
bug Something isn't working maintenance CI, dependencies, and other maintenance
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@aganders3 @psobolewskiPhD
0