test: enable TxQ unit tests work with variable reference fee #5118
+773
−580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5118 +/- ##
=======================================
Coverage 78.1% 78.1%
=======================================
Files 790 790
Lines 67908 67908
Branches 8229 8226 -3
=======================================
+ Hits 53024 53033 +9
+ Misses 14884 14875 -9 see 4 files with indirect coverage changes |
2a44022 to
83ce629
Compare
bthomee
reviewed
Mar 4, 2025
| // Calculating expected median fee level based on known fee levels of median | ||
| // transaction levels. | ||
| auto | ||
| calcMedFeeLevel(FeeLevel64 const feeLevel1, FeeLevel64 const feeLevel2) |
There was a problem hiding this comment.
Isn't there an existing function you can call? Since the fee level is determined by the transactions seen and used in the non-test code, surely there must be a function that already does this?
There was a problem hiding this comment.
There's the code that does that:
rippled/src/xrpld/app/misc/detail/TxQ.cpp
Line 172 in 5bf3a30
Unfortunately this is inside of a struct that is declared private inside of transaction queue. Without changes to the actual code it's not possible to use
bthomee
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fix TxQ unit tests to be able to process reference fee value other than 10.
Context of Change
In preparation for potential reference fee change we would like to verify that fee change works as expected. The first step is to fix all unit tests to be able to work with different reference fee values.
Type of Change
API Impact
None
Test Plan
Tested following reference fee values:
10, 20, 50, 100, 200, 500, 1000by changing https://github.com/vvysokikh1/rippled/blob/2f432e812cb773048530ebfaf2e0e6def51e3cc2/src/test/jtx/impl/envconfig.cpp#L47