8000 Instrument proposal, validation and transaction messages by Tapanito · Pull Request #5348 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ rippled Public

Instrument proposal, validation and transaction messages #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 9, 2025
Merged

Instrument proposal, validation and transaction messages #5348

merged 19 commits into from
Apr 9, 2025

Conversation

Tapanito
Copy link
Collaborator
@Tapanito Tapanito commented Mar 17, 2025 •
edited
Loading

High Level Overview of Change

This PR adds metric counters for the following P2P message types:

  • Untrusted proposal and validation messages
  • Duplicate proposal, validation and transaction messages

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov Codecov
Copy link
codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.85714% with 104 lines in your changes missing coverage. Please review.

Project coverage is 78.1%. Comparing base (a099f5a) to head (cc2c21b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/overlay/detail/TrafficCount.h 56.0% 55 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp 0.0% 28 Missing ⚠️
src/xrpld/overlay/detail/OverlayImpl.cpp 26.7% 11 Missing ⚠️
src/xrpld/overlay/detail/OverlayImpl.h 16.7% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5348     +/-   ##
=========================================
- Coverage     78.1%   78.1%   -0.0%     
=========================================
  Files          795     795             
  Lines        68452   68567    +115     
  Branches      8277    8283      +6     
=========================================
+ Hits         53487   53554     +67     
- Misses       14965   15013     +48
Files with missing lines Coverage Δ
src/xrpld/overlay/Message.h 50.0% <ø> (ø)
src/xrpld/overlay/detail/Message.cpp 51.5% <ø> (ø)
src/xrpld/overlay/detail/TrafficCount.cpp 27.9% <100.0%> (-1.8%) ⬇️
src/xrpld/overlay/detail/OverlayImpl.h 38.4% <16.7%> (-1.6%) ⬇️
src/xrpld/overlay/detail/OverlayImpl.cpp 35.0% <26.7%> (-<0.1%) ⬇️
src/xrpld/overlay/detail/PeerImp.cpp 3.8% <0.0%> (-<0.1%) ⬇️
src/xrpld/overlay/detail/TrafficCount.h 60.1% <56.0%> (+3.0%) ⬆️

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tapanito Tapanito force-pushed the feature/untrusted-msg-metrics branch 3 times, most recently from a5afb33 to 61fe42d Compare March 24, 2025 16:44
@Tapanito Tapanito closed this Mar 24, 2025
@Tapanito Tapanito force-pushed the feature/untrusted-msg-metrics branch from 61fe42d to d22a505 Compare March 24, 2025 16:44
@Tapanito Tapanito reopened this Mar 24, 2025
@Tapanito Tapanito force-pushed the feature/untrusted-msg-metrics branch 2 times, most recently from ef47eae to 623ee22 Compare March 24, 2025 18:51
Tapanito added 3 commits March 26, 2025 10:45
@Tapanito
adds instrumentation to count untrusted proposal & valdiation message…
c8ed83f 
…s and duplicates

adds total traffic counter

improve MessageType type

add squelch message category

differentiate between incoming and outgoing squelch messages

adds a metric to calculate the traffic saved by squelching

Restores squelching ready check

fixes total traffic measurements

updates traffic count
@Tapanito
refactors metric counters to not be order sensitive
f3a360d
@Tapanito
improves method names
1a38c1c
@Tapanito Tapanito force-pushed the feature/untrusted-msg-metrics branch from d05f08d to 1a38c1c Compare March 26, 2025 10:07
@vlntb vlntb self-requested a review March 26, 2025 13:23
vlntb
vlntb requested changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator
@vlntb vlntb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding missing unit-tests.
Happy to approve once minor comments are addressed.

@Tapanito Tapanito requested a review from vlntb April 1, 2025 08:13
@Tapanito Tapanito force-pushed the feature/untrusted-msg-metrics branch from 062db60 to 3338b11 Compare April 3, 2025 14:18
bthomee
bthomee reviewed Apr 3, 2025
View reviewed changes
Tapanito
Tapanito commented Apr 4, 2025
View reviewed changes
bthomee
bthomee reviewed Apr 7, 2025
View reviewed changes
Copy link
Collaborator
@bthomee bthomee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tapanito can you push your updated branch? Based on your responses you have made some changes, but I don't see those yet here. Also, please accept the suggested typo fix.

vlntb
vlntb requested changes Apr 8, 2025
View reviewed changes
@Tapanito Tapanito added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Apr 9, 2025
@bthomee bthomee merged commit 7692eeb into XRPLF:develop Apr 9, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthomee bthomee bthomee approved these changes

@vlntb vlntb vlntb approved these changes

Assignees
No one assigned
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tapanito @bthomee @vlntb
0