-
Notifications
You must be signed in to change notification settings - Fork 54
feat: vite webui bundling SOFIE-3326 #1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release52 #1230 +/- ##
=============================================
- Coverage 61.38% 61.36% -0.03%
=============================================
Files 449 449
Lines 76369 76483 +114
Branches 4817 4936 +119
=============================================
+ Hits 46880 46933 +53
- Misses 29363 29422 +59
- Partials 126 128 +2 ☔ View full report in Codecov by Sentry. |
4d19f8b
to
e696c7a
Compare
e696c7a
to
d8dd003
Compare
7 tasks
This was referenced Aug 12, 2024
7 tasks
4 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a: Feature / Code improvement
New Behavior
As part of our intention to gradually migrate away from meteor, this pulls the webui out of meteor.
This is currently a bit crude, with the following flaws:
The whole ofmeteor/lib
is duplicated into this new packageThis aims to be as much of a drop-in replacement as possible, during build of the docker images, the vite packaged ui is dropped into the meteor/public directory, so that meteor is able to serve the ui.
Development might be a bit clunky currently, vite does not like commonjs libraries inside a monorepo, which might make developing those packages (corelib, shared-lib etc) for ui purposes a bit tedious (lots of restarting vite). As vite reloads its config file, this could probably be mitigated by moving the list of commonjs files to a json file with a dedicated watcher to regenerate that when the file list changes.
Testing
Affected areas
Time Frame
Other Information
Status