8000 feat: vite webui bundling SOFIE-3326 by Julusian · Pull Request #1230 · Sofie-Automation/sofie-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: vite webui bundling SOFIE-3326 #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

8000 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 9, 2024
Merged

feat: vite webui bundling SOFIE-3326 #1230

merged 9 commits into from
Sep 9, 2024

Conversation

Julusian
Copy link
Contributor
@Julusian Julusian commented Jul 24, 2024 •
edited
Loading

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Feature / Code improvement

New Behavior

As part of our intention to gradually migrate away from meteor, this pulls the webui out of meteor.

This is currently a bit crude, with the following flaws:

  • The whole of meteor/lib is duplicated into this new package
  • Various meteor libraries are copied into the webui/meteor folder
  • Do we need to replicate the 'legacy' browser build to ensure we support older browsers (eg casparcg 2.1?)
  • Reduce/avoid commonjs packages in the monorepo
  • Some css isn't being loaded correctly, likely some precedence/order change due to manual linking of files

This aims to be as much of a drop-in replacement as possible, during build of the docker images, the vite packaged ui is dropped into the meteor/public directory, so that meteor is able to serve the ui.

Development might be a bit clunky currently, vite does not like commonjs libraries inside a monorepo, which might make developing those packages (corelib, shared-lib etc) for ui purposes a bit tedious (lots of restarting vite). As vite reloads its config file, this could probably be mitigated by moving the list of commonjs files to a json file with a dedicated watcher to regenerate that when the file list changes.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian changed the title chore: update some outdated github urls feat: vite webui bundling SOFIE-3326 Jul 24, 2024
@codecov Codecov
Copy link
codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.58333% with 442 lines in your changes missing coverage. Please review.

Project coverage is 61.36%. Comparing base (3774dcf) to head (8e16b94).
Report is 58 commits behind head on release52.

Files with missing lines Patch % Lines
...eteor/server/api/deviceTriggers/triggersContext.ts 42.93% 105 Missing ⚠️
meteor/server/lib/lib.ts 74.82% 35 Missing ⚠️
meteor/server/lib/tic-toc.ts 0.00% 27 Missing and 1 partial ⚠️
...er/api/deviceTriggers/triggersContextCollection.ts 65.78% 26 Missing ⚠️
meteor/server/lib/cacheResult.ts 54.90% 23 Missing ⚠️
packages/corelib/src/lib.ts 60.46% 17 Missing ⚠️
meteor/server/api/ingest/rundownInput.ts 27.27% 16 Missing ⚠️
meteor/server/api/methodContext.ts 61.53% 10 Missing ⚠️
meteor/server/api/rest/koa.ts 73.68% 10 Missing ⚠️
meteor/server/publications/organization.ts 0.00% 8 Missing ⚠️
... and 62 more
Additional details and impacted files 
@@              Coverage Diff              @@
##           release52    #1230      +/-   ##
=============================================
- Coverage      61.38%   61.36%   -0.03%     
=============================================
  Files            449      449              
  Lines          76369    76483     +114     
  Branches        4817     4936     +119     
=============================================
+ Hits           46880    46933      +53     
- Misses         29363    29422      +59     
- Partials         126      128       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian force-pushed the feat/vite-ui-bundler2 branch from 4d19f8b to e696c7a Compare July 29, 2024 10:49
@Julusian Julusian force-pushed the feat/vite-ui-bundler2 branch from e696c7a to d8dd003 Compare July 29, 2024 10:55
@Julusian Julusian mentioned this pull request Aug 1, 2024
Merged
7 tasks
This was referenced Aug 12, 2024
Merged
Merged
@Julusian Julusian changed the base branch from release51 to release52 August 19, 2024 11:59
@Julusian Julusian marked this pull request as ready for review September 6, 2024 12:00
@Julusian Julusian requested a review from a team as a code owner September 6, 2024 12:00
@Julusian Julusian merged commit 5844a0c into release52 Sep 9, 2024
88 of 89 checks passed
@Julusian Julusian deleted the feat/vite-ui-bundler2 branch September 9, 2024 08:40
@Julusian Julusian mentioned this pull request Oct 18, 2024
Merged
7 tasks
@nytamin nytamin mentioned this pull request Dec 16, 2024
Open
4 tasks
@Julusian Julusian mentioned this pull request Dec 18, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Julusian
0