feat: vite reduce reliance on copied Meteor code #1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/vite-deduplicate-meteor-lib #1239 +/- ##
=====================================================================
+ Coverage 61.08% 83.48% +22.40%
=====================================================================
Files 400 173 -227
Lines 70215 30650 -39565
Branches 4150 2572 -1578
=====================================================================
- Hits 42888 25589 -17299
+ Misses 27222 5058 -22164
+ Partials 105 3 -102 ☔ View full report in Codecov by Sentry. |
31db979 to
7c27c3e
Compare
Base automatically changed from
feat/vite-deduplicate-meteor-lib
to
feat/vite-ui-bundler2
August 26, 2024 10:06
An error occurred while trying to automatically change base from
feat/vite-deduplicate-meteor-lib
to
feat/vite-ui-bundler2
August 26, 2024 10:06
df478be to
88743b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a:
Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)
New Behavior
Continuation of #1230
Builds on #1235
During #1230, a bunch of code was copied from the meteor github repository, as a replacement of what meteor used to provide/inject.
This PR goes through the copied code to strip out large chunks of dead code, and consider whether it is all necessary.
Quite a bit remains, which consists of:
Testing
Affected areas
Time Frame
Other Information
Status
…ive versions…ive versions…ive versions