fix: remove unused meteor ui packages #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release52 #1292 +/- ##
=============================================
+ Coverage 60.63% 60.64% +0.01%
=============================================
Files 459 459
Lines 78598 78583 -15
Branches 4961 4902 -59
=============================================
- Hits 47655 47654 -1
- Misses 30729 30836 +107
+ Partials 214 93 -121 ☔ View full report in Codecov by Sentry. |
nytamin
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Code improvement
New Behavior
This does some tidying following #1230 , to remove any webui only meteor packages.
This should have no impact other than reducing the number of dependencies installed by meteor in dev (unsure if it has any effect on production)
For reference, meteor does not directly serve any of the ui code, that gets delegated to koa https://github.com/nrkno/sofie-core/blob/132ebc086b47394216a17f06bc34dbbd2ff8070f/meteor/server/api/rest/koa.ts#L55-L57
Testing
Affected areas
Time Frame
Other Information
Status