8000 Add initial DepthAI driver setup by sivral · Pull Request #21 · AGH-CEAI/aegis_ros · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add initial DepthAI driver setup #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Feb 7, 2025
Merged

Add initial DepthAI driver setup #21

merged 29 commits into from
Feb 7, 2025

Conversation

sivral
Copy link
Contributor
@sivral sivral commented Jan 27, 2025 •
edited by macmacal
Loading

Description

This PR sets up the initial configuration to launch the DepthAI driver, enabling ROS to receive camera data. Future updates will expand functionality with additional topics and multiple camera support.

Motivation and context

The goal of this change is to receive data directly from the DepthAI camera in ROS, allowing further integration and utilization of camera information.

How has this been tested?

Manually, on the Geonosis PC.

Checklist

  • All TODOs in the code have been resolved or linked to a proper issue.
  • Code has been (auto)formatted.
  • Documentation (e.g., README, CHANGELOG, Wiki) has been updated.
  • All automated checks have passed.

ClickUp Task: 86971fbh6

@sivral sivral requested a review from macmacal January 29, 2025 18:52
macmacal
macmacal requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor
@macmacal macmacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation, especially:

  • The launch files diagram
  • The description of the files (README.md)

macmacal
macmacal requested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor
@macmacal macmacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address all of the comments.

sivral and others added 2 commits February 4, 2025 17:18
@sivral @macmacal
Apply suggestions from code review
7780fb2 
Update changelog

Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
@sivral
Rename camera parameters
e9b696e
macmacal
macmacal requested changes Feb 6, 2025
View reviewed changes
macmacal
macmacal requested changes Feb 6, 2025
View reviewed changes
macmacal
macmacal reviewed Feb 6, 2025
View reviewed changes
macmacal
macmacal reviewed Feb 6, 2025
View reviewed changes
@sivral @macmacal
Update UML diagram
449e20f 
Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
macmacal
macmacal reviewed Feb 6, 2025
View reviewed changes
sivral and others added 2 commits February 6, 2025 14:47
@sivral @macmacal
Add TODO comment
a3a1997 
Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com>
@sivral
Update names
3dbfe37
macmacal
macmacal approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor
@macmacal macmacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@macmacal macmacal marked this pull request as draft February 7, 2025 14:23
@macmacal macmacal marked this pull request as ready for review February 7, 2025 14:23
@macmacal macmacal marked this pull request as draft February 7, 2025 14:23
@sivral sivral marked this pull request as ready for review February 7, 2025 15:35
macmacal
macmacal approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor
@macmacal macmacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, LGTM 🆗

@sivral sivral merged commit 350b8d6 into humble-devel Feb 7, 2025
1 check passed
This was referenced Feb 7, 2025
Open
Open
@macmacal macmacal mentioned this pull request Feb 24, 2025
Merged
4 tasks
@sivral sivral deleted the feature/integrate_camera branch March 4, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macmacal macmacal macmacal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sivral @macmacal
0