Make entityselector handle fed prop related errors from wbsearchentities
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Addshore
	Jun 24 2020, 10:25 AM

Description

Alter the entityselector code to show the error message when the API error occurs
- This will include adding another element to customItems for the ooMenu which includes logic about when the item should be shown (when our error has been received)
- The error to be handled should be based on work done in T256223

The JS code is in view/resources/jquery/wikibase/jquery.wikibase.entityselector.js

Details

	Subject	Repo	Branch	Lines +/-
	FP: entityselector handles errors	mediawiki/extensions/Wikibase	master	+90 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T252015 [EPIC] Handling failed requests when federated properties are enabled
Resolved	Addshore	T255679 Handling failed requests to the federation source Wiki when statement is being created
Resolved	• toan	T256224 Make entityselector handle fed prop related errors from wbsearchentities

Event Timeline

Addshore created this task.Jun 24 2020, 10:25 AM

Addshore moved this task from Backlog to Ready for Breakdown on the Wikibase - Federated Properties board.

Addshore moved this task from Ready for Breakdown to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.Jun 24 2020, 10:33 AM

• toan moved this task from Prioritized backlog (aka Ready to pick up) to Sprint 2/6 (Hike 2) on the Wikibase - Federated Properties board.Jun 24 2020, 1:17 PM

• toan edited projects, added Wikibase - Federated Properties (Sprint 2/6 (Hike 2)); removed Wikibase - Federated Properties.

• toan claimed this task.Jun 25 2020, 3:17 PM

• toan moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jun 26 2020, 7:32 AM

Change 608055 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: entityselector handles errors

https://gerrit.wikimedia.org/r/608055

gerritbot added a project: Patch-For-Review.Jun 26 2020, 2:35 PM

• toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jun 30 2020, 9:06 AM

• toan moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jun 30 2020, 11:36 AM

• toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 2 2020, 5:55 AM

hoo moved this task from Peer Review to Product Verification on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 6 2020, 11:22 PM

Change 608055 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: entityselector handles errors

https://gerrit.wikimedia.org/r/608055

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 7 2020, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 7 2020, 12:10 AM

Addshore moved this task from Product Verification to Done on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 7 2020, 8:49 AM

Addshore closed this task as Resolved.Jul 15 2020, 8:17 AM