[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T256223

Make the wbsearchentities api return a "nice" error when a fed props exception happens
Closed, ResolvedPublic
Actions

Description

Make the wbsearchentities api return a "nice" error response (similar to wbsetclaim in the last hike T254998)

  • The PHP API is repo/includes/Api/SearchEntities.php
  • The pattern used to do this should be the same as done in setclaim in T254998

Details

SubjectRepoBranchLines +/-
FP: SearchEntities handles exceptionsmediawiki/extensions/Wikibasemaster+101 -5
FP: SearchEntities constructor changedmediawiki/extensions/WikibaseCirrusSearchmaster+3 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Jun 24 2020, 10:24 AM
Addshore mentioned this in T256224: Make entityselector handle fed prop related errors from wbsearchentities.
Addshore moved this task from Backlog to Ready for Breakdown on the Wikibase - Federated Properties board.
Addshore moved this task from Ready for Breakdown to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.Jun 24 2020, 10:33 AM
• toan claimed this task.Jun 24 2020, 1:16 PM
• toan moved this task from Prioritized backlog (aka Ready to pick up) to Sprint 2/6 (Hike 2) on the Wikibase - Federated Properties board.
• toan edited projects, added Wikibase - Federated Properties (Sprint 2/6 (Hike 2)); removed Wikibase - Federated Properties.
• toan moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.
gerritbot added a comment.Jun 24 2020, 3:10 PM

Change 607538 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: SearchEntities handles exceptions

https://gerrit.wikimedia.org/r/607538

gerritbot added a project: Patch-For-Review.Jun 24 2020, 3:10 PM
gerritbot added a comment.Jun 25 2020, 2:24 PM

Change 607801 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/WikibaseCirrusSearch@master] FP: Update SearchEntities constructor

https://gerrit.wikimedia.org/r/607801

• toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jun 26 2020, 8:54 AM
gerritbot added a comment.Jun 30 2020, 12:56 PM

Change 607801 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] FP: SearchEntities constructor changed

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseCirrusSearch/ /607801

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jun 30 2020, 1:00 PM
• toan mentioned this in rEWCS44b2e9e3da9a: FP: SearchEntities constructor changed.Jun 30 2020, 2:47 PM
• toan moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 3 2020, 7:55 AM
• toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 3 2020, 11:40 AM
hoo moved this task from Peer Review to Product Verification on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 6 2020, 10:16 PM
gerritbot added a comment.Jul 6 2020, 10:37 PM

Change 607538 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: SearchEntities handles exceptions

https://gerrit.wikimedia.org/r/607538

Maintenance_bot removed a project: Patch-For-Review.Jul 6 2020, 11:10 PM
Addshore moved this task from Product Verification to Done on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 7 2020, 8:48 AM
Addshore closed this task as Resolved.Jul 15 2020, 8:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits