Currently alter an array passed by reference to effectively return Revision objects, will need a breaking change; no good way to effect deprecation of using the array values
Only use outside of core is in an echo script that uses it to generate test data
Plan:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Open | None | T159283 Deprecate non-configuration globals | |||
| Open | DannyS712 | T159299 Deprecate and remove $wgUser | |||
| Resolved | DannyS712 | T267861 [GOAL] Emit deprecation warnings reading from $wgUser | |||
| Open | DannyS712 | T243708 Mediawiki core needs uses of global $wgUser removed | |||
| Resolved | DannyS712 | T246284 Hard deprecate the Revision class | |||
| Resolved | DannyS712 | T249393 Deprecate methods returning Revision objects | |||
| Resolved | DannyS712 | T251965 Deprecate use of Revision objects in WikiPage::doRollback and ::commitRollback |
Change 589792 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Echo@master] Remove rollback from generateSampleNotifications
Change 589789 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Make WikiPage::commitRollback and ::doRollback internal
(making sure that this shows up for Echo maintainers - cannot proceed with core until echo patch is merged)
Can please someone from Growth-Team or whoever is maintaining the Notifications and Echo please review a very simple patch for Echo on this task? It's removing some test code cause it's using methods we intend to make internal for Revision class deprecation, and I do not know if the script is ever used or not.
Change 589792 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Remove rollback from generateSampleNotifications
Change 589789 merged by jenkins-bot:
[mediawiki/core@master] Make WikiPage::commitRollback and ::doRollback internal
Change 606770 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::commitRollback - also return a RevisionRecord
Change 606770 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::commitRollback - also return a RevisionRecord
Change 607926 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::commitRollback - use DeprecatablePropertyArray
Change 607926 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::commitRollback - use DeprecatablePropertyArray
Next up: use a callback to only create the Revision objects when accessed, instead of always creating them. Will do after https://gerrit.wikimedia.org/r/c/mediawiki/core/+/604547 to avoid merge conflicts and keep things clear
Change 608842 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::commitRollback - deprecate accessing revision in DeprecatablePropertyArray
Change 608842 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::commitRollback - deprecate accessing revision in DeprecatablePropertyArray