See parent task for reasoning.
Live search for current uses of global $wgUser in wikimedia deployed code: https://codesearch.wmflabs.org/deployed/?q=global%5B%5E%3B%5D%2B%5C%24wgUser%5B%2C%3B%5D&i=nope&files=&repos=
Live search for current code using $wgUser in deployed code: https://codesearch.wmcloud.org/deployed/?q=wgUser(%5B%3B%2C%27%22-%5D%7C%5Cs%7C%24)&i=nope&files=%5C.php%24&repos=
Patches that need to be reviewed: https://gerrit.wikimedia.org/r/#/q/topic:global-wguser+status:open
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Open | None | T159283 Deprecate non-configuration globals | ||
| Open | DannyS712 | T159299 Deprecate and remove $wgUser | ||
| Declined | None | T218555 Provide access to WebRequest and associated information via a service object | ||
| Declined | DannyS712 | T243003 Create method to temporarily override contextuser / wgUser | ||
| Declined | DannyS712 | T243004 RequestContext setUser should also set wgUser | ||
| Resolved | None | T243371 Non-gerrit extensions that need uses of global $wgUser removed [tracking] | ||
| Resolved | DannyS712 | T244452 Add global $wgUser to DeprecatedGlobalVariablesSniff | ||
| Open | DannyS712 | T247793 Non-WMF deployed extensions need uses of global $wgUser removed [tracking] | ||
| Resolved | DannyS712 | T267861 [GOAL] Emit deprecation warnings reading from $wgUser | ||
| Open | DannyS712 | T243708 Mediawiki core needs uses of global $wgUser removed | ||
| Resolved | DannyS712 | T245959 WMF deployed extensions need uses of global $wgUser removed [tracking] | ||
| · · · |
Status update
Wikimedia deployed extensions still writing to $wgUser:
Wikimedia deployed extensions still reading from $wgUser
Trying to organize subtasks - T245959: WMF deployed extensions need uses of global $wgUser removed [tracking] is tracking all WMF deployed extensions and the progress towards hard deprecation
Untagging from Clinic Duty as there does not seem to be any open patches remaining on this task.
All of the patches in https://gerrit.wikimedia.org/r/#/q/topic:global-wguser+status:open are part of this, though they are listed as for individual subtasks. Retagging to make it clear that there are still patches to review (rather than tagging each subtask)
Some more cleanup to make task hierarchy clearer - T247793: Non-WMF deployed extensions need uses of global $wgUser removed [tracking]
Our current working process is to have the actual task with the patch on the workboard, making use of either the task's "Related Gerrit Patches" section or a bot-generated list like the one at https://wikifarm.wmflabs.org/cpt/index.php/Phab:T159299 to find the patches from the task. So when a task has no patches, it's confusing to still have it in the "needs review" column on the workboard.
There has been some discussion about somehow switching to a Gerrit dashboard that would contain just the patches needing Clinic Duty review. I don't know any details as to how that might wind up working as a replacement though.
Change 582285 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Declare $wgUser to be deprecated in version 1.35
Change 582285 merged by jenkins-bot:
[mediawiki/core@master] Declare $wgUser to be deprecated in version 1.35
Needed until all reads are removed:
cleanupSpam.php, cleanupTable.inc, deleteBatch.php, eleteDefaultMessages.php, deleteEqualMessages.php, edit.php, importImages.php, importSiteScripts.php, moveBatch.php, preprocessorFuzzTest.php
Some tests also use setMwGlobals to interact with $wgUser: EditPageTest.php, RevisionDbTest.php, RevisionTest.php, CheckBlocksSecondaryAuthenticationProviderTest.php, RequestContextTest.php, LogFormatterTest.php, ParserOptionsTest.php, UserTest.php, DumpTestCase.php - all to be addressed
Still used in
The codesearch linked in the task description didn't catch some of these, because they were accessed via $GLOBALS, setMwGlobals, or were in the global context already. I'm updating the link to hopefully catch them all.
Status update for deployed code:
A bunch of places still write to $wgUser - those need to be kept until after reading from it emits deprecation notices. I have a plan for doing that based on the DeprecatedGlobal class. The following is a list of core uses of $wgUser excluding most writes:
Extensions:
If people are willing to help review patches, it is entirely possible to be emitting deprecation notices when $wgUser is read from before 1.37 is cut, and then we can finally remove it in 1.38 (my understanding of php is that it is impossible to detect replacing a global variable, i.e. when an extension sets $wgUser to anything). My thanks to @Pchelolo for helping with so many reviews already.
(last updated 7/15/21)
Now that the Echo extension no longer reads from $wgUser, we can finally start emitting deprecation warnings - doing that at T267861: [GOAL] Emit deprecation warnings reading from $wgUser
Okay, we are now emitting deprecation warnings, and should be ready to start removing the writes soon - but lets wait for 1.37 to be officially released before we start dropping stuff, just in case something was missed in the deprecations