[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T249561

Deprecate methods accepting Revision objects as parameters
Closed, ResolvedPublic
Actions

Description

So that the class can be removed

Core methods tracked in P10916

Details

SubjectRepoBranchLines +/-
resourceloader: Use RevisionRecord in WikiModule::invalidateModuleCachemediawiki/coremaster+32 -17
ApiQueryRevisions::getRollbackToken - pass RevisionRecordmediawiki/coremaster+27 -3
DifferenceEngine::getParserOutput - accept a RevisionRecordmediawiki/coremaster+5 -2
WikiPage::updateRevisionOn - replace uses, hard deprecate Revision usemediawiki/coremaster+35 -21
MediaWikiIntegrationTestCase: Remove use of Revision objectsmediawiki/coremaster+10 -5
Only RevisionRecord in MobileSpecialPageFeed::getRevisionCommentHTMLmediawiki/extensions/MobileFrontendmaster+5 -10
Deprecate Revision in EntityContentDiffView::getRevisionHeadermediawiki/extensions/Wikibasemaster+2 -4
Pass RevisionRecord to DifferenceEngine::getRevisionHeadermediawiki/coremaster+12 -6
SpecialUndelete: Make showDiff private, use RevisionRecordmediawiki/coremaster+49 -30
EntityContentDiffView::getParserOutput - don't require Revisionsmediawiki/extensions/Wikibasemaster+8 -2
Use RevisionRecord instead of Revisionmediawiki/extensions/Videomaster+2 -3
Hard deprecate using Revision objects for Linker methodsmediawiki/coremaster+10 -3
ChangeNotifier - use RevisionRecordmediawiki/extensions/Wikibasemaster+58 -34
Hard deprecate Article::getUndoContentmediawiki/coremaster+4 -0
Hard deprecate Article::prepareContentForEditmediawiki/coremaster+4 -0
Hard deprecate Article::doEditUpdatesmediawiki/coremaster+4 -2
Fix remaining uses and hard deprecate Title::(get|count)AuthorsBetweenmediawiki/coremaster+35 -10
Pass RevisionRecord to Linker methodsmediawiki/coremaster+78 -43
Remove use of WikiPage::getUndoContent in RevisionReviewForm::doSubmitmediawiki/extensions/FlaggedRevswmf/1.35.0-wmf.28+14 -7
Remove use of WikiPage::getUndoContent in RevisionReviewForm::doSubmitmediawiki/extensions/FlaggedRevsmaster+14 -7
SpecialMobileContributions::showContributionsRow - use RevisionRecordmediawiki/extensions/MobileFrontendmaster+14 -6
Hard deprecate Article::updateRevisionOn and ::updateIfNewerOnmediawiki/coremaster+6 -0
Pass a RevisionRecord to WikiPage::updateRevisionOnmediawiki/extensions/FlaggedRevsmaster+3 -3
Accept a RevisionRecord in WikiPage::updateRevisionOnmediawiki/coremaster+12 -8
WikiPage::onArticleEdit - accept a RevisionRecordmediawiki/coremaster+12 -4
Make HistoryPager methods private, use RevisionRecordmediawiki/coremaster+14 -12
Remove use of Revision::newFromId, use RevisionRecord in Linker methodsmediawiki/extensions/Jademaster+83 -52
Hard deprecate Article::doDeleteUpdates, use RevisionRecord in WikiPagemediawiki/coremaster+30 -8
Use RevisionRecord in WikiPage::setLastEdit, make privatemediawiki/coremaster+11 -7
Support RevisionRecord in WikiPage::hasDifferencesOutsideMainSlotmediawiki/coremaster+28 -10
Don't create a Revision object for Linker::revUserTools in MW 1.35+mediawiki/extensions/TwoColConflictmaster+7 -1
Accept RevisionRecord in Linker methodsmediawiki/coremaster+118 -41
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
DannyS712 updated the task description. (Show Details)Apr 6 2020, 10:52 PM
DannyS712 added a subtask: T249397: Replace LinksUpdate Revision methods with RevisionRecord.
• Pchelolo edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).Apr 7 2020, 12:45 AM
gerritbot added a comment.Apr 7 2020, 1:20 AM

Change 586459 merged by jenkins-bot:
[mediawiki/core@master] Accept RevisionRecord in Linker methods

https://gerrit.wikimedia.org/r/586459

gerritbot added a comment.Apr 7 2020, 1:26 AM

Change 586484 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TwoColConflict@master] Don't create a Revision object for Linker::revUserTools

https://gerrit.wikimedia.org/r/586484

DannyS712 added a comment.Apr 7 2020, 1:29 AM
In T249561#6034925, @gerritbot wrote:

Change 586484 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TwoColConflict@master] Don't create a Revision object for Linker::revUserTools

https://gerrit.wikimedia.org/r/586484

Other than this replacement, the only deployed extension that will need to be updated before hard deprecation of Revision objects is Jade, which will be updated as part of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Jade/+/586445/

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 7 2020, 2:00 AM
gerritbot added a comment.Apr 7 2020, 7:37 AM

Change 586484 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Don't create a Revision object for Linker::revUserTools in MW 1.35+

https://gerrit.wikimedia.org/r/586484

Maintenance_bot removed a project: Patch-For-Review.Apr 7 2020, 8:10 AM
gerritbot added a comment.Apr 7 2020, 11:50 PM

Change 587376 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Support RevisionRecord in WikiPage::hasDifferencesOutsideMainSlot

https://gerrit.wikimedia.org/r/587376

gerritbot added a project: Patch-For-Review.Apr 7 2020, 11:50 PM
gerritbot added a comment.Apr 7 2020, 11:59 PM

Change 587379 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Use RevisionRecord in WikiPage::setLastEdit, make private

https://gerrit.wikimedia.org/r/587379

gerritbot added a comment.Apr 8 2020, 12:44 AM

Change 587376 merged by jenkins-bot:
[mediawiki/core@master] Support RevisionRecord in WikiPage::hasDifferencesOutsideMainSlot

https://gerrit.wikimedia.org/r/587376

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.28; 2020-04-14); removed MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 8 2020, 1:00 AM
gerritbot added a comment.Apr 8 2020, 1:46 AM

Change 587379 merged by jenkins-bot:
[mediawiki/core@master] Use RevisionRecord in WikiPage::setLastEdit, make private

https://gerrit.wikimedia.org/r/587379

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2020, 2:10 AM
gerritbot added a comment.Apr 8 2020, 2:36 AM

Change 587393 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace remaining uses and hard deprecate Title::getAuthorsBetween

https://gerrit.wikimedia.org/r/587393

gerritbot added a project: Patch-For-Review.Apr 8 2020, 2:36 AM
gerritbot added a comment.Apr 8 2020, 2:49 AM

Change 587395 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::doDeleteUpdates, use RevisionRecord in WikiPage

https://gerrit.wikimedia.org/r/587395

gerritbot added a comment.Apr 8 2020, 6:09 PM

Change 587571 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Use RevisionRecord in ResourceLoaderWikiModule::invalidateModuleCache

https://gerrit.wikimedia.org/r/587571

gerritbot added a comment.Apr 8 2020, 7:19 PM

Change 587395 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::doDeleteUpdates, use RevisionRecord in WikiPage

https://gerrit.wikimedia.org/r/587395

gerritbot added a comment.Apr 9 2020, 1:25 AM

Change 586445 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove use of Revision::newFromId, use RevisionRecord in Linker methods

https://gerrit.wikimedia.org/r/586445

gerritbot added a comment.Apr 9 2020, 7:10 PM

Change 586445 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove use of Revision::newFromId, use RevisionRecord in Linker methods

https://gerrit.wikimedia.org/r/586445

DannyS712 closed subtask T249397: Replace LinksUpdate Revision methods with RevisionRecord as Resolved.Apr 10 2020, 1:37 AM
gerritbot added a comment.Apr 10 2020, 6:04 AM

Change 587908 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] DifferenceEngine::getParserOutput - accept a RevisionRecord

https://gerrit.wikimedia.org/r/587908

gerritbot added a comment.Apr 10 2020, 6:12 AM

Change 587910 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::onArticleEdit - accept a RevisionRecord

https://gerrit.wikimedia.org/r/587910

gerritbot added a comment.Apr 10 2020, 6:19 AM

Change 587911 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Make HistoryPager methods private, use RevisionRecord

https://gerrit.wikimedia.org/r/587911

gerritbot added a comment.Apr 10 2020, 6:27 AM

Change 587912 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] EntityContentDiffView::getParserOutput - don't require Revisions

https://gerrit.wikimedia.org/r/587912

gerritbot added a comment.Apr 10 2020, 5:08 PM

Change 587911 merged by jenkins-bot:
[mediawiki/core@master] Make HistoryPager methods private, use RevisionRecord

https://gerrit.wikimedia.org/r/587911

gerritbot added a comment.Apr 13 2020, 5:05 AM

Change 588199 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Remove use of WikiPage::getUndoContent in RevisionReviewForm::doSubmit

https://gerrit.wikimedia.org/r/588199

gerritbot added a comment.Apr 14 2020, 4:11 AM

Change 587910 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::onArticleEdit - accept a RevisionRecord

https://gerrit.wikimedia.org/r/587910

gerritbot added a comment.Apr 15 2020, 6:01 AM

Change 588838 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::updateRevisionOn

https://gerrit.wikimedia.org/r/588838

gerritbot added a comment.Apr 15 2020, 6:07 AM

Change 588839 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Accept a RevisionRecord in WikiPage::updateRevisionOn

https://gerrit.wikimedia.org/r/588839

gerritbot added a comment.Apr 15 2020, 1:35 PM

Change 588199 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Remove use of WikiPage::getUndoContent in RevisionReviewForm::doSubmit

https://gerrit.wikimedia.org/r/588199

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 15 2020, 2:00 PM
gerritbot added a comment.Apr 15 2020, 9:34 PM

Change 589137 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Pass a RevisionRecord to WikiPage::updateRevisionOn

https://gerrit.wikimedia.org/r/589137

gerritbot added a comment.Apr 15 2020, 9:44 PM

Change 588839 merged by jenkins-bot:
[mediawiki/core@master] Accept a RevisionRecord in WikiPage::updateRevisionOn

https://gerrit.wikimedia.org/r/588839

gerritbot added a comment.Apr 16 2020, 12:01 AM

Change 588838 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::updateRevisionOn and ::updateIfNewerOn

https://gerrit.wikimedia.org/r/588838

gerritbot added a comment.Apr 16 2020, 12:07 AM

Change 589137 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Pass a RevisionRecord to WikiPage::updateRevisionOn

https://gerrit.wikimedia.org/r/589137

gerritbot added a comment.Apr 16 2020, 2:02 AM

Change 589171 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace NewRevisionFromEditComplete with RevisionFromEditComplete

https://gerrit.wikimedia.org/r/589171

gerritbot added a comment.Apr 16 2020, 7:23 PM

Change 589407 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] SpecialMobileContributions::showContributionsRow - use RevisionRecord

https://gerrit.wikimedia.org/r/589407

gerritbot added a comment.Apr 16 2020, 8:57 PM

Change 589407 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] SpecialMobileContributions::showContributionsRow - use RevisionRecord

https://gerrit.wikimedia.org/r/589407

gerritbot added a comment.Apr 16 2020, 9:38 PM

Change 589431 had a related patch set uploaded (by Jforrester; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@wmf/1.35.0-wmf.28] Remove use of WikiPage::getUndoContent in RevisionReviewForm::doSubmit

https://gerrit.wikimedia.org/r/589431

gerritbot added a comment.Apr 16 2020, 9:56 PM

Change 589431 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@wmf/1.35.0-wmf.28] Remove use of WikiPage::getUndoContent in RevisionReviewForm::doSubmit

https://gerrit.wikimedia.org/r/589431

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.28; 2020-04-14); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 16 2020, 10:00 PM
gerritbot added a comment.Apr 18 2020, 12:21 AM

Change 589766 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Pass RevisionRecord to Linker methods

https://gerrit.wikimedia.org/r/589766

gerritbot added a comment.Apr 18 2020, 1:58 AM

Change 589766 merged by jenkins-bot:
[mediawiki/core@master] Pass RevisionRecord to Linker methods

https://gerrit.wikimedia.org/r/589766

gerritbot added a comment.Apr 18 2020, 1:59 AM

Change 589791 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate using Revision objects for Linker methods

https://gerrit.wikimedia.org/r/589791

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 18 2020, 2:00 AM
gerritbot added a comment.Apr 18 2020, 2:27 AM

Change 589794 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::doEditUpdates

https://gerrit.wikimedia.org/r/589794

gerritbot added a comment.Apr 18 2020, 2:29 AM

Change 587393 merged by jenkins-bot:
[mediawiki/core@master] Fix remaining uses and hard deprecate Title::(get|count)AuthorsBetween

https://gerrit.wikimedia.org/r/587393

gerritbot added a comment.Apr 18 2020, 4:20 AM

Change 589791 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate using Revision objects for Linker methods

https://gerrit.wikimedia.org/r/589791

gerritbot added a comment.Apr 18 2020, 4:22 AM

Change 589794 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::doEditUpdates

https://gerrit.wikimedia.org/r/589794

gerritbot added a comment.Apr 18 2020, 5:39 PM

Change 589881 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::prepareContentForEdit

https://gerrit.wikimedia.org/r/589881

gerritbot added a comment.Apr 18 2020, 5:43 PM

Change 589882 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Article::getUndoContent

https://gerrit.wikimedia.org/r/589882

DannyS712 mentioned this in T246284: Hard deprecate the Revision class.Apr 18 2020, 5:49 PM
gerritbot added a comment.Apr 18 2020, 5:58 PM

Change 589881 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::prepareContentForEdit

https://gerrit.wikimedia.org/r/589881

gerritbot added a comment.Apr 18 2020, 6:22 PM

Change 589882 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Article::getUndoContent

https://gerrit.wikimedia.org/r/589882

gerritbot added a comment.Apr 20 2020, 10:39 AM

Change 591021 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] ChangeNotifier::notifyOnPageUndeleted - use RevisionRecord

https://gerrit.wikimedia.org/r/591021

gerritbot added a comment.Apr 20 2020, 4:29 PM

Change 591021 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] ChangeNotifier - use RevisionRecord

https://gerrit.wikimedia.org/r/591021

cscott subscribed.Apr 20 2020, 9:09 PM

https://gerrit.wikimedia.org/r/589791 / 82657a347a7f3daa9de5ef7454603c803073cbb5 seems to be causing jenkins to fail for [[mw:Extension::Video]], cf https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/62765/console where the failure is reported as:

16:55:24 INFO:backend.DevWebServer:[Mon Apr 20 20:55:24 2020] PHP Deprecated:  Use of Linker::revUserTools with a Revision object was deprecated in MediaWiki 1.35. [Called from SpecialUndeleteWithVideoSupport::formatRevisionRow in /workspace/src/extensions/Video/includes/specials/SpecialUndeleteWithVideoSupport.php at line 1020] in /workspace/src/includes/debug/MWDebug.php on line 333
16:55:24 INFO:backend.DevWebServer:[Mon Apr 20 20:55:24 2020] PHP Deprecated:  Use of Linker::revComment with a Revision object was deprecated in MediaWiki 1.35. [Called from SpecialUndeleteWithVideoSupport::formatRevisionRow in /workspace/src/extensions/Video/includes/specials/SpecialUndeleteWithVideoSupport.php at line 1032] in /workspace/src/includes/debug/MWDebug.php on line 333
gerritbot added a comment.Apr 20 2020, 9:12 PM

Change 591182 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Video@master] Use RevisionRecord instead of Revision

https://gerrit.wikimedia.org/r/591182

cscott added a comment.Apr 20 2020, 9:15 PM

Patch for the above at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Video/+/591182

DannyS712 added a comment.Apr 20 2020, 9:16 PM
In T249561#6073434, @cscott wrote:

Patch for the above at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Video/+/591182

I haven't updated non-deployed extensions yet, but can send patches for them if you want

gerritbot added a comment.Apr 20 2020, 9:22 PM

Change 591182 merged by jenkins-bot:
[mediawiki/extensions/Video@master] Use RevisionRecord instead of Revision

https://gerrit.wikimedia.org/r/591182

gerritbot added a comment.Apr 21 2020, 11:01 PM

Change 591524 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] SpecialUndelete: Make showDiff private, use RevisionRecord

https://gerrit.wikimedia.org/r/591524

gerritbot added a comment.Apr 21 2020, 11:17 PM

Change 591531 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] MediaWikiIntegrationTestCase: Remove use of Revision objects

https://gerrit.wikimedia.org/r/591531

gerritbot added a comment.Apr 22 2020, 11:56 AM

Change 587912 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityContentDiffView::getParserOutput - don't require Revisions

https://gerrit.wikimedia.org/r/587912

DannyS712 closed subtask T250680: Hard deprecate WikiPage::getUndoContent as Resolved.Apr 23 2020, 8:24 PM
gerritbot added a comment.Apr 24 2020, 12:55 AM

Change 592321 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::updateRevisionOn - replace uses, hard deprecate Revision use

https://gerrit.wikimedia.org/r/592321

gerritbot added a comment.Apr 27 2020, 5:39 PM

Change 591524 merged by jenkins-bot:
[mediawiki/core@master] SpecialUndelete: Make showDiff private, use RevisionRecord

https://gerrit.wikimedia.org/r/591524

gerritbot added a comment.Apr 27 2020, 6:47 PM

Change 592740 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Pass RevisionRecord to DifferenceEngine::getRevisionHeader

https://gerrit.wikimedia.org/r/592740

gerritbot added a comment.Apr 27 2020, 8:37 PM

Change 592758 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Deprecate Revision in DifferenceEngine::getRevisionHeader

https://gerrit.wikimedia.org/r/592758

gerritbot added a comment.Apr 27 2020, 8:48 PM

Change 592740 merged by jenkins-bot:
[mediawiki/core@master] Pass RevisionRecord to DifferenceEngine::getRevisionHeader

https://gerrit.wikimedia.org/r/592740

gerritbot added a comment.Apr 27 2020, 9:06 PM

Change 592758 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Deprecate Revision in EntityContentDiffView::getRevisionHeader

https://gerrit.wikimedia.org/r/592758

DannyS712 closed subtask T250773: Hard deprecate support for Revisions from ContentHandler::getUndoContent as Resolved.Apr 27 2020, 9:17 PM
gerritbot added a comment.Apr 28 2020, 1:59 AM

Change 592801 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Only RevisionRecord in MobileSpecialPageFeed::getRevisionCommentHTML

https://gerrit.wikimedia.org/r/592801

DannyS712 updated the task description. (Show Details)Apr 28 2020, 2:01 AM
gerritbot added a comment.Apr 29 2020, 3:31 PM

Change 592801 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Only RevisionRecord in MobileSpecialPageFeed::getRevisionCommentHTML

https://gerrit.wikimedia.org/r/592801

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.31; 2020-05-05); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 29 2020, 4:00 PM
gerritbot added a comment.May 1 2020, 6:13 PM

Change 591531 merged by jenkins-bot:
[mediawiki/core@master] MediaWikiIntegrationTestCase: Remove use of Revision objects

https://gerrit.wikimedia.org/r/591531

gerritbot added a comment.May 1 2020, 7:14 PM

Change 592321 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::updateRevisionOn - replace uses, hard deprecate Revision use

https://gerrit.wikimedia.org/r/592321

gerritbot added a comment.May 30 2020, 7:04 PM

Change 587908 abandoned by DannyS712:
DifferenceEngine::getParserOutput - accept a RevisionRecord

Reason:
Already done

https://gerrit.wikimedia.org/r/587908

gerritbot added a comment.Jun 3 2020, 11:00 PM

Change 587571 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Use RevisionRecord in WikiModule::invalidateModuleCache

https://gerrit.wikimedia.org/r/587571

DannyS712 mentioned this in T249434: Replace hooks using Revision objects with RevisionRecord.Jun 15 2020, 3:13 PM
DannyS712 closed subtask T250318: Hard deprecate WikiPage::updateIfNewerOn as Resolved.Jun 17 2020, 8:44 PM
DannyS712 closed subtask T249563: Hard deprecate Revision use in WikiPage::doEditUpdates as Resolved.Jun 18 2020, 10:12 AM
DannyS712 closed subtask T255759: Hard deprecate passing a Revision to WikiPage::prepareContentForEdit as Resolved.Jun 24 2020, 12:33 AM
DannyS712 closed subtask T255909: DerivedPageDataUpdater::prepareUpdate $options array can include Revision objects as Resolved.Jun 24 2020, 3:17 AM
gerritbot added a comment.Jun 25 2020, 3:32 AM

Change 607654 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ApiQueryRevisions::getRollbackToken - pass RevisionRecord

https://gerrit.wikimedia.org/r/607654

gerritbot added a comment.Jul 1 2020, 3:44 AM

Change 607654 merged by jenkins-bot:
[mediawiki/core@master] ApiQueryRevisions::getRollbackToken - pass RevisionRecord

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /607654

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Jul 1 2020, 4:00 AM
DannyS712 closed this task as Resolved.Jul 2 2020, 2:51 AM
DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.

Should be done

DannyS712 moved this task from In progress to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits