Follow up: Hard deprecate not passing a user to ::userCan methods
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Feb 26 2020, 3:49 AM

Description

Follow up to T245958

The following userCan methods now clearly have fallbacks to $wgUser that should be removed

Revision::userCan (method should be deprecated entirely)
ArchivedFile::userCan
OldLocalFile::userCan

Details

	Subject	Repo	Branch	Lines +/-
	Hard deprecate not passing a user to ArchivedFile::userCan	mediawiki/core	master	+1 -2
	Hard deprecate not passing a user to OldLocalFile::userCan	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T242935 Deprecate core fallbacks to $wgUser
Resolved	DannyS712	T246189 Follow up: Hard deprecate not passing a user to ::userCan methods
Resolved	DannyS712	T247259 Remove remaining calls and hard deprecate Revision::userCan
Resolved	DannyS712	T246414 Audit all userCan calls
Resolved	DannyS712	T251357 Logs: Use of ArchivedFile::userCan without passing a $user parameter was deprecated in MediaWiki 1.35

Event Timeline

DannyS712 created this task.Feb 26 2020, 3:49 AM

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

DannyS712 mentioned this in T246414: Audit all userCan calls.Feb 28 2020, 6:48 AM

DannyS712 added a subtask: T246414: Audit all userCan calls.

DannyS712 closed subtask T246414: Audit all userCan calls as Resolved.Mar 8 2020, 1:32 AM

DannyS712 added a subtask: T247259: Remove remaining calls and hard deprecate Revision::userCan.Mar 9 2020, 5:54 PM

Change 579069 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate not passing a user to OldLocalFile::userCan

https://gerrit.wikimedia.org/r/579069

gerritbot added a project: Patch-For-Review.Mar 11 2020, 9:42 PM

DannyS712 moved this task from Next to In progress on the User-DannyS712 board.Mar 11 2020, 9:46 PM

DannyS712 closed subtask T247259: Remove remaining calls and hard deprecate Revision::userCan as Resolved.Mar 12 2020, 3:44 PM

Change 579069 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate not passing a user to OldLocalFile::userCan

https://gerrit.wikimedia.org/r/579069

DannyS712 removed a project: Patch-For-Review.Mar 16 2020, 11:50 PM

DannyS712 updated the task description. (Show Details)

Change 580144 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate not passing a user to ArchivedFile::userCan

https://gerrit.wikimedia.org/r/580144

gerritbot added a project: Patch-For-Review.Mar 16 2020, 11:52 PM

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Mar 16 2020, 11:53 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 17 2020, 12:00 AM

Change 580144 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate not passing a user to ArchivedFile::userCan

https://gerrit.wikimedia.org/r/580144

Change 580145 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceRating@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/580145

In T246189#5974367, @gerritbot wrote:

Change 580145 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceRating@master] Remove use of Title::userCan

https://gerrit.wikimedia.org/r/580145

Wrong task

DannyS712 closed this task as Resolved.Mar 17 2020, 12:18 AM

DannyS712 removed a project: Patch-For-Review.

DannyS712 updated the task description. (Show Details)

DannyS712 mentioned this in T251357: Logs: Use of ArchivedFile::userCan without passing a $user parameter was deprecated in MediaWiki 1.35.Apr 28 2020, 11:44 PM

DannyS712 added a subtask: T251357: Logs: Use of ArchivedFile::userCan without passing a $user parameter was deprecated in MediaWiki 1.35.

DannyS712 closed subtask T251357: Logs: Use of ArchivedFile::userCan without passing a $user parameter was deprecated in MediaWiki 1.35 as Resolved.Apr 29 2020, 10:20 PM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:33 AM