[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T246861

Deprecate not passing a user to ParserOptions::__construct and ::newCanonical
Closed, ResolvedPublic
Actions

Description

If a user isn't provided, it uses global $wgUser

Details

SubjectRepoBranchLines +/-
ParserOptions: Deprecate fallback to $wgUsermediawiki/coremaster+57 -18
Use ParserOptions::newFromAnon()mediawiki/extensions/Flowmaster+6 -3
CachingKartographerEmbeddingHandler: Pass a user to ParserOptionsmediawiki/extensions/Wikibasemaster+9 -1
EntityBuilder: Pass a user to ParserOptionsmediawiki/extensions/Jademaster+1 -1
Pass a user when creating ParserOptionsmediawiki/extensions/EntitySchemamaster+4 -1
convertToText - use ParserOptions::newFromAnonmediawiki/extensions/Flowmaster+1 -1
Tests: Pass a user when creating ParserOptions objectsmediawiki/extensions/Quizmaster+2 -2
JsonSchemaTest: Pass a user when creating ParserOptionsmediawiki/extensions/EventLoggingmaster+3 -2
Hard deprecate calling ParserOptions::newCanonical with no parametersmediawiki/coremaster+25 -16
Use ParserOptions::newFromAnon() instead of relying on global $wgUsermediawiki/extensions/ProofreadPagemaster+1 -1
Use ParserOptions::newFromUser() instead of relying on global $wgUsermediawiki/extensions/AbuseFiltermaster+13 -4
Pass a user when creating a new ParserOptionsmediawiki/extensions/ParserMigrationmaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/MultiBoilerplatemaster+3 -1
Use ParserOptions::newFromUser with conext usermediawiki/extensions/SecurePollmaster+4 -1
Don’t rely on $wgUser when creating ParserOptions in testmediawiki/extensions/Wikibasemaster+2 -2
Use ParserOptions::newFromAnon() instead of relying on global $wgUsermediawiki/extensions/PhpTagsStoragemaster+1 -1
Use ParserOptions::newFromAnon() instead of relying on global $wgUsermediawiki/extensions/MintyDocsmaster+5 -1
Pass 'canonical' for creating ParserOptions instead of using on $wgUsermediawiki/extensions/GrowthExperimentsmaster+1 -1
Use ParserOptions::newFromAnon() instead of relying on global $wgUsermediawiki/extensions/ProofreadPagemaster+3 -1
Don't fall back to global $wgUser when creating ParserOptionsmediawiki/extensions/BlueSpiceRSSFeedermaster+2 -2
Replace ParserOptions::newCanonical with ::newFromUser, pass a usermediawiki/extensions/TEImaster+1 -1
Use ParserOptions::newFromAnon() instead of relying on global $wgUsermediawiki/extensions/CollaborationKitmaster+5 -5
Use ParserOptions::newFromAnon() instead of relying on global $wgUsermediawiki/extensions/MassMessageEmailmaster+1 -1
Use ParserOptions::newFromAnon() instead of relying on global $wgUsermediawiki/extensions/Wikibasemaster+9 -9
Pass a user when creating a new ParserOptionsmediawiki/extensions/NewUserMessagemaster+6 -2
Pass a user when creating a new ParserOptionsmediawiki/extensions/LiquidThreadsmaster+2 -2
Use ParserOptions::newFromAnon() instead of relying on global $wgUsermediawiki/extensions/Mathmaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/Newsmaster+4 -3
Pass a user when creating a new ParserOptionsmediawiki/extensions/MediaWikiChatmaster+1 -1
Don't fall back to global $wgUser when creating ParserOptionsmediawiki/extensions/Scribuntomaster+9 -4
Use ParserOptions::newFromAnon() instead of relying on global $wgUsermediawiki/extensions/Babelmaster+1 -1
MessageCache: Pass a user when creating a new ParserOptionsmediawiki/coremaster+1 -1
Use ParserOptions::newFromAnon() instead of relying on global $wgUsermediawiki/extensions/Kartographermaster+3 -3
Pass a user when creating a new ParserOptionsmediawiki/extensions/MassMessagemaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/Flowmaster+11 -4
Pass a user when creating a new ParserOptionsmediawiki/extensions/FeaturedFeedsmaster+23 -12
Pass a user when creating a new ParserOptionsmediawiki/extensions/Echomaster+4 -4
Pass a user when creating a new ParserOptionsmediawiki/extensions/intersectionmaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/Commentsmaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/FileImportermaster+13 -5
Pass a user when creating a new ParserOptionsmediawiki/extensions/ConfirmEditmaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/Graphmaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/NewsTickermaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/DocBookExportmaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/TwoColConflictmaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/VisualEditormaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/skins/eruditemaster+1 -1
Pass a user when creating a new ParserOptionsmediawiki/extensions/VEForAllmaster+1 -1
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Mar 6 2020, 1:37 AM

Change 577406 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FeaturedFeeds@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577406

gerritbot added a comment.Mar 6 2020, 2:46 AM

Change 577406 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577406

DannyS712 mentioned this in rEFFD536a923afa50: Pass a user when creating a new ParserOptions.Mar 6 2020, 2:49 AM
gerritbot added a comment.Mar 7 2020, 2:15 AM

Change 577710 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Math@master] User ParserOptions::newFromAnon instead of relying on wgUser

https://gerrit.wikimedia.org/r/577710

gerritbot added a comment.Mar 7 2020, 2:18 AM

Change 577711 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MediaWikiChat@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577711

gerritbot added a comment.Mar 7 2020, 2:20 AM

Change 577712 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MultiBoilerplate@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577712

gerritbot added a comment.Mar 7 2020, 2:22 AM

Change 577713 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/News@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577713

gerritbot added a comment.Mar 7 2020, 2:25 AM

Change 577714 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/NewUserMessage@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577714

gerritbot added a comment.Mar 7 2020, 2:28 AM

Change 577716 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ProofreadPage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577716

gerritbot added a comment.Mar 7 2020, 2:31 AM

Change 577717 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Scribunto@master] Don't fall back to global $wgUser when creating ParserOptions

https://gerrit.wikimedia.org/r/577717

gerritbot added a comment.Mar 7 2020, 2:35 AM

Change 577718 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MintyDocs@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577718

gerritbot added a comment.Mar 7 2020, 2:36 AM

Change 577719 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessage@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577719

gerritbot added a comment.Mar 7 2020, 2:38 AM

Change 576914 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/576914

gerritbot added a comment.Mar 7 2020, 2:39 AM

Change 577720 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577720

gerritbot added a comment.Mar 7 2020, 2:43 AM

Change 577721 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] MessageCache: Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577721

gerritbot added a comment.Mar 7 2020, 2:56 AM

Change 577722 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Don't fall back to global $wgUser when creating ParserOptions

https://gerrit.wikimedia.org/r/577722

gerritbot added a comment.Mar 7 2020, 3:10 AM

Change 577723 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Kartographer@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577723

gerritbot added a comment.Mar 7 2020, 3:12 AM

Change 577724 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Babel@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577724

gerritbot added a comment.Mar 7 2020, 3:22 AM

Change 577719 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577719

gerritbot added a comment.Mar 7 2020, 3:30 AM

Change 577721 merged by jenkins-bot:
[mediawiki/core@master] MessageCache: Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577721

gerritbot added a comment.Mar 7 2020, 3:30 AM

Change 577723 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577723

gerritbot added a comment.Mar 7 2020, 3:42 AM

Change 577724 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577724

gerritbot added a comment.Mar 7 2020, 3:42 AM

Change 577717 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Don't fall back to global $wgUser when creating ParserOptions

https://gerrit.wikimedia.org/r/577717

DannyS712 mentioned this in rELUAfb850e853c97: Don't fall back to global $wgUser when creating ParserOptions.Mar 7 2020, 3:44 AM
gerritbot added a comment.Mar 7 2020, 4:09 AM

Change 577710 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577710

gerritbot added a comment.Mar 7 2020, 4:09 AM

Change 577711 merged by jenkins-bot:
[mediawiki/extensions/MediaWikiChat@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577711

gerritbot added a comment.Mar 7 2020, 4:09 AM

Change 577713 merged by jenkins-bot:
[mediawiki/extensions/News@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577713

gerritbot added a comment.Mar 8 2020, 10:12 AM

Change 577921 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceRSSFeeder@master] Don't fall back to global $wgUser when creating ParserOptions

https://gerrit.wikimedia.org/r/577921

gerritbot added a comment.Mar 8 2020, 10:14 AM

Change 577925 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CollaborationKit@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577925

gerritbot added a comment.Mar 8 2020, 10:16 AM

Change 577927 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SecurePoll@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577927

gerritbot added a comment.Mar 8 2020, 10:18 AM

Change 577930 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PhpTagsStorage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577930

gerritbot added a comment.Mar 8 2020, 10:20 AM

Change 577931 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MassMessageEmail@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577931

gerritbot added a comment.Mar 8 2020, 4:20 PM

Change 578043 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TEI@master] Pass a user to ParserOptions::newCanonical

https://gerrit.wikimedia.org/r/578043

gerritbot added a comment.Mar 8 2020, 7:53 PM

Change 577720 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577720

gerritbot added a comment.Mar 8 2020, 7:53 PM

Change 577714 merged by jenkins-bot:
[mediawiki/extensions/NewUserMessage@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577714

gerritbot added a comment.Mar 10 2020, 10:45 AM

Change 577722 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577722

gerritbot added a comment.Mar 11 2020, 1:38 AM

Change 577925 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577925

gerritbot added a comment.Mar 11 2020, 1:38 AM

Change 577931 merged by jenkins-bot:
[mediawiki/extensions/MassMessageEmail@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577931

gerritbot added a comment.Mar 11 2020, 1:57 AM

Change 578043 merged by jenkins-bot:
[mediawiki/extensions/TEI@master] Replace ParserOptions::newCanonical with ::newFromUser, pass a user

https://gerrit.wikimedia.org/r/578043

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.24; 2020-03-17); removed MW-1.35-notes (1.35.0-wmf.23; 2020-03-10).Mar 11 2020, 2:01 AM
DannyS712 mentioned this in rEMME393f400ef008: Use ParserOptions::newFromAnon() instead of relying on global $wgUser.Mar 11 2020, 2:26 AM
gerritbot added a comment.Mar 12 2020, 1:04 AM

Change 579111 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/579111

gerritbot added a comment.Mar 12 2020, 1:06 AM

Change 579112 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ParserMigration@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/579112

gerritbot added a comment.Mar 12 2020, 1:07 AM

Change 579113 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GrowthExperiments@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/579113

gerritbot added a comment.Mar 12 2020, 8:42 AM

Change 577921 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceRSSFeeder@master] Don't fall back to global $wgUser when creating ParserOptions

https://gerrit.wikimedia.org/r/577921

DannyS712 mentioned this in rEBTRf13739fd09ce: Don't fall back to global $wgUser when creating ParserOptions.Mar 12 2020, 9:17 AM
gerritbot added a comment.Mar 17 2020, 12:12 PM

Change 577716 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577716

gerritbot added a comment.Mar 17 2020, 7:57 PM

Change 579113 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Pass 'canonical' for creating ParserOptions instead of using on $wgUser

https://gerrit.wikimedia.org/r/579113

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.25; 2020-03-24); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 19 2020, 8:00 PM
DannyS712 added a comment.Apr 2 2020, 10:10 PM

Uses of new ParserOptions in deployed extensions that still need to be updated:

  • SecurePoll
  • EventLogging
  • EntitySchema
  • CollaborationKit
  • AbuseFilter
  • Quiz
  • Flow
  • Wikibase

Also: core, vendor

Uses of ParserOptions::newCanonical in deployed extensions that still need to be updated:

  • Wikibase
  • ProofreadPage

Also: parsoid, vendor, core

gerritbot added a comment.Apr 3 2020, 2:33 PM

Change 577718 merged by jenkins-bot:
[mediawiki/extensions/MintyDocs@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577718

gerritbot added a comment.Apr 12 2020, 7:19 AM

Change 577930 merged by Umherirrender:
[mediawiki/extensions/PhpTagsStorage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/577930

gerritbot added a comment.Apr 16 2020, 10:00 AM

Change 579111 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don’t rely on $wgUser when creating ParserOptions in test

https://gerrit.wikimedia.org/r/579111

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.30; 2020-04-28); removed MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Apr 16 2020, 11:00 AM
gerritbot added a comment.May 11 2020, 2:06 PM

Change 577927 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Use ParserOptions::newFromUser with conext user

https://gerrit.wikimedia.org/r/577927

gerritbot added a comment.May 11 2020, 2:26 PM

Change 577712 merged by jenkins-bot:
[mediawiki/extensions/MultiBoilerplate@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/577712

gerritbot added a comment.May 11 2020, 2:26 PM

Change 579112 merged by jenkins-bot:
[mediawiki/extensions/ParserMigration@master] Pass a user when creating a new ParserOptions

https://gerrit.wikimedia.org/r/579112

Huji closed this task as Resolved.May 11 2020, 2:44 PM
Huji subscribed.

All associated patches have been merged.

DannyS712 reopened this task as Open.May 11 2020, 2:45 PM
In T246861#6124967, @Huji wrote:

All associated patches have been merged.

There are more replacements left that I haven't sent patches for :)

Huji added a comment.May 11 2020, 2:46 PM

Oops. Shortsighted action on my part. Thank you for all the hard work!

FreedomFighterSparrow subscribed.May 11 2020, 2:47 PM

And here I was just trying to set up my Vagrant env to review this. Oh well. Thanks, guys!

gerritbot added a comment.May 11 2020, 2:50 PM

Change 595541 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ProofreadPage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/595541

gerritbot added a comment.May 11 2020, 2:55 PM

Change 576916 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Use ParserOptions::newFromUser() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/576916

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.32; 2020-05-12); removed MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).May 11 2020, 3:00 PM
DannyS712 mentioned this in rEMBP7ca2bd135de8: Pass a user when creating a new ParserOptions.May 11 2020, 3:55 PM
gerritbot added a comment.May 11 2020, 4:25 PM

Change 595541 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Use ParserOptions::newFromAnon() instead of relying on global $wgUser

https://gerrit.wikimedia.org/r/595541

gerritbot added a comment.Jun 15 2020, 11:05 PM

Change 605694 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate calling ParserOptions::newCanonical with no parameters

https://gerrit.wikimedia.org/r/605694

gerritbot added a comment.Jun 16 2020, 12:50 AM

Change 605694 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate calling ParserOptions::newCanonical with no parameters

https://gerrit.wikimedia.org/r/605694

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).Jun 16 2020, 1:00 AM
gerritbot added a comment.Jun 20 2020, 4:52 PM

Change 606787 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/EventLogging@master] JsonSchemaTest: Pass a user when creating ParserOptions

https://gerrit.wikimedia.org/r/606787

gerritbot added a comment.Jun 20 2020, 4:54 PM

Change 606788 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Quiz@master] Tests: Pass a user when creating ParserOptions objects

https://gerrit.wikimedia.org/r/606788

gerritbot added a comment.Jun 20 2020, 6:13 PM

Change 606787 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] JsonSchemaTest: Pass a user when creating ParserOptions

https://gerrit.wikimedia.org/r/606787

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.38; 2020-06-23); removed MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 20 2020, 7:00 PM
gerritbot added a comment.Sep 13 2020, 11:24 PM

Change 626900 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/EntitySchema@master] Pass a user when creating ParserOptions

https://gerrit.wikimedia.org/r/626900

gerritbot added a comment.Sep 13 2020, 11:28 PM

Change 626901 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] convertToText - use ParserOptions::newFromAnon

https://gerrit.wikimedia.org/r/626901

DannyS712 added a project: Platform Team Workboards (External Code Reviews).Sep 13 2020, 11:29 PM
gerritbot added a comment.Sep 14 2020, 4:56 AM

Change 606788 merged by jenkins-bot:
[mediawiki/extensions/Quiz@master] Tests: Pass a user when creating ParserOptions objects

https://gerrit.wikimedia.org/r/606788

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 14 2020, 5:00 AM
gerritbot added a comment.Sep 14 2020, 5:55 AM

Change 626901 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] convertToText - use ParserOptions::newFromAnon

https://gerrit.wikimedia.org/r/626901

DannyS712 added a comment.Sep 14 2020, 6:09 AM

Status update:
ParserOptions::newCanonical emits deprecation warnings if the first parameter is null, which results in a fallback to $wgUser in the constructor

Constructor does not yet emit deprecation warnings if called without a user.

Remaining uses without a user:
Wikibase: CachingKartographerEmbeddingHandler (the other uses of ParserOptions in wikibase generally refer to ValueParsers\ParserOptions)
EntitySchema: EntitySchemaContentTest - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/+/626900/
Jade: EntityBuilder
a bunch in core

gerritbot added a comment.Sep 14 2020, 8:52 AM

Change 626900 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Pass a user when creating ParserOptions

https://gerrit.wikimedia.org/r/626900

gerritbot added a comment.Sep 14 2020, 9:37 PM

Change 627220 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] CachingKartographerEmbeddingHandler: Pass a user to ParserOptions

https://gerrit.wikimedia.org/r/627220

gerritbot added a comment.Sep 14 2020, 9:38 PM

Change 627221 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] EntityBuilder: Pass a user to ParserOptions

https://gerrit.wikimedia.org/r/627221

gerritbot added a comment.Sep 15 2020, 12:44 AM

Change 627221 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] EntityBuilder: Pass a user to ParserOptions

https://gerrit.wikimedia.org/r/627221

DannyS712 added a comment.Sep 15 2020, 12:45 AM
In T246861#6457329, @DannyS712 wrote:

Status update:
ParserOptions::newCanonical emits deprecation warnings if the first parameter is null, which results in a fallback to $wgUser in the constructor

Constructor does not yet emit deprecation warnings if called without a user.

Remaining uses without a user:
Wikibase: CachingKartographerEmbeddingHandler (the other uses of ParserOptions in wikibase generally refer to ValueParsers\ParserOptions)
EntitySchema: EntitySchemaContentTest - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EntitySchema/+/626900/
Jade: EntityBuilder
a bunch in core

Jade and EntitySchema done, Wikibase patch pending at https://gerrit.wikimedia.org/r/627220

gerritbot added a comment.Sep 18 2020, 10:54 AM

Change 627220 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] CachingKartographerEmbeddingHandler: Pass a user to ParserOptions

https://gerrit.wikimedia.org/r/627220

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.10; 2020-09-22); removed MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 18 2020, 11:00 AM
daniel triaged this task as Medium priority.Sep 18 2020, 12:58 PM
gerritbot added a comment.Sep 18 2020, 3:07 PM

Change 628220 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ParserOptions: Deprecate fallback to $wgUser

https://gerrit.wikimedia.org/r/628220

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Sep 18 2020, 3:21 PM
gerritbot added a comment.Sep 18 2020, 3:41 PM

Change 628367 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Utils: Pass a user to ParserOptions

https://gerrit.wikimedia.org/r/628367

gerritbot added a comment.Dec 16 2020, 3:12 PM

Change 628367 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Use ParserOptions::newFromAnon()

https://gerrit.wikimedia.org/r/628367

gerritbot added a comment.Dec 16 2020, 3:17 PM

Change 628220 merged by jenkins-bot:
[mediawiki/core@master] ParserOptions: Deprecate fallback to $wgUser

https://gerrit.wikimedia.org/r/628220

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Dec 16 2020, 4:01 PM
DannyS712 closed this task as Resolved.Dec 16 2020, 4:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits