[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T245686

Hard deprecate old SpecialPageFactory
Closed, ResolvedPublic
Actions

Description

The SpecialPageFactory at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/includes/specialpage/SpecialPageFactory_deprecated.php is soft deprecated, and includes some function that fall back to global $wgUser
Rather than hard deprecating those specific functions, the entire class should be hard deprecated, so that it can be removed in 1.36

Deployed calls to static SpecialPageFactory functions:
https://codesearch.wmflabs.org/deployed/?q=SpecialPageFactory%3A%3A&i=nope&files=%5C.php%24&repos=

Details

SubjectRepoBranchLines +/-
Hard deprecate all methods of old SpecialPageFactorymediawiki/coremaster+24 -0
Stop using old deprecated SpecialPageFactory static functionsmediawiki/extensions/CentralNoticemaster+2 -6
Stop using old deprecated SpecialPageFactory static functionsmediawiki/extensions/ArticlePlaceholdermaster+5 -3
Stop using old deprecated SpecialPageFactory static functionsmediawiki/extensions/TimedMediaHandlermaster+4 -1
Stop using old deprecated SpecialPageFactory static functionsmediawiki/extensions/Scribuntomaster+6 -2
Stop using old deprecated SpecialPageFactory static functionsmediawiki/extensions/FlaggedRevsmaster+4 -2
Stop using old deprecated SpecialPageFactory static functionsmediawiki/extensions/DiscussionToolsmaster+2 -1
Stop using old deprecated SpecialPageFactory static functionsmediawiki/extensions/GlobalUsagemaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Feb 19 2020, 11:08 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 19 2020, 11:08 PM
gerritbot added a comment.Feb 19 2020, 11:09 PM

Change 573404 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TimedMediaHandler@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573404

gerritbot added a project: Patch-For-Review.Feb 19 2020, 11:09 PM

Change 573405 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Scribunto@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573405

gerritbot added a comment.Feb 19 2020, 11:13 PM

Change 573406 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalUsage@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573406

gerritbot added a comment.Feb 19 2020, 11:14 PM

Change 573407 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/DiscussionTools@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573407

gerritbot added a comment.Feb 19 2020, 11:16 PM

Change 573408 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573408

gerritbot added a comment.Feb 19 2020, 11:19 PM

Change 573410 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/ArticlePlaceholder@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573410

gerritbot added a comment.Feb 19 2020, 11:21 PM

Change 573411 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573411

DannyS712 updated the task description. (Show Details)Feb 19 2020, 11:24 PM
gerritbot added a comment.Feb 20 2020, 1:22 AM

Change 573406 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573406

gerritbot added a comment.Feb 20 2020, 1:35 AM

Change 573407 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573407

gerritbot added a comment.Feb 20 2020, 1:35 AM

Change 573405 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573405

gerritbot added a comment.Feb 20 2020, 1:35 AM

Change 573411 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573411

DannyS712 mentioned this in rELUAd1f6e793ee4f: Stop using old deprecated SpecialPageFactory static functions.Feb 20 2020, 1:48 AM
gerritbot added a comment.Feb 20 2020, 1:49 AM

Change 573404 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573404

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 20 2020, 2:00 AM
gerritbot added a comment.Feb 20 2020, 2:01 AM

Change 573410 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573410

DannyS712 updated the task description. (Show Details)Feb 20 2020, 2:03 AM
Addshore moved this task from incoming to blocked on others on the Wikidata board.Feb 20 2020, 8:59 AM
Addshore moved this task from blocked on others to monitoring on the Wikidata board.
DannyS712 mentioned this in T243708: Mediawiki core needs uses of global $wgUser removed.Feb 22 2020, 1:18 AM
gerritbot added a comment.Feb 22 2020, 8:25 PM

Change 573408 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Stop using old deprecated SpecialPageFactory static functions

https://gerrit.wikimedia.org/r/573408

Maintenance_bot removed a project: Patch-For-Review.Feb 22 2020, 9:10 PM
DannyS712 updated the task description. (Show Details)Feb 22 2020, 9:31 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Next part: actually hard deprecate each of the methods

gerritbot added a comment.Feb 23 2020, 9:24 PM

Change 574248 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate all methods of old SpecialPageFactory

https://gerrit.wikimedia.org/r/574248

gerritbot added a project: Patch-For-Review.Feb 23 2020, 9:24 PM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Feb 23 2020, 9:27 PM
gerritbot added a comment.Feb 24 2020, 9:29 PM

Change 574248 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate all methods of old SpecialPageFactory

https://gerrit.wikimedia.org/r/574248

Maintenance_bot removed a project: Patch-For-Review.Feb 24 2020, 10:10 PM
JTannerWMF added a project: Editing-team (Tracking).Feb 25 2020, 4:41 PM
JTannerWMF moved this task from Backlog to External on the Editing-team (Tracking) board.
DannyS712 closed this task as Resolved.Feb 25 2020, 6:19 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Mar 4 2020, 7:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits