CentralNotice needs uses of global $wgUser replaced
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Dec 31 2019, 1:06 AM

Description

See parent task

Details

	Subject	Repo	Branch	Lines +/-
	Remove last use of global $wgUser	mediawiki/extensions/CentralNotice	master	+7 -7
	Remove uses of global $wgUser as a fallback	mediawiki/extensions/CentralNotice	master	+16 -20

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Resolved	DannyS712	T245959 WMF deployed extensions need uses of global $wgUser removed [tracking]
Resolved	DannyS712	T241615 CentralNotice needs uses of global $wgUser replaced

Event Timeline

DannyS712 created this task.Dec 31 2019, 1:06 AM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 31 2019, 1:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 561237 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Remove uses of global $wgUser

https://gerrit.wikimedia.org/r/561237

gerritbot added a project: Patch-For-Review.Dec 31 2019, 1:06 AM

DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Dec 31 2019, 1:12 AM

DannyS712 added a parent task: T159299: Deprecate and remove $wgUser.

Change 561237 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove uses of global $wgUser as a fallback

https://gerrit.wikimedia.org/r/561237

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2020, 11:10 AM

DannyS712 closed this task as Resolved.Jan 24 2020, 3:06 PM

Jdforrester-WMF added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 26 2020, 1:15 AM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Feb 6 2020, 8:49 PM

DannyS712 added a parent task: T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].Feb 23 2020, 10:29 PM

DannyS712 removed a parent task: T159299: Deprecate and remove $wgUser.

DannyS712 reopened this task as Open.Feb 27 2020, 4:05 AM

DannyS712 added a project: Patch-For-Review.

DannyS712 moved this task from Resolved (deprecation) to Awaiting review and deployment on the User-DannyS712 board.

Change 575121 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CentralNotice@master] Remove last use of global $wgUser

https://gerrit.wikimedia.org/r/575121

Change 575121 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Remove last use of global $wgUser

https://gerrit.wikimedia.org/r/575121

DannyS712 closed this task as Resolved.Feb 29 2020, 2:02 AM

DannyS712 removed a project: Patch-For-Review.

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.22; 2020-03-03); removed MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 29 2020, 3:00 AM

DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Mar 4 2020, 7:54 AM