[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T232877

The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet
Closed, ResolvedPublic
Actions

Description

1.31

Details

SubjectRepoBranchLines +/-
Hard deprecate the RevisionInsertComplete hookmediawiki/coremaster+4 -2
Replace RevisionInsertComplete hook with RevisionRecordInsertedmediawiki/extensions/WikimediaEventsmaster+12 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Sep 13 2019, 5:54 PM
Kizule claimed this task.Sep 15 2019, 11:32 AM
Kizule subscribed.

@Jdforrester-WMF In https://codesearch.wmflabs.org/search/?q=RevisionInsertComplete&i=nope&files=&repos= I found to hard deprecation is scheduled for 1.32 but we are already on 1.33 and 1.34 will be soon released. Should I add wfDeprecated( METHOD, '1.xx' ); in https://gerrit.wikimedia.org/g/mediawiki/core/+/dafe226e8c06f4e69ff6da63fad72a59342f4552/includes/Revision/RevisionStore.php#541 or what?

Restricted Application added a project: User-Kizule. · View Herald TranscriptSep 15 2019, 11:32 AM
Reedy subscribed.Sep 15 2019, 8:49 PM

Have you looked at the code for Hooks.php?

https://github.com/wikimedia/mediawiki/blob/master/includes/Hooks.php#L190-L200

Kizule added a comment.Sep 15 2019, 8:50 PM
In T232877#5494309, @Reedy wrote:

Have you looked at the code for Hooks.php?

https://github.com/wikimedia/mediawiki/blob/master/includes/Hooks.php#L190-L200

No, why?

Reedy added a comment.Sep 15 2019, 8:51 PM
In T232877#5494310, @Zoranzoki21 wrote:
In T232877#5494309, @Reedy wrote:

Have you looked at the code for Hooks.php?

https://github.com/wikimedia/mediawiki/blob/master/includes/Hooks.php#L190-L200

No, why?

Have a look and you should get your answer as to what you should be doing

Kizule removed Kizule as the assignee of this task.Feb 19 2020, 7:41 PM
Kizule removed a project: User-Kizule.
DannyS712 claimed this task.Mar 28 2020, 3:22 AM
DannyS712 added a parent task: T246284: Hard deprecate the Revision class.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMar 28 2020, 3:22 AM
gerritbot added a comment.Mar 28 2020, 3:26 AM

Change 584096 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaEvents@master] Replace RevisionInsertComplete hook with RevisionRecordInserted

https://gerrit.wikimedia.org/r/584096

gerritbot added a project: Patch-For-Review.Mar 28 2020, 3:26 AM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.Mar 28 2020, 3:33 AM
In T232877#6006749, @gerritbot wrote:

Change 584096 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaEvents@master] Replace RevisionInsertComplete hook with RevisionRecordInserted

https://gerrit.wikimedia.org/r/584096

One remaining use needs to be removed before hard deprecation
Should the hook deprecation version be 1.31 or 1.35?

Jdforrester-WMF added a comment.Mar 30 2020, 11:14 PM
In T232877#6006751, @DannyS712 wrote:

Should the hook deprecation version be 1.31 or 1.35?

1.31, but it helps to add a comment in the code next to it saying when it was hard-deprecated (1.35), to assist with later clean-up.

gerritbot added a comment.Mar 30 2020, 11:26 PM

Change 584096 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Replace RevisionInsertComplete hook with RevisionRecordInserted

https://gerrit.wikimedia.org/r/584096

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 31 2020, 12:00 AM
Jdforrester-WMF added a comment.Mar 31 2020, 1:30 AM

See also https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/EventBus/+/584762 for a documentation-only reference removal.

DannyS712 added a comment.Mar 31 2020, 1:38 AM
In T232877#6012954, @Jdforrester-WMF wrote:
In T232877#6006751, @DannyS712 wrote:

Should the hook deprecation version be 1.31 or 1.35?

1.31, but it helps to add a comment in the code next to it saying when it was hard-deprecated (1.35), to assist with later clean-up.

Okay. I'll do this in a bit, to avoid merge conflicts or needing to make stacks

gerritbot added a comment.Mar 31 2020, 4:15 PM

Change 584969 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate the RevisionInsertComplete hook

https://gerrit.wikimedia.org/r/584969

DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.Mar 31 2020, 4:17 PM
gerritbot added a comment.Mar 31 2020, 4:52 PM

Change 584969 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the RevisionInsertComplete hook

https://gerrit.wikimedia.org/r/584969

DannyS712 closed this task as Resolved.Mar 31 2020, 4:53 PM
DannyS712 removed a project: Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.27; 2020-04-07); removed MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 31 2020, 5:00 PM
Jdforrester-WMF added a comment.Mar 31 2020, 6:50 PM

Thank you!

DannyS712 added a comment.Mar 31 2020, 7:52 PM
In T232877#6016136, @Jdforrester-WMF wrote:

Thank you!

No problem. I have nothing to do tomorrow, so I should be able to action the other hooks

DannyS712 edited parent tasks, added: T249434: Replace hooks using Revision objects with RevisionRecord; removed: T246284: Hard deprecate the Revision class.Apr 4 2020, 10:03 PM
DannyS712 edited projects, added MediaWiki-Core-Hooks; removed MediaWiki-General.Apr 11 2020, 11:02 AM
DannyS712 moved this task from Untriaged to Hook documentation on the MediaWiki-Core-Hooks board.Apr 11 2020, 11:04 AM
DannyS712 mentioned this in T252156: Increase in "Main slot of revision [number] not found in database!" after deploy of 1.35.0-wmf.31 to all wikis.May 7 2020, 8:07 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.May 27 2020, 8:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits