[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Display the language of the Lexeme in a Statement linking to a Sense
Closed, ResolvedPublic5 Estimated Story Points

Description

Problem:
When looking at a Statement linking to a Sense on another Lexeme it is not clear what language the Lexeme of the references Sense is in. We want to change the display text of the Lexeme in the statement so it becomes clearer.

We want it to look like this example:
Mutter (German) - female parent
(Where German is the label of the language Item of the Lexeme)

Example:
https://www.wikidata.org/wiki/Lexeme:L1#S1-P5972

Screenshots:

Screenshot_20190104_145008.png (1×1 px, 83 KB)

BDD
GIVEN a statement linking to a Sense of a Lexeme
WHEN viewing that statement
THEN the value is displayed in the format "Lemma (Language) - Gloss"

Acceptance criteria:

  • display of statements linking to Senses is changed to new format "Lemma (Language) - Gloss" (e.g. Mutter (German) - female parent)
  • the Language part of "Lemma (Language) - Gloss" depends on the user interface language, so for someone using a German UI it would be Mutter (Deutsch) - weibliches Elternteil eines Menschen

Event Timeline

We do display the Lemma and Gloss if we have it in the interface language or a fallback for it:

Screenshot_20190104_145008.png (1×1 px, 83 KB)

But we do not show the language. And in the screenshot this is really a problem. However I'm not sure if adding the language is the right thing to do for properties linking to Senses other than translation.
Would love some feedback from editors. Poke @KaMan @VIGNERON @Nikki

Adding the language would not solve entirely the problem but I think it would be a good thing nonetheless.

And it would avoid people adding the language by hand as qualifier like on https://www.wikidata.org/wiki/Lexeme:L1183#S1 (which seems unnecessarily redundant to me)

I think displaying language would be valuable.

Ok thanks! :)
Now the question is how to display it. How about this when interface language is English:

  • German: Mutter (female parent)
  • English: mother (female parent)
  • Spanish: madre (female parent)

Other preferences?

Lydia_Pintscher renamed this task from Display of a Sense value is not optimal to Display the language of the Sense in a Statement linking to a Sense.Jan 6 2019, 12:18 PM
Lydia_Pintscher renamed this task from Display the language of the Sense in a Statement linking to a Sense to Display the language of the Lexeme in a Statement linking to a Sense.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher updated the task description. (Show Details)

I think the most important is the lemma, so I would put it first. But I'm not sure on how not mix the gloss and the language:

  • Mutter (German, female parent)

Or maybe better:

  • Mutter (female parent) (German)

The second one may seems a bit overkill but it would be clearer in the case where the gloss itself contains the name of a language:

  • pizza (Italian dish) (Italian)
  • Schwyzerdütsch (Alemannic dialect) (Alemannic)

Compare to:

  • pizza (Italian, Italian dish)
  • Schwyzerdütsch (Alemannic, Alemannic dialect)

I agree with showing the language too.

Personally I already find the sense in brackets as part of the link confusing because I keep thinking someone put the gloss in the lemma. With language fallback, it's even worse, since the language name of the text inside the brackets is shown outside the brackets. I tried moving it inside the brackets but that looks weird because of the superscript.

Using https://www.wikidata.org/wiki/Lexeme:L1?uselang=de as an example since it has fallback languages, the best thing I've been able to come up with is "Mutter (Deutsch) - female parent Englisch" where "Mutter" is the link and "Englisch" is superscript and only shown when the gloss is in another language. That way the gloss is clearly separate from the lemma, the lemma and language are displayed in the same way that we use for monolingual text and the gloss isn't in brackets so the fallback language doesn't look weird.

If there is strong need for bracket version I would go for:

  • Mutter (Deutsch) (female parent)

but I agree with above Nikki proposition "Mutter (Deutsch) - female parent Englisch". It is better than doubling brackets.

Thanks!
Any reason you prefer the language not to be first? I fear having two sets of brackets will be pretty confusing.

Indeed, it's a bit strange, without two brackets, it could be

  • pizza (Italian: Italian dish)

or

  • pizza (Italian / Italian dish)

or

  • pizza (Italian dish)<sup>Italian</sup>

But for me the lemma should stay first, that's the most valuable information (which in most cultures is put first).
And the separator should be crystal clear, it shouldn't be a character that could appear in the gloss.

The double brackets is overkill, the idea was to avoid confusion, anything else making the distinction clear is fine by me.

But for me the lemma should stay first, that's the most valuable information (which in most cultures is put first).

Ok. Makes sense.

Final verdict from bug triage hour: Mutter (German) - female parent
Where German is the label of the language Item of the Lexeme

karapayneWMDE set the point value for this task to 5.
karapayneWMDE moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.

Task breakdown notes:

  • This would be added to the SenseIdHtmlFormatter; we already have the full lexeme data available there, so we can access the language as well.
  • We will need to change the wikibaselexeme-senseidformatter-layout message; to ensure that old translations don’t result in broken layout, we should add the language as a new parameter $3, and not change the meaning of $1 (lemmas) and $2 (gloss).

What should happen if the lexeme has no gloss in the user language or any fallback language? Currently, we fall back to showing the sense ID in that case (T200983#4518320), not even the lexeme lemmas. Do we want to keep it that way?

Change 871182 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add EntityIdLabelFormatterFactory to service container

https://gerrit.wikimedia.org/r/871182

Change 871183 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Get EntityIdLabelFormatterFactory from service container

https://gerrit.wikimedia.org/r/871183

Change 871184 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Inject service into EntityIdLabelFormatterFactory

https://gerrit.wikimedia.org/r/871184

(The above changes don’t implement the feature yet, it’s just preparation so far. I have a local change for WikibaseLexeme, but might wait for the answer to T207392#8488710 before I push it.)

(Edit: I cleaned up pushed the WikibaseLexeme changes after all, otherwise I won’t remember what I was doing when I come back from the holidays ^^ for now, they leave senses without glosses unaffected, i.e. they’re still formatted using only the sense ID.)

Change 871229 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add strict types to SenseIdHtmlFormatter

https://gerrit.wikimedia.org/r/871229

Change 871230 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add strict types to SenseIdTextFormatter

https://gerrit.wikimedia.org/r/871230

Change 871231 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add lexeme language to formatted sense ID

https://gerrit.wikimedia.org/r/871231

Change 871229 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add strict types to SenseIdHtmlFormatter

https://gerrit.wikimedia.org/r/871229

Change 871230 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add strict types to SenseIdTextFormatter

https://gerrit.wikimedia.org/r/871230

Change 871182 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add EntityIdLabelFormatterFactory to service container

https://gerrit.wikimedia.org/r/871182

Change 871183 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Get EntityIdLabelFormatterFactory from service container

https://gerrit.wikimedia.org/r/871183

What should happen if the lexeme has no gloss in the user language or any fallback language? Currently, we fall back to showing the sense ID in that case (T200983#4518320), not even the lexeme lemmas. Do we want to keep it that way?

I would say yes.

Change 871184 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Inject service into EntityIdLabelFormatterFactory

https://gerrit.wikimedia.org/r/871184

What should happen if the lexeme has no gloss in the user language or any fallback language? Currently, we fall back to showing the sense ID in that case (T200983#4518320), not even the lexeme lemmas. Do we want to keep it that way?

The lemmas should always be displayed. They are independent of the UI language so shouldn't depend on successful language fallback. I already made T258391 ages ago for that problem.

For the gloss itself, I made three suggestions in that ticket (one of which was to show the sense ID) and I don't really care which is used.

Change 871231 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add lexeme language to formatted sense ID

https://gerrit.wikimedia.org/r/871231

Arian_Bozorg subscribed.

This looks good to me!

Thanks so much :)