[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T200983

Language fallbacks for referenced Senses in statements
Closed, ResolvedPublic
Actions

Assigned To
Addshore
Authored By
Lydia_Pintscher
Aug 2 2018, 8:55 AM
Tags
Referenced Files
F25188114: image.png
Aug 20 2018, 10:25 PM
F25188140: image.png
Aug 20 2018, 10:25 PM
Subscribers
Addshore
Bugreporter
gerritbot
Ladsgroup
Lucas_Werkmeister_WMDE
Lydia_Pintscher
• RazShuty
WMDE-leszek

Description

As a reader I want to see the best Gloss available for a Sense in order to understand what a Sense means.

Problem:
We don't have Glosses for a Sense in all the languages but we still want to show something better than the ID if possible.

BDD
GIVEN a statement that has a Sense as value
AND the Sense does not have a Gloss in the current interface language
THEN the Gloss for the next language in the Wikimedia language fallback chain is shown
AND the language is shown in superscript (except for language variants, see T174318: Don’t display language fallback indicators for variant fallbacks)
AND if none can be found the ID of the Sense is shown

Acceptance criteria:

  • fallback is indicated to the user in the same way as fallback for labels (superscript of the language name)
  • fallback is in place if the Sense does not have a Gloss in the current interface language

Details

SubjectRepoBranchLines +/-
SenseIdTextFormatter fallback to SenseIdmediawiki/extensions/WikibaseLexememaster+8 -6
Add language fallback to SenseIdHtmlFormattermediawiki/extensions/WikibaseLexememaster+251 -52
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lydia_Pintscher created this task.Aug 2 2018, 8:55 AM
Lydia_Pintscher moved this task from incoming to features/bugs for next release (Senses) on the Wikidata Lexicographical data board.Aug 2 2018, 8:57 AM
Bugreporter subscribed.Aug 2 2018, 2:31 PM

Before T89213: Allow fallback to any language is fixed it may be common to see only Qid as many senses may not have English translation.

Lucas_Werkmeister_WMDE mentioned this in T196264: View a referenced Sense.Aug 7 2018, 11:15 AM
Lucas_Werkmeister_WMDE mentioned this in T196269: Select a Sense as value in statement.Aug 7 2018, 11:29 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Aug 7 2018, 12:02 PM
Ladsgroup claimed this task.Aug 14 2018, 3:41 PM
Ladsgroup added a project: Wikidata-Senses-Iteration3.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 14 2018, 3:41 PM
Ladsgroup moved this task from To Do to Doing on the Wikidata-Senses-Iteration3 board.Aug 14 2018, 3:41 PM
Ladsgroup removed Ladsgroup as the assignee of this task.Aug 15 2018, 9:17 PM
Ladsgroup moved this task from Doing to To Do on the Wikidata-Senses-Iteration3 board.
Ladsgroup subscribed.

I tried but couldn't finish it, someone else can pick this up. (Unlicking the cookie)

Addshore claimed this task.Aug 20 2018, 12:24 PM
Addshore moved this task from To Do to Doing on the Wikidata-Senses-Iteration3 board.
Restricted Application added a project: User-Addshore. · View Herald TranscriptAug 20 2018, 12:24 PM
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.Aug 20 2018, 12:24 PM
gerritbot subscribed.Aug 20 2018, 3:13 PM

Change 454036 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Add language fallback to SenseIdHtmlFormatter

https://gerrit.wikimedia.org/r/454036

gerritbot added a project: Patch-For-Review.Aug 20 2018, 3:13 PM
Addshore added a comment.Aug 20 2018, 3:14 PM

The patch only alters the HTML output which as far as I can tell meets the acceptance criteria of this ticket.
If we also want to change the text formatting of the sense value then either we need to spec what that should look like in this ticket or open another ticket.
I'm not actually sure where the text formatter is used..

Addshore moved this task from Doing to Peer Review on the Wikidata-Senses-Iteration3 board.Aug 20 2018, 3:14 PM
Addshore moved this task from Back Burner 🏛️ to Active 🚁 on the User-Addshore board.
Addshore mentioned this in rEWLE0d494a506733: Add language fallback to SenseIdHtmlFormatter.Aug 20 2018, 3:16 PM
Lucas_Werkmeister_WMDE subscribed.Aug 20 2018, 3:37 PM

I think the text formatter is used when you start editing the value, for example, to populate the input.

Lucas_Werkmeister_WMDE mentioned this in T201000: Show Gloss in entity selector when entering Sense as a value in a statement.Aug 20 2018, 3:48 PM
Addshore mentioned this in rEWLE5f0485ee29b5: Add language fallback to SenseIdHtmlFormatter.Aug 20 2018, 10:21 PM
Addshore added a comment.Aug 20 2018, 10:25 PM

Currently the formatter formats the values with fallback as the following:

image.png (106×224 px, 3 KB)

If I just shove the current version of the fallback indicator in the brackets we end up with something like this:

image.png (160×236 px, 4 KB)

Thoughts by @Lydia_Pintscher & WMDE-Design ?

Addshore mentioned this in rEWLEb397461d00dc: Add language fallback to SenseIdHtmlFormatter.Aug 20 2018, 10:33 PM
gerritbot added a comment.Aug 21 2018, 11:22 AM

Change 454244 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] SenseIdTextFormatter fallback to SenseId

https://gerrit.wikimedia.org/r/454244

WMDE-leszek added a comment.Aug 21 2018, 11:25 AM

Decision: for now, with the former.

Addshore mentioned this in rEWLE9ffcfcee0cde: Add language fallback to SenseIdHtmlFormatter.Aug 21 2018, 11:26 AM
WMDE-leszek added a comment.Aug 21 2018, 11:26 AM

Decision 2: when there is no gloss in fallback languages, display the sense ID.

Addshore mentioned this in rEWLE99f82eea47d1: SenseIdTextFormatter fallback to SenseId.Aug 21 2018, 11:26 AM
Addshore mentioned this in rEWLE3fa6689070c5: SenseIdTextFormatter fallback to SenseId.
gerritbot added a comment.Aug 21 2018, 12:08 PM

Change 454036 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add language fallback to SenseIdHtmlFormatter

https://gerrit.wikimedia.org/r/454036

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Senses-Iteration3 board.Aug 21 2018, 12:31 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 21 2018, 1:01 PM
Lydia_Pintscher closed this task as Resolved.Aug 22 2018, 9:07 AM
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Senses-Iteration3 board.

\o/

Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Aug 29 2018, 7:40 AM
Addshore mentioned this in rEWLEd930eb9bc568: SenseIdTextFormatter fallback to SenseId.Nov 15 2018, 3:38 PM
Lucas_Werkmeister_WMDE mentioned this in rEWLEb530d28333ad: SenseIdTextFormatter fallback to SenseId.Nov 15 2018, 3:51 PM
gerritbot added a comment.Dec 3 2018, 1:39 PM

Change 454244 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] SenseIdTextFormatter fallback to SenseId

https://gerrit.wikimedia.org/r/454244

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 3 2018, 2:00 PM
Lucas_Werkmeister_WMDE mentioned this in T207392: Display the language of the Lexeme in a Statement linking to a Sense.Dec 23 2022, 3:52 PM
Lucas_Werkmeister_WMDE mentioned this in T258391: Lemma not shown when linking senses unless the sense has a definition in the current language.Jan 13 2023, 5:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits