[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T162936

Improve developer happiness in reading web maintained extensions
Closed, ResolvedPublic
Actions

Description

There are various tasks open relating to our tooling (see subtasks), test coverage and documentation. Let's have a focused effort to address them.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJdlrobsonT195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
 ResolvedJdlrobsonT171000 [EPIC] Minerva works independently of MobileFrontend
 ResolvedJdlrobsonT166905 [EPIC] Talk about and improve our frontend code architecture
 DeclinedNoneT144402 Extract MobileFrontend UI components to an external well documented library
 ResolvedJdlrobsonT162936 Improve developer happiness in reading web maintained extensions
 ResolvedJdlrobsonT158236 Make `npm run doc` work again for Page Previews
 ResolvedABorbaWMFT162827 Tooling: MobileFrontend should check SVGS committed have been optimised.
 DuplicateJdlrobsonT138071 [EPIC/WIP] Fast frontend isolated unit testing
 Resolved• NiedzielskiT151340 [2hrs] Add missing @covers statements in MobileFrontend and MinervaNeue PHPUnit tests
 ResolvedJdlrobsonT160061 Minify assets via build step using node tooling
 ResolvedJdlrobsonT152252 PageImages maintenance script should be more flexible
 DuplicateNoneT160359 Upgrade RelatedArticles automated browser tests to Selenium 3
 Resolved• JhernandezT146917 [Spike, 4hrs] What does jsdoc not support that jsduck does
 DuplicatepmiazgaT143330 Update documentation of Reading Web contribution process
 DuplicateNoneT148973 Identify our browser test coverage
 StalledNoneT158980 [EPIC] Generate compiled assets from continuous integration
 Resolved• JhernandezT167181 Create bot that automatically rebases and rebuilds patches to master
 DeclinedNoneT199004 RFC: Add a frontend build step to skins/extensions to our deploy process
 DeclinedNoneT257061 Evaluate the workflows and workload of managing a Node package repository
 StalledNoneT257068 Draft: RFC: Evaluate alternative Node package managers for improved package security
 OpenNoneT257072 Determine Node package auditing workflows
 OpenNoneT315929 Reconsider build step in Popups and MobileFrontend
 ResolvedBUG REPORTovasilevaT329901 [unplanned] Officially drop ES5 support for page previews
 OpenNoneT379793 [EPIC] Remove Webpack from MobileFrontend
 OpenNoneT379822 Stop using webpack in mobile.editor.overlay module
 ResolvedJdlrobsonT155802 [EPIC] Build entire mobile.startup module using webpack bundler
 DuplicateSpikeNoneT156188 [Spike] Evaluate whether JavaScript RL modules without side effects loaded on startup should be bundled into a single resource
 ResolvedJdrewniakT153473 [Spike, 8hrs] How do we organize and manage our ResourceLoader modules?
 DeclinedNoneT167713 [EPIC] MinervaNeue's starter modules should be grouped by page not feature
 ResolvedJdlrobsonT173454 Lazy loading code should be skin agnostic
 DeclinedNoneT190699 Repackage Minerva's JavaScript code with webpack
 Resolved• JhernandezT156333 Technical: Use bundler to generate Popups JavaScript code
 ResolvedJdrewniakT199452 Introduce webpack config/node-qunit and port ModuleLoader
 ResolvedpmiazgaT202742 [subtask] Add bundlesize tests
 ResolvedJdrewniakT203100 Continue webpack + test transition of mobile.startup
 ResolvedJdlrobsonT202026 Report client-side JavaScript errors in MobileFrontend practically
 ResolvedJdrewniakT206169 Complete webpack migration of mobile.startup
 Resolved• JhernandezT149201 Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web code
 Resolved• bmansurovT149202 Migrate RelatedArticles to eslint
 DeclinedNoneT107588 EPIC: Detect and prevent UI regressions
 ResolvedSpikeovasilevaT236722 [Spike, 10hrs] Investigate automated visual regression tools
 Resolved• JhernandezT160056 Add disabling comment syntax to resource-modules linter
 DeclinedNoneT143847 Spike [4hrs]: Identify problematic Hogan templates when run as Mustache
 DeclinedNoneT146312 [Spike 4hrs] phpcs should complain when we use the global keyword without explicitly saying its okay
 DeclinedNoneT162256 [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions
 ResolvedzeljkofilipinT158052 Set up Selenium tests in Node.js for RelatedArticles extension
 ResolvedzeljkofilipinT164024 Rewrite Related pages browser tests in Node.js
 DuplicateJdlrobsonT160238 Rewrite MobileFrontend and Page previews automated browser tests in Node.js
 ResolvedJdlrobsonT177262 [subtask] Rewrite Page Previews browser tests in Node.js
 ResolvedzeljkofilipinT179546 Popups Selenium tests daily targeting beta cluster
 ResolvedzeljkofilipinT179406 Documentation for selenium-RelatedArticles-jessie
 ResolvedzeljkofilipinT171847 Create Jenkins job that runs RelatedArticles Selenium tests daily
 DeclinedNoneT174018 Port Minerva's 7 Ruby-based browser tests to Selenium Node.js
 ResolvedJdlrobsonT190710 Minerva Ruby and Node.js browser tests running side by side
 ResolvedNoneT179190 Run Selenium Cucumber tests in CI
 ResolvedawightT199116 Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests
 DuplicateLegoktmT225330 Commit package-lock.json files everywhere
 ResolvedhasharT229033 wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10
 ResolvedzeljkofilipinT232495 selenium-daily-beta-CirrusSearch is broken
 ResolvedhasharT229065 Quibble extension selenium test fails with: gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable.
 OpenNoneT199939 Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature
 ResolvedPRODUCTION ERRORJdlrobsonT219920 CI tests disabled: Steps that require login are disabled and should be restored.
 ResolvedJdlrobsonT220658 Minerva browser tests must be configured to run on the mobile domain
 ResolvedJdrewniakT220659 Enable a MobileFrontend daily Selenium build
 DeclinedNoneT221579 Port "Page actions menu when anonymous.Receive notification message - Watchlist Icon" browser test to Node.js from Ruby
 OpenNoneT245250 Review MinervaNeue Selenium tests
 ResolvedNoneT246881 +2 for Edtadros for mediawiki/skins/MinervaNeue
 ResolvedzeljkofilipinT251543 MinervaNeue Selenium tests fail when targeting MediaWiki-Docker
 ResolvedEdtadrosT177261 Remove QuickSurveys browser tests written in Ruby
 DeclinedNoneT177260 Rewrite disabled MobileFrontend browser tests to phpunit tests and Node.js browser tests
 ResolvedJdlrobsonT181509 [Spike 8hrs] Document missing (?) features of the Node.js automated browser testing stack
 ResolvedpmiazgaT163882 Migrate experimental CI job mwext-MobileFrontend-npm-run-lint-modules to stable
 DuplicateNoneT151333 Proof of concept to generate coverage report of some Wikimedia mediawiki extensions
 DeclinedNoneT165176 Don't use RequestContext::getMain() in MinervaNeue UnitTests
 ResolvedphuedxT165991 Remove sidebar code from RelatedArticles extension
 Resolved• NirzarT164765 RelatedArticles max number of articles limit should be configurable
 ResolvedABorbaWMFT165036 Refactor rendering code in src/renderer.js for readability and testability
 ResolvedJdlrobsonT168384 Fix codesniffer sniffs disabled with the update to 0.9
 DeclinedNoneT171209 Improve Minerva skin documentation
 ResolvedNoneT174598 Reading web extensions are incompatible with QUnit 2
 ResolvedJdlrobsonT173981 MobileFrontend should use ES5 and discourage jQuery usage

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2017, 7:06 PM
Jdlrobson added a project: Epic.Apr 13 2017, 7:06 PM
Jdlrobson added a subtask: T158236: Make `npm run doc` work again for Page Previews.
Jdlrobson added subtasks: T162827: Tooling: MobileFrontend should check SVGS committed have been optimised., T138071: [EPIC/WIP] Fast frontend isolated unit testing, T151340: [2hrs] Add missing @covers statements in MobileFrontend and MinervaNeue PHPUnit tests.Apr 13 2017, 7:16 PM
Jdlrobson renamed this task from Improve and upgrade Reading web tooling infrastructure to Developer happiness.Apr 13 2017, 7:25 PM
Jdlrobson added subtasks: T160061: Minify assets via build step using node tooling, T152252: PageImages maintenance script should be more flexible, T160359: Upgrade RelatedArticles automated browser tests to Selenium 3, T160238: Rewrite MobileFrontend and Page previews automated browser tests in Node.js, T146917: [Spike, 4hrs] What does jsdoc not support that jsduck does, T143330: Update documentation of Reading Web contribution process.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subtask: T148973: Identify our browser test coverage.
Jdlrobson added subtasks: T158980: [EPIC] Generate compiled assets from continuous integration, T155802: [EPIC] Build entire mobile.startup module using webpack bundler.Apr 13 2017, 7:48 PM
Jdlrobson renamed this task from Developer happiness to Improve developer happiness.Apr 13 2017, 11:04 PM
Jdlrobson added a subtask: T149201: Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web code.Apr 13 2017, 11:15 PM
Jdlrobson added a subtask: T107588: EPIC: Detect and prevent UI regressions.Apr 13 2017, 11:24 PM
Jdlrobson added a subtask: T160056: Add disabling comment syntax to resource-modules linter.Apr 17 2017, 4:15 PM
• Jrbranaa subscribed.Apr 17 2017, 7:06 PM
Jdlrobson added a subtask: T143847: Spike [4hrs]: Identify problematic Hogan templates when run as Mustache.Apr 17 2017, 11:07 PM
Jdlrobson changed the status of subtask T143847: Spike [4hrs]: Identify problematic Hogan templates when run as Mustache from Open to Stalled.
Jdlrobson added a subtask: T146312: [Spike 4hrs] phpcs should complain when we use the global keyword without explicitly saying its okay.Apr 17 2017, 11:36 PM
• MZMcBride subscribed.Apr 17 2017, 11:37 PM
Jdlrobson added a subtask: T156188: [Spike] Evaluate whether JavaScript RL modules without side effects loaded on startup should be bundled into a single resource.Apr 17 2017, 11:48 PM
Jdlrobson triaged this task as High priority.Apr 20 2017, 11:10 PM
Jdlrobson added a subtask: T162256: [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions.Apr 21 2017, 4:51 PM
• Jhernandez closed subtask T160056: Add disabling comment syntax to resource-modules linter as Resolved.Apr 26 2017, 10:20 AM
• Jhernandez added a subtask: T163882: Migrate experimental CI job mwext-MobileFrontend-npm-run-lint-modules to stable.Apr 26 2017, 10:42 AM
Jdlrobson changed the status of subtask T160238: Rewrite MobileFrontend and Page previews automated browser tests in Node.js from Open to Stalled.Apr 27 2017, 6:04 PM
Jdlrobson moved this task from Epics/Goals to Upcoming on the Web-Team-Backlog board.Apr 27 2017, 8:29 PM
• bmansurov subscribed.Apr 28 2017, 10:23 PM

Do we want to work on the whole epic next sprint, or do we want to pull some tasks from it? The epic looks big for one sprint.

Jdlrobson added a subscriber: MBinder_WMF.Apr 28 2017, 11:11 PM

No this epic won't get pulled into the sprints and we won't finish it this sprint. I'm just putting it here to help me plan subtasks.
All will become clear when the new sprint board is setup which I'm waiting for @MBinder_WMF to do (because forever sprints etc)

Jdlrobson added a subtask: T151333: Proof of concept to generate coverage report of some Wikimedia mediawiki extensions.May 1 2017, 6:02 PM
Jdlrobson changed the status of subtask T155802: [EPIC] Build entire mobile.startup module using webpack bundler from Open to Stalled.May 2 2017, 10:43 PM
Jdlrobson moved this task from Upcoming to Epics/Goals on the Web-Team-Backlog board.May 4 2017, 6:15 PM
Jdlrobson closed subtask T160061: Minify assets via build step using node tooling as Resolved.May 16 2017, 9:44 AM
Jdlrobson closed subtask T162827: Tooling: MobileFrontend should check SVGS committed have been optimised. as Resolved.May 16 2017, 9:49 AM
• Jhernandez closed subtask T163882: Migrate experimental CI job mwext-MobileFrontend-npm-run-lint-modules to stable as Resolved.May 23 2017, 4:26 PM
pmiazga added a subtask: T165176: Don't use RequestContext::getMain() in MinervaNeue UnitTests.May 24 2017, 3:46 PM
• bmansurov closed subtask T149201: Remove jshint and jscs in favor of eslint (linting and code style) in Reading Web code as Resolved.May 25 2017, 4:32 PM
Jdlrobson added a subtask: T165991: Remove sidebar code from RelatedArticles extension.May 26 2017, 5:12 PM
Jdlrobson changed the status of subtask T165991: Remove sidebar code from RelatedArticles extension from Open to Stalled.May 26 2017, 5:41 PM
Jdlrobson added a subtask: T165036: Refactor rendering code in src/renderer.js for readability and testability.May 26 2017, 10:06 PM
Jdlrobson closed subtask T158236: Make `npm run doc` work again for Page Previews as Resolved.May 30 2017, 11:27 PM
phuedx closed subtask T146917: [Spike, 4hrs] What does jsdoc not support that jsduck does as Resolved.Jun 9 2017, 9:28 AM
Jdlrobson changed the status of subtask T162256: [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions from Open to Stalled.Jul 3 2017, 10:11 PM
Jdlrobson changed the status of subtask T165991: Remove sidebar code from RelatedArticles extension from Stalled to Open.Jul 6 2017, 10:14 PM
Jdlrobson closed subtask T143847: Spike [4hrs]: Identify problematic Hogan templates when run as Mustache as Declined.Jul 7 2017, 11:05 PM
pmiazga mentioned this in T168384: Fix codesniffer sniffs disabled with the update to 0.9.Jul 12 2017, 9:09 PM
pmiazga added a subtask: T168384: Fix codesniffer sniffs disabled with the update to 0.9.
pmiazga added a subtask: T170579: Re-enable codesniffer sniffs disabled in MobileFrontend.Jul 13 2017, 2:37 PM
pmiazga added a subtask: T170580: Re-enable codesniffer sniffs disabled in TextExtracts.Jul 13 2017, 2:45 PM
pmiazga added a subtask: T170583: Re-enable codesniffer sniffs disabled in PageImages.Jul 13 2017, 2:53 PM
pmiazga closed subtask T170583: Re-enable codesniffer sniffs disabled in PageImages as Declined.Jul 13 2017, 2:58 PM
pmiazga reopened subtask T170583: Re-enable codesniffer sniffs disabled in PageImages as Open.Jul 13 2017, 3:04 PM
pmiazga added a subtask: T170587: Re-enable codesniffer sniffs disabled in BetaFeatures.Jul 13 2017, 3:09 PM
pmiazga added a subtask: T170589: Re-enable codesniffer sniffs disabled in RelatedArticles.Jul 13 2017, 3:12 PM
Jdlrobson closed subtask T168384: Fix codesniffer sniffs disabled with the update to 0.9 as Resolved.Jul 14 2017, 11:44 PM
pmiazga added a subtask: T171209: Improve Minerva skin documentation.Jul 20 2017, 7:38 PM
Jdlrobson closed subtask T171209: Improve Minerva skin documentation as Declined.Jul 20 2017, 10:16 PM
zeljkofilipin changed the status of subtask T162256: [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions from Stalled to Open.Jul 24 2017, 4:13 PM
Jdlrobson closed subtask T170589: Re-enable codesniffer sniffs disabled in RelatedArticles as Resolved.Jul 25 2017, 6:41 PM
phuedx closed subtask T165991: Remove sidebar code from RelatedArticles extension as Resolved.Aug 22 2017, 1:49 PM
Jdlrobson changed the status of subtask T160238: Rewrite MobileFrontend and Page previews automated browser tests in Node.js from Stalled to Open.Aug 24 2017, 1:45 PM
Jdlrobson added a subtask: T174598: Reading web extensions are incompatible with QUnit 2.Sep 1 2017, 3:17 PM
• bmansurov closed subtask T165176: Don't use RequestContext::getMain() in MinervaNeue UnitTests as Declined.Sep 6 2017, 4:48 PM
Jdlrobson added a subtask: T173981: MobileFrontend should use ES5 and discourage jQuery usage.Sep 6 2017, 7:15 PM
• bmansurov closed subtask T174598: Reading web extensions are incompatible with QUnit 2 as Resolved.Sep 8 2017, 7:41 PM
Jdlrobson closed subtask T170580: Re-enable codesniffer sniffs disabled in TextExtracts as Resolved.Nov 30 2017, 10:28 PM
Pppery edited subtasks, added: T177810: Fix up PHPCS violations that are excluded in .phpcs.xml; removed: T170589: Re-enable codesniffer sniffs disabled in RelatedArticles, T170587: Re-enable codesniffer sniffs disabled in BetaFeatures, T170583: Re-enable codesniffer sniffs disabled in PageImages, T170580: Re-enable codesniffer sniffs disabled in TextExtracts, T170579: Re-enable codesniffer sniffs disabled in MobileFrontend.Dec 21 2017, 3:38 PM
• bmansurov unsubscribed.Dec 22 2017, 9:46 PM
• Niedzielski closed subtask T151340: [2hrs] Add missing @covers statements in MobileFrontend and MinervaNeue PHPUnit tests as Resolved.Feb 2 2018, 1:00 PM
Jdlrobson closed subtask T146312: [Spike 4hrs] phpcs should complain when we use the global keyword without explicitly saying its okay as Declined.Feb 6 2018, 7:08 PM
Jdlrobson closed subtask T173981: MobileFrontend should use ES5 and discourage jQuery usage as Resolved.Mar 2 2018, 9:22 PM
ovasileva closed subtask T152252: PageImages maintenance script should be more flexible as Resolved.Apr 3 2018, 5:56 PM
• Niedzielski closed subtask T165036: Refactor rendering code in src/renderer.js for readability and testability as Resolved.Apr 11 2018, 5:21 PM
Jdlrobson renamed this task from Improve developer happiness to Improve developer happiness in reading web maintained extensions.Jul 9 2018, 4:27 PM
Jdlrobson closed this task as Resolved.
Jdlrobson claimed this task.
Jdlrobson removed a subtask: T177810: Fix up PHPCS violations that are excluded in .phpcs.xml.

I'm going to resolve this as this card seems to have run its course.
There are epics for the remaining work (T174018, T162256, T107588, T158980, T195473) and epics with only epics for subtasks are not too useful.

MBinder_WMF moved this task from Epics/Goals to Readers-Web-Kanbanana-Board-2018-19-Q1 on the Web-Team-Backlog board.Aug 23 2018, 12:01 AM
MBinder_WMF edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.
Jdlrobson changed the status of subtask T155802: [EPIC] Build entire mobile.startup module using webpack bundler from Stalled to Open.Aug 28 2018, 10:08 PM
Jdlrobson closed subtask T155802: [EPIC] Build entire mobile.startup module using webpack bundler as Resolved.Oct 23 2018, 1:08 AM
• Niedzielski changed the status of subtask T158980: [EPIC] Generate compiled assets from continuous integration from Open to Stalled.Mar 29 2019, 6:50 PM
Jdlrobson closed subtask T162256: [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions as Declined.Aug 1 2019, 8:22 PM
Jdlrobson closed subtask T107588: EPIC: Detect and prevent UI regressions as Declined.Aug 24 2021, 9:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits