8000 Macroify PlaySfxGeneral calls: introduce `SFX_PLAY_CENTERED` and `SFX_PLAY_AT_POS` by Dragorn421 · Pull Request #2633 · zeldaret/oot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Macroify PlaySfxGeneral calls: introduce SFX_PLAY_CENTERED and SFX_PLAY_AT_POS #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2025
Merged

Macroify PlaySfxGeneral calls: introduce SFX_PLAY_CENTERED and SFX_PLAY_AT_POS #2633

merged 2 commits into from
Jun 15, 2025

Conversation

Dragorn421
Copy link
Collaborator

With this there are only 18 calls to Audio_PlaySfxGeneral left not done through these macros!
SFX_PLAY_CENTERED is used 328 times and SFX_PLAY_AT_POS 184 times

I took the macro names and parameter ordering from z_lib's Sfx_PlaySfxCentered and Sfx_PlaySfxAtPos

@Dragorn421 Dragorn421 added the One approval Has one approval, can be merged in 48 hours if nothing else comes up label Jun 14, 2025
@fig02 fig02 merged commit fd1ea6b into zeldaret:main Jun 15, 2025
1 check passed
@Dragorn421 Dragorn421 deleted the macroify_playsfxgeneral branch June 16, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngheloAlf AngheloAlf AngheloAlf approved these changes

Assignees
No one assigned
Labels
One approval Has one approval, can be merged in 48 hours if nothing else comes up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dragorn421 @AngheloAlf @fig02
0