8000 Replace wanakana by Kuuuube · Pull Request #1910 · yomidevs/yomitan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace wanakana #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Mar 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
c6672f1
Replace wanakana toKana
Kuuuube Mar 23, 2025
f892e61
Add katakana dict
Kuuuube Mar 24, 2025
4ab0c91
Change katakana to uppercase
Kuuuube Mar 24, 2025
a098896
Fix some wrong katakana
Kuuuube Mar 24, 2025
e0fa582
Fix more wrong katakana
Kuuuube Mar 24, 2025
e6e8b22
Fix remaining bad katakana
Kuuuube Mar 24, 2025
ccf3d92
Remove katakana dict in favor of converting with convertHiraganaToKat…
Kuuuube Mar 24, 2025
2bebbab
Replace wanakana.toHiragana
Kuuuube Mar 24, 2025
d67c727
Note reason for lowercase
Kuuuube Mar 24, 2025
9584ab5
Remove redundant toUpperCase
Kuuuube Mar 24, 2025
b232516
Add HIRAGANA_TO_ROMAJI dict
Kuuuube Mar 24, 2025
080414d
Replace wanakana.toRomaji
Kuuuube Mar 24, 2025
8d2a93a
Add test for っッ
Kuuuube Mar 24, 2025
8b5559d
Fix ordering of HIRAGANA_TO_ROMAJI dict
Kuuuube Mar 24, 2025
c8b8051
Rename dicts file
Kuuuube Mar 24, 2025
ffff9ab
Remove wanakana package
Kuuuube Mar 24, 2025
04f4f10
Add convertToHiragana
Kuuuube Mar 24, 2025
3730c5b
Add special case for んい
Kuuuube Mar 24, 2025
1283a7f
Fix n hiragana to romaji
Kuuuube Mar 24, 2025
b1cb294
Fix ゐ and ゑ
Kuuuube Mar 24, 2025
3622b9a
Merge remote-tracking branch 'upstream/master' into replace-wanakana
Kuuuube Mar 24, 2025
3e419a0
Remove IMEMode option from convertToKanaIME
Kuuuube Mar 24, 2025
90a3997
Remove unused っ letter in HIRAGANA_TO_ROMAJI
Kuuuube Mar 24, 2025
b404b57
Fix small kana romaji
Kuuuube Mar 24, 2025
0dc92a5
Remove xtsu and add special case for っん
Kuuuube Mar 24, 2025
2cfcee8
Add explanation for n -> ん handling
Kuuuube Mar 24, 2025
19e98d8
Add single n handling and put single n comment in convertToKanaIME
Kuuuube Mar 24, 2025
ef87aa3
Make convertToKanaIME stateless to allow for easier testing
Kuuuube Mar 24, 2025
575e70a
Add test for convertToKanaIME
Kuuuube Mar 24, 2025
db1af0d
Add fillSokuonGaps
Kuuuube Mar 24, 2025
7e53bbd
Add more tests for convertToKanaIME
Kuuuube Mar 24, 2025
17d81b5
Fix bad test case
Kuuuube Mar 24, 2025
c529405
Add missing tsu
Kuuuube Mar 24, 2025
6a1da0a
Add sokuon tests to convertToRomaji
Kuuuube Mar 24, 2025
6349954
Remove '.js' from import
Kuuuube Mar 24, 2025
3e62759
Put nn at top of length 2 list
Kuuuube Mar 24, 2025
377ac96
Prevent long strings of n from getting messed up
Kuuuube Mar 24, 2025
5175c46
Add test for repeated n
Kuuuube Mar 24, 2025
273c263
Mention reference for ROMAJI_TO_HIRAGANA
Kuuuube Mar 24, 2025
57a051c
Fix bad array index
Kuuuube Mar 24, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ Yomitan uses several third-party libraries to function.
| dexie-export-import | 4.0.7 | Apache-2.0 | git+https://github.com/dexie/Dexie.js.git |
| yomitan-handlebars | 1.0.0 | MIT | n/a |
| parse5 | 7.1.2 | MIT | git://github.com/inikulin/parse5.git |
| wanakana | 5.3.1 | MIT | git+ssh://git@github.com/WaniKani/WanaKana.git |
| hangul.js | 0.2.6 | MIT | git+https://github.com/e-/Hangul.js.git |

## Attribution
Expand Down
3 changes: 1 addition & 2 deletions benches/jsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
"firefox-webext-browser",
"handlebars",
"jszip",
"parse5",
"wanakana"
"parse5"
],
"lib": [
"ES2022",
Expand Down
18 changes: 0 additions & 18 deletions dev/lib/wanakana.js

This file was deleted.

4 changes: 3 additions & 1 deletion ext/js/display/search-display-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,9 @@ export class SearchDisplayController {
*/
_searchTextKanaConversion(element, event) {
if (!this._wanakanaEnabled || event.isComposing) { return; }
convertToKanaIME(element);
const {kanaString, newSelectionStart} = convertToKanaIME(element.value, element.selectionStart);
element.value = kanaString;
element.setSelectionRange(newSelectionStart, newSelectionStart);
}

/**
Expand Down
Loading
Loading
0