Replace wanakana #1910
Merged
Replace wanakana #1910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1910 will not alter performanceComparing Summary
|
|
Can you update the PR description for why you're replacing wanakana? |
jamesmaa
reviewed
Mar 24, 2025
Added a bit of explanation. |
jamesmaa
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back
2B8F
later.
Fully replaces wanakana.
Wanakana hasn't been updated for about 2 years now even though there are bugs in it that should be fixed. We cannot depend on them to do anything about any issues in it.
Yomitan barely uses any of wanakana's features. Simple converting back and forth between kana and romaji doesn't warrant pulling in this package. It should help to have more fine grained control over these features.
Some issues with wanakana:
wanakana.bindbreaks in some cases when using an IME due to it not respecting composing. Which led to removing that part of wanakana (Fix wanakana breaking IME input when hitting a conversion containing latin characters #1875).Wanakana's kana conversion cannot handle duplicate sokuons. For example:
ttttttttttsuconverts tottttttttっつinstead ofっっっっっっっっっつ. This can create issues when parsing text that is pasted in or grabbed from clipboard monitor.Wacky handling of
n->んvsnn->ん. Wanakana bind (which we can't use) saysnnnshould beんnbut wanakana's other converters say it should beんんん. This also causes issues when the user is typing something and goes back to change part of it. Even inIMEMode, wanakana's kana converter doesn't handle this right (though they claim it matches wanakana.bind, it doesnt).For example: If the user accidentally types
あのinstead ofなのthen if they try to typenaのwithout removing theのit will convert intoんあの.