8000 Error when user provides a customized record_factory function for 10.0 version · Issue #59 · xolox/python-coloredlogs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Error when user provides a customized record_factory function for 10.0 version #59

New issue

Have a q 8000 uestion about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WeijieH opened this issue Aug 28, 2018 · 1 comment
Closed

Error when user provides a customized record_factory function for 10.0 version #59

WeijieH opened this issue Aug 28, 2018 · 1 comment
Labels
bug

Comments

@WeijieH
Copy link
WeijieH commented Aug 28, 2018 •
edited by xolox
Loading

Following the logging document https://docs.python.org/3/library/logging.html
Do:

old_factory = logging.getLogRecordFactory()

def record_factory(*args, **kwargs):
    record = old_factory(*args, **kwargs)
    record.custom_attribute = 0xdecafbad
    return record

logging.setLogRecordFactory(record_factory)

Then coloredlogs 10.0 throws error:

File "C:\anaconda3\envs\pt4\lib\site-packages\coloredlogs\__init__.py", line 1110, in format
    else logging.LogRecord
TypeError: __class__ must be set to a class, not 'function' object
xolox added a commit that referenced this issue Feb 15, 2020
@xolox
Break test suite by reproducing #59 (related to #47)
1cfe038
xolox added a commit that referenced this issue Feb 15, 2020
@xolox
Restore Python < 3.2 compatibility in test suite (follow up to #59, #47)
c66b50c
@xolox xolox added the bug label Feb 15, 2020
xolox added a commit that referenced this issue Feb 15, 2020
@xolox
Release 11.1: Fix support for custom log record factories (#59, #65)
b929c0b
@xolox xolox closed this as completed in 4a8abd9 Feb 15, 2020
@xolox
Copy link
Owner
xolox commented Feb 15, 2020

Hey Weijie and thanks for the feedback! I've just released coloredlogs 11.1 which should resolve the problem you reported. I also added a test to avoid regressions in the future.

bors bot added a commit to duckinator/bork that referenced this issue Feb 16, 2020
@bors @pyup-bot
Merge #112
0f977b3 
112: Update coloredlogs to 12.0 r=duckinator a=pyup-bot


This PR updates [coloredlogs](https://pypi.org/project/coloredlogs) from **11.0** to **12.0**.



<details>
  <summary>Changelog</summary>
  
  
   ### 12.0
   ```
   ----------------------------

Two backwards incompatible changes prompted another major version bump:

- Merged pull request `80`_ that drops support for Python 3.4 which
  has gone end-of-life and now represents less than 1% of PyPI downloads.

- Improved compatibility with the Python standard library by changing
  the order of positional arguments received by the initializer of the
  :class:`~coloredlogs.ColoredFormatter` class (as suggested in `64`_
  and `75`_).

.. _Release 12.0: xolox/python-coloredlogs@11.3...12.0
.. _80: xolox/python-coloredlogs#80
.. _64: xolox/python-coloredlogs#64
.. _75: xolox/python-coloredlogs#75
   ```
   
  
  
   ### 11.3
   ```
   ----------------------------

- Add support for the ``%(username)s`` field (requested in `76`_) and properly
  document supported custom fields.

- Consistently use ``console`` highlighting in documentation.

- Fix a broken link in the readme.

.. _Release 11.3: xolox/python-coloredlogs@11.2...11.3
.. _76: xolox/python-coloredlogs#76
   ```
   
  
  
   ### 11.2
   ```
   ----------------------------

Merge pull request `79`_ which adds support for Python 3.8.

.. _Release 11.2: xolox/python-coloredlogs@11.1...11.2
.. _79: xolox/python-coloredlogs#79
   ```
   
  
  
   ### 11.1
   ```
   ----------------------------

Starting with the previous release I&#39;ve resolved to try and tackle the large
number of open issues after an unplanned hiatus from the development and
maintenance of my open source projects, so here are some more bug fixes:

- Fix support for custom log record factories and add a test to avoid
  regressions (`47`_, `59`_).

- Change ``make screenshots`` to be Python 3 compatible and document
  additional requirements (`65`_).

.. _Release 11.1: xolox/python-coloredlogs@11.0...11.1
.. _59: xolox/python-coloredlogs#59
.. _65: xolox/python-coloredlogs#65
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/coloredlogs
  - Changelog: https://pyup.io/changelogs/coloredlogs/
  - Docs: https://coloredlogs.readthedocs.io
</details>



Co-authored-by: pyup-bot <github-bot@pyup.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xolox @WeijieH
0