Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 6 commits
- 6 files changed
- 1 contributor
Commits on Feb 15, 2020
-
-
-
-
Try to fix #59 by simplifying approach (removing #47)
To be honest I'm not sure why I merged #47 without critically thinking through how it would actually work, because I spotted several mistakes now, reevaluating how it was supposed to work: - logging.getLogRecordFactory() is documented to "return a callable which is used to create a LogRecord" so conceptually "two levels of calls" are required for proper usage, however coloredlogs only performed "one level of calls" as opposed to two. - Regardless of the above, the relevant code in coloredlogs is intended to make lightweight copies of existing LogRecord objects, not really construct new ones, so in retrospect logging.getLogRecordFactory() seems like the wrong tool for the job. - I don't know why I didn't write the "lightweight instance copy" code to just copy the __class__ from the original LogRecord instance to begin with, but this now seems to me to be the more reasonable approach (that should have been used from the beginning). - I believe this new approach will be more compatible with custom log record factories based on the fact that it simply doesn't interact with them in any meaningful way 😇.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 11.0...11.1