Levoit Superior 6000S to also return auto_humidity like other humidifiers #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With different names being used for target humidity it makes upstream code more complicated. This offers that same data in the standard name as well.
18 tasks
|
@webdjoe any feedback on this? It resolves a bug that exists in the 2025.2 home assistant core integration so I would love to have this merged and into the core code before that release. |
|
Perfect timing, I'll merge once the checks complete |
|
Awesome thank you! Once you have a release out I will create a PR for HA. |
|
Can we have a new release pushed out? |
|
Sorry for delay, released 2.1.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With different names being used for target humidity it makes upstream code more complicated. This offers that same data in the standard name as well. @iprak this is to fix an item reported in the forms around your PR.