8000 Vesync switch humidifier to property by cdnninja · Pull Request #135949 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Vesync switch humidifier to property #135949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2025
Merged

Vesync switch humidifier to property #135949

merged 2 commits into from
Jan 19, 2025

Conversation

cdnninja
Copy link
Contributor
@cdnninja cdnninja commented Jan 18, 2025 •
edited
Loading

Proposed change

Switch to the parameter for the data point of target humidity. This is to solve:

#129120 (comment)

This prepares for: webdjoe/pyvesync#269 It however can be merged in advance as the functional humidifiers already have this property.
This will make this humidifier type return the data in the same variable name. No harm in merging this first as the other humidifiers already have this data point.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • [] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @markperdue, @webdjoe, @TheGardenMonkey, @iprak, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@iprak
Copy link
Contributor
iprak commented Jan 18, 2025 •
edited
Loading

Tested out the change and it works fine.

If this sufficient to officially support Unify 6000s then that should be added to the integration documentation.

@cdnninja
Copy link
Contributor Author

I am not certain, I am hoping to follow up with that tester once this is merged. I noticed a similar thing with mode so adjusting and pushing that as I type. The library already handles that one from what I can tell.

@iprak
Copy link
Contributor
iprak commented Jan 18, 2025

We switched to using property not parameter.

@iprak
Copy link
Contributor
iprak commented Jan 18, 2025

This PR needs to stay in Draft mode till pyvesync is updated. We would need to do a PR to update the pyvesync version and then this.

@cdnninja cdnninja changed the title Vesync switch humidifier to parameter Vesync switch humidifier to property Jan 18, 2025
@cdnninja
Copy link
Contributor Author

This PR needs to stay in Draft mode till pyvesync is updated. We would need to do a PR to update the pyvesync version and then this.

Was thinking it could merge since it throws exception today - and will after this is merged too until the pyvesync is fixed. I am okay waiting too though.

@iprak
Copy link
Contributor
iprak commented Jan 18, 2025

Can the PR details be reworded? It currently says that pyvesync PR needs to be merged for this to work.

@cdnninja
Copy link
Contributor Author

Tried to clarify and update the wording. For this to fix the issue it will need the underlying library, however doesn't make anything worse in the process if merged now.

@joostlek joostlek merged commit 85bea5b into home-assistant:dev Jan 19, 2025
32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
@cdnninja cdnninja deleted the auto_humidity branch February 6, 2025 01:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed integration: vesync Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdnninja @iprak @joostlek
0