Visual step doesn't process defined exclusions in case of custom configuration #4597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4597 +/- ##
============================================
- Coverage 97.40% 97.39% -0.02%
- Complexity 6491 6726 +235
============================================
Files 906 906
Lines 18667 18671 +4
Branches 1240 1241 +1
============================================
+ Hits 18182 18184 +2
- Misses 379 380 +1
- Partials 106 107 +1 ☔ View full report in Codecov by Sentry. |
valfirst
reviewed
Nov 24, 2023
| @@ -122,6 +124,10 @@ private AShot createAShot(String strategyName) | |||
| String.format("Unknown shooting strategy with the name: %s", strategyName)); | |||
| }; | |||
| shootingStrategy = decorateWithScrollbarHiding(shootingStrategy, Optional.empty()); | |||
| shootingStrategy = Objects.isNull(screenshotParameters) | |||
There was a problem hiding this comment.
Suggested change
| shootingStrategy = Objects.isNull(screenshotParameters) | |
| shootingStrategy = screenshotParameters == null |
c6dc5cb to
41b01ad
Compare
valfirst
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario for reproducing:
Given I am on page with URL
https://www.google.com/When I change context to element located
xpath(//*[@id="CXQnmb"])When I compare_against baseline with name
${profile}-${resolution}-testignoring:|ELEMENT |
|By.xpath(//*[@id="uMousc"])|
using screenshot configuration:
|shootingStrategy|
|SIMPLE |
Before changes:
After changes:
