8000 Visual step doesn't process defined exclusions in case of custom configuration by PavelSakharchuk · Pull Request #4562 · vividus-framework/vividus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Visual step doesn't process defined exclusions in case of custom configuration #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Visual step doesn't process defined exclusions in case of custom configuration #4562

wants to merge 5 commits into from

Conversation

PavelSakharchuk
Copy link
Contributor

No description provided.

@PavelSakharchuk PavelSakharchuk requested a review from a team as a code owner November 13, 2023 22:19
@PavelSakharchuk PavelSakharchuk force-pushed the Visual_step_doesn't_process_defined_exclusions_in_case_of_custom_configuration branch 3 times, most recently from 11aa45b to f3b242d Compare November 14, 2023 09:49
@codecov Codecov
Copy link
codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3e05a4) 97.37% compared to head (bdfd53b) 97.37%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #4562   +/-   ##
=========================================
  Coverage     97.37%   97.37%           
- Complexity     6459     6462    +3     
=========================================
  Files           899      899           
  Lines         18615    18619    +4     
  Branches       1241     1242    +1     
=========================================
+ Hits          18126    18130    +4     
  Misses          380      380           
  Partials        109      109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PavelSakharchuk PavelSakharchuk force-pushed the Visual_step_doesn't_process_defined_exclusions_in_case_of_custom_configuration branch 2 times, most recently from e8f122e to 213182c Compare November 14, 2023 16:45
valfirst
valfirst reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator
@valfirst valfirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an integration test

@PavelSakharchuk PavelSakharchuk force-pushed the Visual_step_doesn't_process_defined_exclusions_in_case_of_custom_configuration branch 8 times, most recently from 8e509ee to cdad2fa Compare November 18, 2023 09:24
PavelSakharchuk and others added 5 commits November 19, 2023 15:07
@PavelSakharchuk
Visual step doesn't process defined exclusions in case of custom conf…
bc5a476 
…iguration
@PavelSakharchuk
Add Integration shootingStrategy tests
a9da95d
@PavelSakharchuk
Delete vividus-tests/src/main/resources/baselines/visual-viewportPast…
572ab8d 
…ing-shootingStrategy-with-ignores.png

Delete visual-viewportPasting-shootingStrategy-with-ignores.png
@PavelSakharchuk
Delete vividus-tests/src/main/resources/baselines/visual-simple-shoot…
e00ff37 
…ingStrategy-with-ignores.png

Delete visual-simple-shootingStrategy-with-ignores.png
@PavelSakharchuk
Updated baselines for shootingStrategy tests
bdfd53b 
Updated baselines for shootingStrategy tests
@PavelSakharchuk PavelSakharchuk force-pushed the Visual_step_doesn't_process_defined_exclusions_in_case_of_custom_configuration branch from cdad2fa to bdfd53b Compare November 19, 2023 14:07
@valfirst
Copy link
Collaborator

Superseded by #4597

@valfirst valfirst closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst valfirst left review comments

@vkepin vkepin Awaiting requested review from vkepin vkepin is a code owner automatically assigned from vividus-framework/maintainers

@draker94 draker94 Awaiting requested review from draker94 draker94 is a code owner automatically assigned from vividus-framework/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PavelSakharchuk @valfirst
0