fix(build): update @nuxt/module-builder to 1.0.1 #362
Conversation
This update fixes a bug that caused <script setup> SFCs to not be transformed during the build.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request updates the configuration for several packages. In Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of t 10000 he bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
pnpm-workspace.yaml (1)
18-18: Clarify Pre-release Tag for @nuxt/module-builder
The dependency for@nuxt/module-builderis now specified as"alpha", which uses a pre-release tag. For better clarity and reproducibility, consider using an explicit version string (e.g.,"1.0.0-alpha") if that is what is intended.tsconfig.json (1)
2-7: Explicit Compiler Configuration in tsconfig.json
Removing the"extends"property and introducing explicit"compilerOptions"(with"module": "Preserve","moduleResolution": "bundler","strict": true, and"noEmit": true) creates a self-contained configuration. Verify that these settings fully capture the necessary compiler behavior from the previously inherited configuration. It might help to cross-check the old settings to avoid any unintended regressions.packages/nuxt/package.json (2)
16-17: ES Module Export Changes
The update in the exports field now designates"types": "./dist/types.d.mts"and"import": "./dist/module.mjs". This aligns with the transition from CommonJS to ESM and the updated TypeScript declaration format. Consider adding documentation or migration notes for consumers that may depend on the legacy CommonJS entries.
33-34: Transition from "main" to "module"
Replacing the old"main"property with"module": "./dist/module.mjs"(and syncing the"types"field accordingly) reinforces the package’s commitment to ESM. Ensure that this breaking change is clearly communicated to end users who might be relying on the previous configuration.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
packages/nuxt/package.json(2 hunks)pnpm-workspace.yaml(2 hunks)tsconfig.json(1 hunks)
🔇 Additional comments (1)
pnpm-workspace.yaml (1)
60-60: Updated TypeScript Version Range
The update fortypescriptto"^5.7.3"widens the version acceptance to include newer minor or patch releases. Please confirm that all project components are compatible with these updates and that this flexibility will not introduce unexpected breaking changes.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tsconfig.json (1)
2-8: Explicit Compiler Options SetThe removal of the
"extends"property and the introduction of an explicit"compilerOptions"block clearly signal a move toward a more self-contained configuration. The settings—"target": "ESNext","module": "Preserve", and"moduleResolution": "bundler"—are oriented toward using modern JavaScript features and optimizing for your current build system (e.g., nuxt/module-builder). However, please ensure that:
- These options align with your overall project requirements and do not omit any important shared configuration previously inherited.
- Your build tooling (and any other integrated tools) fully supports
"module": "Preserve"and"moduleResolution": "bundler".Consider adding an inline comment documenting the rationale behind these changes to aid future maintainers.
…e before merging.
- @nuxt-module-builder: ^1.0.1 - typescript: ^5.8.3 - vue-tsc: ^2.2.10
Deploying play-una-ui with
|
| Latest commit: |
a9f8268
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88b95067.play-una-ui.pages.dev |
| Branch Preview URL: | https://fix-precompile-sfcs.play-una-ui.pages.dev |
|
With the updated dependencies, all components can be compiled (+ I'd submit an upstream issue, but I can't figure out a reproduction. I also couldn't get it to strip the |
|
Deduping dependencies appears to have fixed the generics issue. |
|
Random build failures are caused by nuxt-contrib/vue-sfc-transformer#40 |
This update fixes a bug that caused <script setup lang="ts"> SFCs to not be transformed during the build, so it would pass that work to the dev server.
Related upstream issues:
.d.tsFiles not generated for components with script setup nuxt/module-builder#349vue-sfc-transformerif installed unjs/mkdist#300Note: Some components failed to generate .d.ts files without theThis has been fixed.@vue/runtime-corepatches. This will need to be resolved upstream before merging.Summary by CodeRabbit
Summary by CodeRabbit