8000 feat(build): update @nuxt/module-builder to 1.0.1 (v2) by mattmess1221 · Pull Request #406 · una-ui/una-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(build): update @nuxt/module-builder to 1.0.1 (v2) #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 7, 2025

Conversation

mattmess1221
Copy link
Collaborator
@mattmess1221 mattmess1221 commented May 5, 2025

Second attempt at #362

Optionally blocked by:

The build will randomly fail until the next version of vue-sfc-transformer is released.

Summary by CodeRabbit

  • Chores
    • Removed CommonJS support from several packages, now supporting only ES module entry points.
    • Updated type declaration paths to use .d.mts extensions.
    • Added strict TypeScript configuration files to improve type safety.
    • Updated workspace dependency versions for improved compatibility and maintenance.
    • Removed TypeScript as a direct dependency from one package.

Copy link
vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
una-ui-docs ✅ Ready (Inspect) Visit Preview May 6, 2025 11:25pm

Copy link
coderabbitai bot commented May 5, 2025

Walkthrough

This set of changes removes explicit CommonJS (CJS) support from multiple packages within the repository. Build configurations are updated to stop emitting CJS modules, and package.json files are revised to eliminate CJS entry points in favor of ES module (ESM) only exports. New TypeScript configuration files are added to enforce ESNext output and strict type-checking. Additionally, workspace dependency versions for @nuxt/module-builder and typescript are updated to newer versions.

Changes

Files/Paths Change Summary
packages/extractor-vue-script/build.config.ts
packages/preset/build.config.ts
Removed rollup: { emitCJS: true } from build configs to stop emitting CommonJS modules.
packages/extractor-vue-script/package.json
packages/preset/package.json
packages/nuxt/package.json
Removed all CommonJS (require/main) entry points; now only ESM (import/module) exports. Updated type declaration paths as needed.
packages/extractor-vue-script/tsconfig.json
packages/preset/tsconfig.json
Added TypeScript configs targeting ESNext, using bundler module resolution, and enabling strict mode.
pnpm-workspace.yaml Updated @nuxt/module-builder and typescript version constraints.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Package
    participant Consumer

    Developer->>Package: Publishes package (ESM only)
    Consumer->>Package: Imports using ESM path
    Package-->>Consumer: Provides ESM module
Loading

Possibly related PRs

Suggested labels

c: dependencies 📦, c: bug 🐞

Suggested reviewers

  • phojie

Poem

A hop and a skip, away goes CJS,
ES modules shine, in strict TypeScript dress.
The configs are tidy, the exports are neat,
With modern conventions, our modules compete.
New versions we greet, as the workspace aligns—
A rabbit’s delight in these forward designs!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4995f54 and 0d258b1.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pnpm-workspace.yaml
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Cloudflare Pages: play-una-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mattmess1221 mattmess1221 changed the title fix(deps): update @nuxt/module-builder to 1.0.1 (v2) feat(build): update @nuxt/module-builder to 1.0.1 (v2) May 5, 2025
@mattmess1221 mattmess1221 marked this pull request as draft May 5, 2025 16:48
Copy link
cloudflare-workers-and-pages bot commented May 5, 2025

Deploying play-una-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d258b1
Status: ✅  Deploy successful!
Preview URL: https://533442e1.play-una-ui.pages.dev
Branch Preview URL: https://fix-precompile-sfcs.play-una-ui.pages.dev

View logs

@mattmess1221 mattmess1221 marked this pull request as ready for review May 6, 2025 23:17
Copy link
Member
@phojie phojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, Thanks @mattmess1221

@phojie phojie merged commit 0a5d5ec into main May 7, 2025
7 checks passed
@phojie phojie deleted the fix/precompile-sfcs branch May 7, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0