(PXP-8994): Populate mapping table for existing users #995
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 12162
💛 - Coveralls |
fence/__init__.py
Outdated
| from fence.config import config, DEFAULT_CFG_PATH | ||
| from fence.settings import CONFIG_SEARCH_FOLDERS | ||
|
|
||
| try: |
There was a problem hiding this comment.
what prompted this, did you run into a specific issue?
There was a problem hiding this comment.
the gen3config library should handle all this complexity with this call
Lines 328 to 332 in 57672f2
There was a problem hiding this comment.
Yeah so the issue with not loading the config here was that oidc = config.get("OPENID_CONNECT", {}) in _get_issuer_to_idp evaluated to an empty dictionary since _get_issuer_to_idp is called when fence/models.py is imported (which happens before app_config runs).
The if os.environ.get("FENCE_CONFIG_PATH"): check is to handle loading test-fence-config.yaml when the tests are being run.
Like you're saying, though, I think this can be simplified by putting:
config.load(
config_path=os.environ.get("FENCE_CONFIG_PATH"),
search_folders=CONFIG_SEARCH_FOLDERS
)
in place of the whole try/except.
There was a problem hiding this comment.
Gotcha, yeah I'd rather contain this logic within the gen3config library, so changing to that .load call would make me feel better
Co-authored-by: Alexander VanTol <Avantol13@users.noreply.github.com>
Jira Ticket: PXP-8994
Populate
iss_sub_pair_to_usertable usingUsertable'sid_from_idpcolumn. Population ofUsertable'sid_from_idpcolumn began with the2021.12release, which included this related PR.New Features
iss_sub_pair_to_usertable usingUsertable'sid_from_idpcolumn