8000 feat(users): add id from idp to db table if possible (also update exi… by Avantol13 · Pull Request #975 · uc-cdis/fence · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(users): add id from idp to db table if possible (also update exi… #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2021
Merged

feat(users): add id from idp to db table if possible (also update exi… #975

merged 4 commits into from
Nov 11, 2021

Conversation

Avantol13
Copy link
Contributor

…sting entries)

New Features

Breaking Changes

Bug Fixes

Improvements

  • populate the ID the IdP uses in the database if provided (for future reference) NOTE: This may be the same as the unique username determined, but if not, this allows storing both

Dependency updates

Deployment changes

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link
coveralls commented Nov 10, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 11957

  • 27 of 32 (84.38%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 72.251%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/resources/openid/cognito_oauth2.py 0 1 0.0%
fence/resources/openid/google_oauth2.py 0 1 0.0%
fence/resources/openid/okta_oauth2.py 0 1 0.0%
fence/resources/openid/orcid_oauth2.py 0 1 0.0%
fence/resources/openid/ras_oauth2.py 0 1 0.0%
Totals Coverage Status
Change from base Build 11932: 0.08%
Covered Lines: 6465
Relevant Lines: 8948
💛 - Coveralls

johnfrancismccann
johnfrancismccann reviewed Nov 10, 2021
View reviewed changes
fence/blueprints/login/base.py
@@ -101,33 +112,36 @@ def get(self):
result = self.client.get_user_id(code)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that RASOauth2Client.get_user_id (and get_user_id of any other clients for which we want to store sub) will need to be updated to also return sub.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, really good catch. Yup, just pushed an update

@Avantol13 Avantol13 merged commit 8370e56 into master Nov 11, 2021
@Avantol13 Avantol13 deleted the feat/id_from_idp branch November 11, 2021 20:53
@johnfrancismccann johnfrancismccann mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnfrancismccann johnfrancismccann johnfrancismccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Avantol13 @coveralls @johnfrancismccann @Avantol13-machine-user
0