mv: fix moving FIFO to a different filesystem #7241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
c9d7d0f to
5cbcfb0
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Jan 31, 2025
|
GNU testsuite comparison: |
sylvestre
reviewed
Feb 1, 2025
sylvestre
reviewed
Feb 1, 2025
| #[ignore = "requires access to a different filesystem"] | ||
| #[test] | ||
| fn test_special_file_different_filesystem() { | ||
| let (at, mut ucmd) = at_and_ucmd!(); |
There was a problem hiding this comment.
I just now tried to use the new TestScenario::mount_temp_fs() but I couldn't figure out how to get this test working with it. I just left a TODO comment mentioning it.
There was a problem hiding this comment.
@matrixhead any idea ? :)
|
GNU testsuite comparison: |
f018879 to
90465ac
Compare
|
GNU testsuite comparison: |
|
@jfinkels sorry but could you please rebase it? |
|
I'll do that, but I'll also break some of these changes out into smaller pull requests. |
This was referenced Apr 18, 2025
90465ac to
3b224bc
Compare
Fix a bug in `mv` where it would hang indefinitely while trying to copy a FIFO across filesystems. The solution is to remove the old FIFO and create a new one on the new filesystem. Fixes uutils#7076
3b224bc to
2717f9c
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in
mvwhere it would hang indefinitely while trying to copya FIFO across filesystems. The solution is to remove the old FIFO and
create a new one on the new filesystem.
The first commit factors out helper functions from theThis was done in pull request #7774rename_with_fallback()functionso that there is one fallback helper per file type (symlink, directory,
or file). This doesn't change the functionality of
mv, it is just are-organization of the code.
Fixes #7076