8000 mv: fails to copy special files across filesystems · Issue #7076 · uutils/coreutils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

mv: fails to copy special files across filesystems #7076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jfinkels opened this issue Jan 5, 2025 · 1 comment · Fixed by #7241
Closed

mv: fails to copy special files across filesystems #7076

jfinkels opened this issue Jan 5, 2025 · 1 comment · Fixed by #7241
Assignees
@jfinkels
Labels
U - mv

Comments

@jfinkels
Copy link
Collaborator
jfinkels commented Jan 5, 2025

Environment: Ubuntu 20.04, uutils main branch (git commit 1e8e16b), GNU coreutils v8.30

Steps to reproduce:

# create a directory on a different filesystem
mkdir /dev/shm/tmp
# create a special file, in this case a FIFO
mknod pipe p
mv pipe /dev/shm/tmp

What happens now: uutils mv hangs indefinitely and never terminates.

What I expected to happen: GNU mv copies the special file to the target directory

Notes: this is causing a failure in the GNU test file tests/mv/mv-special-1.sh.

Because the source file and the destination are on different filesystems, the file is copied to the destination and then the source file is removed; this can be seen by passing the --verbose option:

$ mv --verbose pipe /dev/shm/tmp
copied 'pipe' -> '/dev/shm/tmp/pipe'
removed 'pipe'
@jfinkels jfinkels added the U - mv label Jan 5, 2025
@DaringCuteSeal
Copy link
Contributor

I think we need to create a new file and copy its attributes instead of solely relying on fs::copy, kinda like how cp does it when the --no-dereference option is passed. if we do that now we'd get like three identical functions both in cp and mv relating to the attributes copying operation.

this makes me want to put the entire cp into uucore.. think the whole app. but minus the progressbar, though i will have no idea of how to expose the internal progress of the copy call to the caller. a closure should be fine? but seriously this is some refactor worthy of consideration imho

@jfinkels jfinkels self-assigned this Jan 29, 2025
jfinkels added a commit to jfinkels/coreutils that referenced this issue Jan 29, 2025
@jfinkels
mv: fix moving FIFO to a different filesystem
794e41a 
Fix a bug in `mv` where it would hang indefinitely while trying to copy
a FIFO across filesystems. The solution is to remove the old FIFO and
create a new one on the new filesystem.

Fixes uutils#7076
@jfinkels jfinkels mentioned this issue Jan 29, 2025
Merged
jfinkels added a commit to jfinkels/coreutils that referenced this issue Jan 30, 2025
@jfinkels
mv: fix moving FIFO to a different filesystem
5cbcfb0 
Fix a bug in `mv` where it would hang indefinitely while trying to copy
a FIFO across filesystems. The solution is to remove the old FIFO and
create a new one on the new filesystem.

Fixes uutils#7076
sylvestre pushed a commit to jfinkels/coreutils that referenced this issue Feb 14, 2025
@jfinkels @sylvestre
mv: fix moving FIFO to a different filesystem
d74d8d1 
Fix a bug in `mv` where it would hang indefinitely while trying to copy
a FIFO across filesystems. The solution is to remove the old FIFO and
create a new one on the new filesystem.

Fixes uutils#7076
jfinkels added a commit to jfinkels/coreutils that referenced this issue Apr 19, 2025
@jfinkels
mv: fix moving FIFO to a different filesystem
3b224bc 
Fix a bug in `mv` where it would hang indefinitely while trying to copy
a FIFO across filesystems. The solution is to remove the old FIFO and
create a new one on the new filesystem.

Fixes uutils#7076
sm-moshi pushed a commit to sm-moshi/coreutils that referenced this issue Apr 23, 2025
@jfinkels @sm-moshi
mv: fix moving FIFO to a different filesystem
923faaf 
Fix a bug in `mv` where it would hang indefinitely while trying to copy
a FIFO across filesystems. The solution is to remove the old FIFO and
create a new one on the new filesystem.

Fixes uutils#7076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfinkels jfinkels

Labels
U - mv
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mv: fix moving FIFO to a different filesystem jfinkels/coreutils
2 participants
@jfinkels @DaringCuteSeal
0